Re: [PR] Add Snapshots table metadata [iceberg-python]

2024-03-21 Thread via GitHub
Fokko merged PR #524: URL: https://github.com/apache/iceberg-python/pull/524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add Snapshots table metadata [iceberg-python]

2024-03-21 Thread via GitHub
Fokko commented on PR #524: URL: https://github.com/apache/iceberg-python/pull/524#issuecomment-2013620848 > Just have one question: I was thinking if later we need those metadata table classes, StaticTableScan, and StaticDataTask like what Java did. These may become useful when other engin

Re: [PR] Add Snapshots table metadata [iceberg-python]

2024-03-21 Thread via GitHub
Gowthami03B commented on PR #524: URL: https://github.com/apache/iceberg-python/pull/524#issuecomment-2013119342 @Fokko Can we merge this? I am almost done with "Files" table, so I can rebase my code before creating a PR. -- This is an automated message from the Apache Git Service. To re

Re: [PR] Add Snapshots table metadata [iceberg-python]

2024-03-18 Thread via GitHub
Fokko commented on code in PR #524: URL: https://github.com/apache/iceberg-python/pull/524#discussion_r1528301582 ## tests/integration/test_writes.py: ## @@ -664,3 +668,55 @@ def test_table_properties_raise_for_none_value( session_catalog, identifier, {"format-versi

Re: [PR] Add Snapshots table metadata [iceberg-python]

2024-03-18 Thread via GitHub
Fokko commented on code in PR #524: URL: https://github.com/apache/iceberg-python/pull/524#discussion_r1528049941 ## tests/integration/test_writes.py: ## @@ -664,3 +668,55 @@ def test_table_properties_raise_for_none_value( session_catalog, identifier, {"format-versi

Re: [PR] Add Snapshots table metadata [iceberg-python]

2024-03-16 Thread via GitHub
kevinjqliu commented on code in PR #524: URL: https://github.com/apache/iceberg-python/pull/524#discussion_r1527191777 ## tests/integration/test_writes.py: ## @@ -664,3 +668,55 @@ def test_table_properties_raise_for_none_value( session_catalog, identifier, {"format-

[PR] Add Snapshots table metadata [iceberg-python]

2024-03-15 Thread via GitHub
Fokko opened a new pull request, #524: URL: https://github.com/apache/iceberg-python/pull/524 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e