Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

2025-01-29 Thread via GitHub
zeroshade merged PR #277: URL: https://github.com/apache/iceberg-go/pull/277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

2025-01-29 Thread via GitHub
dttung2905 commented on code in PR #277: URL: https://github.com/apache/iceberg-go/pull/277#discussion_r1934442770 ## README.md: ## @@ -70,6 +70,7 @@ $ cd iceberg-go/cmd/iceberg && go build . | Rename Table | X | | | X | | Drop Table

Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

2025-01-29 Thread via GitHub
dttung2905 commented on code in PR #277: URL: https://github.com/apache/iceberg-go/pull/277#discussion_r1934440947 ## catalog/rest/rest_test.go: ## @@ -844,6 +844,53 @@ func (r *RestCatalogSuite) TestCreateTable409() { r.ErrorIs(err, catalog.ErrTableAlreadyExists) } +

Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

2025-01-28 Thread via GitHub
zeroshade commented on code in PR #277: URL: https://github.com/apache/iceberg-go/pull/277#discussion_r1932843254 ## catalog/rest/rest_test.go: ## @@ -844,6 +844,53 @@ func (r *RestCatalogSuite) TestCreateTable409() { r.ErrorIs(err, catalog.ErrTableAlreadyExists) } +f

Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

2025-01-28 Thread via GitHub
zeroshade commented on code in PR #277: URL: https://github.com/apache/iceberg-go/pull/277#discussion_r1932842938 ## catalog/rest/rest_test.go: ## @@ -844,6 +844,53 @@ func (r *RestCatalogSuite) TestCreateTable409() { r.ErrorIs(err, catalog.ErrTableAlreadyExists) } +f

Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

2025-01-28 Thread via GitHub
zeroshade commented on code in PR #277: URL: https://github.com/apache/iceberg-go/pull/277#discussion_r1932842308 ## README.md: ## @@ -70,6 +70,7 @@ $ cd iceberg-go/cmd/iceberg && go build . | Rename Table | X | | | X | | Drop Table

[PR] Add CheckTableExists method for rest.go [iceberg-go]

2025-01-28 Thread via GitHub
dttung2905 opened a new pull request, #277: URL: https://github.com/apache/iceberg-go/pull/277 Similar to the `CheckNamespaceExists` method, I add a new method called `CheckTableExists` and add some unit tests -- This is an automated message from the Apache Git Service. To respond to the