Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

kevinjqliu commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2628592600 Thanks for the contribution! @shiv-io -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

kevinjqliu merged PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2606155161 @sungwy thanks for the review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

sungwy commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2606139140 This looks good to me @shiv-io ! Thank you very much for including the integration test to test the API :) Could we run `make lint` to make the CI pass? Other than that, this

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-260097 Makes sense, @sungwy -- thanks! Added the test, let me know if that looks good -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2599777169 @sungwy I'm seeing that the /v1/namespaces/default/views doesn't return any views. How would I go about adding an integration test for `view_exists` given pyiceberg currently doesn

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

Fokko commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2593215982 @shiv-io Gentle ping :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

sungwy commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2524819444 Hi @shiv-io ! Sorry this fell off my radar. Could we actually add an integration test here as well, now that we have a new REST Catalog image we are testing against that supp

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2484508752 @sungwy just bumping this in case this fell off your radar! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2463458916 @sungwy thanks for reviewing! Let me know if there's anything else. I noticed we don't yet have docs for `list_views` (#817) and `drop_views` (#820), btw. -- This is an automat

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io commented on code in PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#discussion_r1833516291 ## tests/catalog/test_rest.py: ## @@ -450,6 +450,28 @@ def test_list_views_404(rest_mock: Mocker) -> None: assert "Namespace does not exist" in str(e.value)

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

sungwy commented on code in PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#discussion_r1822580115 ## tests/catalog/test_rest.py: ## @@ -450,6 +450,28 @@ def test_list_views_404(rest_mock: Mocker) -> None: assert "Namespace does not exist" in str(e.value)

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2439162592 @sungwy I used [tabulario/iceberg-rest](https://hub.docker.com/r/tabulario/iceberg-rest) image to spin up a REST catalog server locally to test with -- This is an automated mess

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

sungwy commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2439077800 Hi @shiv-io - thank you for putting together this PR! > When I tested catalog.view_exists('default.bar') with a local REST catalog, I got the following exception. This also o

Re: [PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io commented on PR #1242: URL: https://github.com/apache/iceberg-python/pull/1242#issuecomment-2425262513 When I tested `catalog.view_exists('default.bar')` with a local REST catalog, I got the following exception. This also occurs with the existing `catalog.table_exists()` method. Is

[PR] Add `view_exists` method to REST Catalog [iceberg-python]

shiv-io opened a new pull request, #1242: URL: https://github.com/apache/iceberg-python/pull/1242 Part of the adding view support to the REST catalog: #818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above