Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
Fokko commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1611145207 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-23 Thread via GitHub
Fokko commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1611140628 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-19 Thread via GitHub
liurenjie1024 merged PR #347: URL: https://github.com/apache/iceberg-rust/pull/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-19 Thread via GitHub
liurenjie1024 commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1606044600 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-06 Thread via GitHub
sdd commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1590836313 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-05 Thread via GitHub
sdd commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1590269988 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-05 Thread via GitHub
sdd commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1590269988 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-05 Thread via GitHub
sdd commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1590269295 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-05 Thread via GitHub
marvinlanhenke commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1590269281 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-05 Thread via GitHub
sdd commented on code in PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#discussion_r1590268796 ## crates/iceberg/src/expr/visitors/inclusive_metrics_evaluator.rs: ## @@ -0,0 +1,2255 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] Add `InclusiveMetricsEvaluator` [iceberg-rust]

2024-05-04 Thread via GitHub
sdd commented on PR #347: URL: https://github.com/apache/iceberg-rust/pull/347#issuecomment-2094359196 FAO @Fokko @liurenjie1024 @marvinlanhenke: I've finished adding tests for this - it's ready for review, PTAL! 😄 -- This is an automated message from the Apache Git Service. To res