Re: [PR] Add @override [iceberg-python]

2024-11-21 Thread via GitHub
kevinjqliu commented on PR #1312: URL: https://github.com/apache/iceberg-python/pull/1312#issuecomment-2491902906 what would the utility file look like? currently we use `TYPE_CHECKING` in a bunch of places already https://grep.app/search?q=TYPE_CHECKING&filter[repo.pattern][0]=apach

Re: [PR] Add @override [iceberg-python]

2024-11-17 Thread via GitHub
cosmastech commented on PR #1312: URL: https://github.com/apache/iceberg-python/pull/1312#issuecomment-2481198369 > thanks for the PR! Looks like i was wrong and we need to do something like this in order to make the other python versions happy > > [#1310 (comment)](https://github.co

Re: [PR] Add @override [iceberg-python]

2024-11-12 Thread via GitHub
kevinjqliu commented on PR #1312: URL: https://github.com/apache/iceberg-python/pull/1312#issuecomment-2471317184 thanks for the PR! Looks like i was wrong and we need to do something like this in order to make the other python versions happy https://github.com/apache/iceberg-python/i

Re: [PR] Add @override [iceberg-python]

2024-11-12 Thread via GitHub
cosmastech commented on PR #1312: URL: https://github.com/apache/iceberg-python/pull/1312#issuecomment-2471110050 @kevinjqliu Would you mind taking a look at what I've implemented thus far? It looks like this is failing in the pipeline, since typing.override doesn't exist prior to 3.13. Did

[PR] Add @override [iceberg-python]

2024-11-11 Thread via GitHub
cosmastech opened a new pull request, #1312: URL: https://github.com/apache/iceberg-python/pull/1312 Resolves 1310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs