Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-24 Thread via GitHub
nastra commented on PR #11349: URL: https://github.com/apache/iceberg/pull/11349#issuecomment-2435503742 thanks @sullis, this LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-24 Thread via GitHub
nastra merged PR #11349: URL: https://github.com/apache/iceberg/pull/11349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-24 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1815134423 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-24 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1814324603 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-23 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1813136835 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-23 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1813357582 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-23 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1813357582 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-23 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1813357582 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-23 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1813154671 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-23 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1813150009 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-23 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1813146387 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-22 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1812000392 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-22 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1811981848 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-22 Thread via GitHub
sullis commented on PR #11349: URL: https://github.com/apache/iceberg/pull/11349#issuecomment-2430833263 GitHub Actions CI passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-22 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1811713157 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestMinioUtil.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-22 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1811711018 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java: ## @@ -88,12 +88,12 @@ import software.amazon.awssdk.services.s3.model.HeadObjectRequest; import so

Re: [PR] AWS: Use testcontainers-minio instead of S3Mock [iceberg]

2024-10-22 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1811706804 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestMinioUtil.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c