Re: [PR] AWS: Support setting description for Glue table [iceberg]

2024-01-25 Thread via GitHub
amogh-jahagirdar merged PR #9530: URL: https://github.com/apache/iceberg/pull/9530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] AWS: Support setting description for Glue table [iceberg]

2024-01-25 Thread via GitHub
amogh-jahagirdar commented on PR #9530: URL: https://github.com/apache/iceberg/pull/9530#issuecomment-1911232925 No problem at all @lkokhreidze thanks for the contribution, thanks @singhpk234 for the review! -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] AWS: Support setting description for Glue table [iceberg]

2024-01-24 Thread via GitHub
lkokhreidze commented on PR #9530: URL: https://github.com/apache/iceberg/pull/9530#issuecomment-1909448745 Thanks @amogh-jahagirdar and apologies, should have done it beforehand. Pushed the changes -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] AWS: Support setting description for Glue table [iceberg]

2024-01-24 Thread via GitHub
amogh-jahagirdar commented on PR #9530: URL: https://github.com/apache/iceberg/pull/9530#issuecomment-1909230880 @lkokhreidze Could you run spotless `./.gradlew spotlessApply` and push again? The spotless checks are failing. -- This is an automated message from the Apache Git Service. To

Re: [PR] AWS: Support setting description for Glue table [iceberg]

2024-01-24 Thread via GitHub
lkokhreidze commented on PR #9530: URL: https://github.com/apache/iceberg/pull/9530#issuecomment-1908004129 Thanks for the review @singhpk234! I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] AWS: Support setting description for Glue table [iceberg]

2024-01-24 Thread via GitHub
lkokhreidze commented on code in PR #9530: URL: https://github.com/apache/iceberg/pull/9530#discussion_r1464823134 ## aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java: ## @@ -59,7 +60,7 @@ private IcebergToGlueConverter() {} private static final Patte

Re: [PR] AWS: Support setting description for Glue table [iceberg]

2024-01-23 Thread via GitHub
singhpk234 commented on code in PR #9530: URL: https://github.com/apache/iceberg/pull/9530#discussion_r1464132457 ## aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java: ## @@ -59,7 +60,7 @@ private IcebergToGlueConverter() {} private static final Patter