Re: [PR] AWS: Fix S3FileIO tests failing on ListObjects for Express buckets [iceberg]

2024-08-28 Thread via GitHub
muddyfish commented on PR #10292: URL: https://github.com/apache/iceberg/pull/10292#issuecomment-2315489776 Closing in favour of https://github.com/apache/iceberg/pull/11021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] AWS: Fix S3FileIO tests failing on ListObjects for Express buckets [iceberg]

2024-08-28 Thread via GitHub
muddyfish closed pull request #10292: AWS: Fix S3FileIO tests failing on ListObjects for Express buckets URL: https://github.com/apache/iceberg/pull/10292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] AWS: Fix S3FileIO tests failing on ListObjects for Express buckets [iceberg]

2024-08-13 Thread via GitHub
steveloughran commented on code in PR #10292: URL: https://github.com/apache/iceberg/pull/10292#discussion_r1715716930 ## aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java: ## @@ -98,7 +98,7 @@ public static void cleanS3Bucket(S3Client s3, String bucketName,

Re: [PR] AWS: Fix S3FileIO tests failing on ListObjects for Express buckets [iceberg]

2024-08-13 Thread via GitHub
steveloughran commented on PR #10292: URL: https://github.com/apache/iceberg/pull/10292#issuecomment-2286808868 > This makes me wonder if we have tested s3 express with HadoopFileIO (where we require version hint and hence listing) as well as ran iceberg maintenance actions (like clean orph

Re: [PR] AWS: Fix S3FileIO tests failing on ListObjects for Express buckets [iceberg]

2024-05-13 Thread via GitHub
singhpk234 commented on PR #10292: URL: https://github.com/apache/iceberg/pull/10292#issuecomment-2108568399 > According to this PR https://github.com/apache/iceberg/pull/7914, it doesn't seem that delete_orphan_files supports S3FileIO. If/when it does, it still might not work with S3 Expre

Re: [PR] AWS: Fix S3FileIO tests failing on ListObjects for Express buckets [iceberg]

2024-05-10 Thread via GitHub
muddyfish commented on PR #10292: URL: https://github.com/apache/iceberg/pull/10292#issuecomment-2104754756 I did not try with HadoopFileIO or with Iceberg maintenance operations. According to this PR https://github.com/apache/iceberg/pull/7914, it doesn't seem that `delete_orphan_fi