Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-04 Thread via GitHub
jackye1995 commented on PR #9385: URL: https://github.com/apache/iceberg/pull/9385#issuecomment-1877659221 Seems like this is not getting much attraction from other reviewers. Given it is a pretty straightforward plugin integration, I will go ahead to merge it. We can fix things later if ne

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-04 Thread via GitHub
jackye1995 merged PR #9385: URL: https://github.com/apache/iceberg/pull/9385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1441301360 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3AccessGrantsPluginConfigurations.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
adnanhemani commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1441141271 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +796,47 @@ public void applyEndpointConfigurations(T builder) { builde

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
adnanhemani commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1441105763 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -684,6 +715,22 @@ private Set toS3Tags(Map properties, String prefix) { .col

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
adnanhemani commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1441105061 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -50,6 +51,23 @@ public class S3FileIOProperties implements Serializable { */ pu

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
adnanhemani commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1441103728 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3AccessGrantsPluginConfigurations.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440925641 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +796,47 @@ public void applyEndpointConfigurations(T builder) { builder

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440915860 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -684,6 +715,22 @@ private Set toS3Tags(Map properties, String prefix) { .coll

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440915164 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -50,6 +51,23 @@ public class S3FileIOProperties implements Serializable { */ pub

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440914203 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3AccessGrantsPluginConfigurations.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440883043 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builder

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-03 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440883043 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builder

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-02 Thread via GitHub
adnanhemani commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1440008488 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builde

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-02 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1439983680 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builder

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-02 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1439793304 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builder

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-02 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1437796852 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builder

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-02 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1439793304 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builder

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2023-12-28 Thread via GitHub
adnanhemani commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1437959281 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builde

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2023-12-28 Thread via GitHub
adnanhemani commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1437959281 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builde

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2023-12-28 Thread via GitHub
adnanhemani commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1437879000 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -50,6 +51,23 @@ public class S3FileIOProperties implements Serializable { */ pu

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2023-12-28 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1437796852 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -749,4 +795,23 @@ public void applyEndpointConfigurations(T builder) { builder

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2023-12-28 Thread via GitHub
jackye1995 commented on code in PR #9385: URL: https://github.com/apache/iceberg/pull/9385#discussion_r1437795543 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -50,6 +51,23 @@ public class S3FileIOProperties implements Serializable { */ pub

[PR] AWS: Add S3 Access Grants Integration [iceberg]

2023-12-26 Thread via GitHub
adnanhemani opened a new pull request, #9385: URL: https://github.com/apache/iceberg/pull/9385 This PR allows us to add support for S3 Access Grants (S3AG) to S3FileIO through adding a new SDK Plugin (https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/kafkaconnect/mod