RussellSpitzer commented on PR #12447:
URL: https://github.com/apache/iceberg/pull/12447#issuecomment-2715305062
Can you see who the caller is there? I'm just interested in why flink is
calling that function so often
--
This is an automated message from the Apache Git Service.
To respond
suneet-s commented on PR #12447:
URL: https://github.com/apache/iceberg/pull/12447#issuecomment-2715260800
@RussellSpitzer Thanks for reviewing this change. In a performance test we
were running where a flink pipieline was writing data to an iceberg table, we
saw that this function was taki
RussellSpitzer commented on code in PR #12447:
URL: https://github.com/apache/iceberg/pull/12447#discussion_r1989662498
##
api/src/test/java/org/apache/iceberg/transforms/TestTransformUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
RussellSpitzer commented on code in PR #12447:
URL: https://github.com/apache/iceberg/pull/12447#discussion_r1989658472
##
api/src/test/java/org/apache/iceberg/transforms/TestTransformUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
RussellSpitzer commented on code in PR #12447:
URL: https://github.com/apache/iceberg/pull/12447#discussion_r1989657396
##
api/src/test/java/org/apache/iceberg/transforms/TestTransformUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
RussellSpitzer commented on PR #12447:
URL: https://github.com/apache/iceberg/pull/12447#issuecomment-2714915616
@suneet-s What is the motivation for this change? Is toHumanString on a
critical path somewhere? I don't think I have an issue with putting in a faster
implementation as long as
suneet-s opened a new pull request, #12447:
URL: https://github.com/apache/iceberg/pull/12447
String#format uses regexes internally which can be expensive when used
repeatedly. This PR switches out the implementation for a char array
implementation that pads zeros as needed.
A simple
