Re: [PR] API: Fix equals and hashCode in CharSequenceSet [iceberg]

2023-12-21 Thread via GitHub
ajantha-bhat commented on PR #9245: URL: https://github.com/apache/iceberg/pull/9245#issuecomment-1866169340 I think this PR has produced error prone warnings. https://github.com/apache/iceberg/assets/5889404/93566564-18a2-4ad0-8f17-f3ffaab1a537";> -- This is an automated messa

Re: [PR] API: Fix equals and hashCode in CharSequenceSet [iceberg]

2023-12-16 Thread via GitHub
aokolnychyi commented on PR #9245: URL: https://github.com/apache/iceberg/pull/9245#issuecomment-1858758541 Thanks, @szehon-ho! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] API: Fix equals and hashCode in CharSequenceSet [iceberg]

2023-12-16 Thread via GitHub
aokolnychyi merged PR #9245: URL: https://github.com/apache/iceberg/pull/9245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] API: Fix equals and hashCode in CharSequenceSet [iceberg]

2023-12-16 Thread via GitHub
aokolnychyi commented on PR #9245: URL: https://github.com/apache/iceberg/pull/9245#issuecomment-1858758126 @szehon-ho, I started by extending `AbstractSet`. Unfortunately, `hashCode` does not work. It is implemented using the iterator that in our case returns unwrapped elements and breaks