Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2024-01-03 Thread via GitHub
pvary commented on PR #9302: URL: https://github.com/apache/iceberg/pull/9302#issuecomment-1875336457 @nastra: I think we can skip this for now - still think this should be some caching issue on gradle side, which is very hard to repro so not too many people is affected -- This is an aut

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-22 Thread via GitHub
nastra commented on PR #9302: URL: https://github.com/apache/iceberg/pull/9302#issuecomment-1867599839 @pvary sorry I was not able to reproduce this. I checked out the commit prior to this PR, ran `./gradlew clean build -x test -x integrationTest`, then cherry-picked this commit and ran `./

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-15 Thread via GitHub
nastra commented on PR #9302: URL: https://github.com/apache/iceberg/pull/9302#issuecomment-1858116202 @pvary thanks for the input, I think that's quite helpful. I'll take a closer look and will provide an update once I know more. -- This is an automated message from the Apache Git Servic

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-15 Thread via GitHub
pvary commented on PR #9302: URL: https://github.com/apache/iceberg/pull/9302#issuecomment-1858113490 Maybe it was a gradle issue which is fixed by a clean build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-15 Thread via GitHub
pvary commented on PR #9302: URL: https://github.com/apache/iceberg/pull/9302#issuecomment-1858112362 I am using java 8 Previuosly, I have run this: ``` $ ./gradlew :iceberg-flink:iceberg-flink-runtime-1.18:build Starting a Gradle Daemon, 1 busy Daemon could not be reused, use

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-15 Thread via GitHub
nastra commented on PR #9302: URL: https://github.com/apache/iceberg/pull/9302#issuecomment-1858058869 @pvary did you see this error on CI or just when running `./gradlew checkClassUniqueness --write-locks`? I tried to repro this but I'm not able to see that error (I tried JDK8 and JDK18).

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-15 Thread via GitHub
pvary commented on PR #9302: URL: https://github.com/apache/iceberg/pull/9302#issuecomment-1857964575 Could this be that the following error is caused by this change: ``` # Danger! Multiple jars contain identically named classes. This may cause different behaviour depending on classpat

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-14 Thread via GitHub
nastra commented on PR #9302: URL: https://github.com/apache/iceberg/pull/9302#issuecomment-1856177487 thanks for the review @amogh-jahagirdar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-14 Thread via GitHub
nastra merged PR #9302: URL: https://github.com/apache/iceberg/pull/9302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-14 Thread via GitHub
amogh-jahagirdar commented on code in PR #9302: URL: https://github.com/apache/iceberg/pull/9302#discussion_r1426944012 ## core/src/main/java/org/apache/iceberg/view/BaseSQLViewRepresentation.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-14 Thread via GitHub
nastra commented on code in PR #9302: URL: https://github.com/apache/iceberg/pull/9302#discussion_r1426926992 ## core/src/main/java/org/apache/iceberg/view/BaseSQLViewRepresentation.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] API, Core: Move SQLViewRepresentation to API [iceberg]

2023-12-14 Thread via GitHub
nastra commented on code in PR #9302: URL: https://github.com/apache/iceberg/pull/9302#discussion_r1426926992 ## core/src/main/java/org/apache/iceberg/view/BaseSQLViewRepresentation.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *