nastra merged PR #8648:
URL: https://github.com/apache/iceberg/pull/8648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra commented on PR #8648:
URL: https://github.com/apache/iceberg/pull/8648#issuecomment-1746330496
thanks for the reviews @rdblue and @amogh-jahagirdar, I've adjusted the code
accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
nastra commented on code in PR #8648:
URL: https://github.com/apache/iceberg/pull/8648#discussion_r1345349415
##
core/src/main/java/org/apache/iceberg/view/SetViewLocation.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
nastra commented on code in PR #8648:
URL: https://github.com/apache/iceberg/pull/8648#discussion_r1345339487
##
api/src/main/java/org/apache/iceberg/view/UpdateViewLocation.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
rdblue commented on code in PR #8648:
URL: https://github.com/apache/iceberg/pull/8648#discussion_r1343186994
##
api/src/main/java/org/apache/iceberg/view/View.java:
##
@@ -77,6 +77,15 @@ public interface View {
*/
Map properties();
+ /**
+ * Return the view's base l
rdblue commented on code in PR #8648:
URL: https://github.com/apache/iceberg/pull/8648#discussion_r1343154772
##
core/src/main/java/org/apache/iceberg/view/SetViewLocation.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
rdblue commented on code in PR #8648:
URL: https://github.com/apache/iceberg/pull/8648#discussion_r1343154283
##
api/src/main/java/org/apache/iceberg/view/UpdateViewLocation.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more