Re: [PR] API, Core: Add withUpdatedColumnDoc API to Schema [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442516050 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1739,4 +1739,61 @@ public void testSqlForInvalidArguments() { .isInstanceO

Re: [PR] API, Core: Add withUpdatedColumnDoc API to Schema [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442512815 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1739,4 +1739,61 @@ public void testSqlForInvalidArguments() { .isInstanceO

[PR] API, Core: Add withUpdatedColumnDoc API to Schema [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar opened a new pull request, #9414: URL: https://github.com/apache/iceberg/pull/9414 When working on Trino Iceberg view support, I realized that updating column comments across engines is the same logic 1.) Get the view schema 2.) Find the field to update, update it 3.)