aokolnychyi merged PR #11446:
URL: https://github.com/apache/iceberg/pull/11446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@icebe
aokolnychyi commented on PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#issuecomment-2455433971
Thanks for reviewing, @nastra @rdblue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
aokolnychyi commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1828054136
##
api/src/main/java/org/apache/iceberg/AddedRowsScanTask.java:
##
@@ -55,7 +56,7 @@ default ChangelogOperation operation() {
@Override
default long sizeB
rdblue commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1828049989
##
api/src/main/java/org/apache/iceberg/AddedRowsScanTask.java:
##
@@ -55,7 +56,7 @@ default ChangelogOperation operation() {
@Override
default long sizeBytes(
nastra commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1827524332
##
core/src/main/java/org/apache/iceberg/FileMetadata.java:
##
@@ -240,6 +252,14 @@ public DeleteFile build() {
Preconditions.checkArgument(fileSizeInBytes >= 0
aokolnychyi commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1827412102
##
core/src/main/java/org/apache/iceberg/FileMetadata.java:
##
@@ -240,6 +252,14 @@ public DeleteFile build() {
Preconditions.checkArgument(fileSizeInBytes
aokolnychyi commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1827411283
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriterMetrics.java:
##
@@ -79,7 +80,7 @@ void updateFlushResult(WriteResult result)
aokolnychyi commented on PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#issuecomment-2454158774
@manuzhang, good call. Linked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
manuzhang commented on PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#issuecomment-2453940765
Thanks, Anton. I think it will be valuable to link this and previous PRs to
the proposal issue, https://github.com/apache/iceberg/issues/11122.
--
This is an automated message from
aokolnychyi commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1826712824
##
api/src/main/java/org/apache/iceberg/util/ContentFileUtil.java:
##
@@ -84,4 +85,25 @@ public static String referencedDataFileLocation(DeleteFile
deleteFile) {
aokolnychyi commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1826603449
##
api/src/main/java/org/apache/iceberg/AddedRowsScanTask.java:
##
@@ -55,7 +56,7 @@ default ChangelogOperation operation() {
@Override
default long sizeB
aokolnychyi commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1826603449
##
api/src/main/java/org/apache/iceberg/AddedRowsScanTask.java:
##
@@ -55,7 +56,7 @@ default ChangelogOperation operation() {
@Override
default long sizeB
12 matches
Mail list logo
