Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu commented on PR #1590: URL: https://github.com/apache/iceberg-python/pull/1590#issuecomment-2638868270 duplicate of #1533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

2025-02-05 Thread via GitHub
kevinjqliu closed pull request #1590: 1191:Added Docstring and Fixed linter error URL: https://github.com/apache/iceberg-python/pull/1590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

2025-02-01 Thread via GitHub
gayatrikate04 commented on PR #1590: URL: https://github.com/apache/iceberg-python/pull/1590#issuecomment-2628893413 I've removed the mkdocs = "^1.6.1" dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

2025-01-31 Thread via GitHub
kevinjqliu commented on PR #1590: URL: https://github.com/apache/iceberg-python/pull/1590#issuecomment-2628604908 hey @gayatrikate04 looks like theres are changes that added `mkdocs = "^1.6.1"` as a dependency. I dont think its necessary for documentation related changes, can you remove tho

Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

2025-01-30 Thread via GitHub
gayatrikate04 commented on PR #1590: URL: https://github.com/apache/iceberg-python/pull/1590#issuecomment-2624500709 Hi @kevinjzhu, thank you for pointing that out! I created a new PR (#1590) instead of merging into the old PR (#1533) because I encountered errors while trying to merge chang

Re: [PR] 1191:Added Docstring and Fixed linter error [iceberg-python]

2025-01-29 Thread via GitHub
kevinjqliu commented on PR #1590: URL: https://github.com/apache/iceberg-python/pull/1590#issuecomment-2622145994 Hi @gayatrikate04 since this is the same set of changes as #1533, can we reuse #1533? -- This is an automated message from the Apache Git Service. To respond to the message,