Re: [PR] [wip] Table updates [iceberg-python]

2024-07-29 Thread via GitHub
chinmay-bhat commented on code in PR #950: URL: https://github.com/apache/iceberg-python/pull/950#discussion_r1694696015 ## pyiceberg/table/__init__.py: ## @@ -1129,12 +1128,22 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl return base_

Re: [PR] [wip] Table updates [iceberg-python]

2024-07-23 Thread via GitHub
kevinjqliu commented on code in PR #950: URL: https://github.com/apache/iceberg-python/pull/950#discussion_r1688474030 ## pyiceberg/table/__init__.py: ## @@ -1129,12 +1128,22 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl return base_me

Re: [PR] [wip] Table updates [iceberg-python]

2024-07-23 Thread via GitHub
kevinjqliu commented on code in PR #950: URL: https://github.com/apache/iceberg-python/pull/950#discussion_r1688472983 ## pyiceberg/table/__init__.py: ## @@ -1129,12 +1128,22 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl return base_me

Re: [PR] [wip] Table updates [iceberg-python]

2024-07-23 Thread via GitHub
chinmay-bhat commented on code in PR #950: URL: https://github.com/apache/iceberg-python/pull/950#discussion_r1688121549 ## pyiceberg/table/__init__.py: ## @@ -1129,12 +1128,22 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl return base_

Re: [PR] [wip] Table updates [iceberg-python]

2024-07-23 Thread via GitHub
chinmay-bhat commented on code in PR #950: URL: https://github.com/apache/iceberg-python/pull/950#discussion_r1688121549 ## pyiceberg/table/__init__.py: ## @@ -1129,12 +1128,22 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl return base_

[PR] [wip] Table updates [iceberg-python]

2024-07-21 Thread via GitHub
kevinjqliu opened a new pull request, #950: URL: https://github.com/apache/iceberg-python/pull/950 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri