Re: [PR] Flink: Fix config key typo in error message of SplitComparators [iceberg]

2024-11-06 Thread via GitHub
szehon-ho commented on PR #11482: URL: https://github.com/apache/iceberg/pull/11482#issuecomment-2460945441 Thanks @liuml07 and @huaxingao for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Flink: Fix config key typo in error message of SplitComparators [iceberg]

2024-11-06 Thread via GitHub
szehon-ho merged PR #11482: URL: https://github.com/apache/iceberg/pull/11482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

[PR] [flink] Fix config key typo in error message of SplitComparators [iceberg]

2024-11-06 Thread via GitHub
liuml07 opened a new pull request, #11482: URL: https://github.com/apache/iceberg/pull/11482 `split-open-file-cost` should be `split-file-open-cost`. Or simply use the const variable for constructing the error message. Also updated the test that asserts error message. -- This is an autom