Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-22 Thread via GitHub
marvinlanhenke commented on PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#issuecomment-2069378623 > Thanks! Sorry for replying late. I think this is a good start for the integration work. And I have completed #277. Maybe we can convert this PR to ready for review now. @marvi

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-22 Thread via GitHub
marvinlanhenke commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1574731993 ## crates/integrations/datafusion/src/catalog.rs: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor l

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-21 Thread via GitHub
ZENOTME commented on PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#issuecomment-2068383273 Thanks! Sorry for replying late. I think this is a good start for the integration work. And I have completed https://github.com/apache/iceberg-rust/pull/277. Maybe we can convert this

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-18 Thread via GitHub
simonvandel commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1570757993 ## crates/integrations/datafusion/src/catalog.rs: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-14 Thread via GitHub
tshauck commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1564807159 ## crates/integrations/src/datafusion/schema.rs: ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-13 Thread via GitHub
marvinlanhenke commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1563872514 ## Cargo.toml: ## @@ -21,6 +21,7 @@ members = [ "crates/catalog/*", "crates/examples", "crates/iceberg", +"crates/integrations", Review Co

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-12 Thread via GitHub
tshauck commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1562769346 ## crates/integrations/src/datafusion/schema.rs: ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-12 Thread via GitHub
tshauck commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1562769346 ## crates/integrations/src/datafusion/schema.rs: ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-12 Thread via GitHub
tshauck commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1562767139 ## Cargo.toml: ## @@ -21,6 +21,7 @@ members = [ "crates/catalog/*", "crates/examples", "crates/iceberg", +"crates/integrations", Review Comment:

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-12 Thread via GitHub
marvinlanhenke commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1562444674 ## crates/integrations/src/datafusion/schema.rs: ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-12 Thread via GitHub
marvinlanhenke commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1562442128 ## Cargo.toml: ## @@ -21,6 +21,7 @@ members = [ "crates/catalog/*", "crates/examples", "crates/iceberg", +"crates/integrations", Review Co

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-11 Thread via GitHub
tshauck commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1561484967 ## crates/integrations/src/datafusion/schema.rs: ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-11 Thread via GitHub
marvinlanhenke commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1561387375 ## Cargo.toml: ## @@ -21,6 +21,7 @@ members = [ "crates/catalog/*", "crates/examples", "crates/iceberg", +"crates/integrations", Review Co

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-11 Thread via GitHub
marvinlanhenke commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1561386024 ## crates/integrations/src/datafusion/schema.rs: ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-11 Thread via GitHub
tshauck commented on code in PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#discussion_r1561209884 ## Cargo.toml: ## @@ -21,6 +21,7 @@ members = [ "crates/catalog/*", "crates/examples", "crates/iceberg", +"crates/integrations", Review Comment:

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-05 Thread via GitHub
liurenjie1024 commented on PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#issuecomment-2040961957 Thanks @marvinlanhenke This is amazing, I'll take a review later! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [WIP] Integration with Datafusion [iceberg-rust]

2024-04-05 Thread via GitHub
marvinlanhenke commented on PR #324: URL: https://github.com/apache/iceberg-rust/pull/324#issuecomment-2040961635 @liurenjie1024 @ZENOTME @Fokko PTAL and let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to