Re: [I] v1 table data file spec id is None [iceberg-python]

2023-10-16 Thread via GitHub
puchengy closed issue #46: v1 table data file spec id is None URL: https://github.com/apache/iceberg-python/issues/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] v1 table data file spec id is None [iceberg-python]

2023-10-11 Thread via GitHub
Fokko commented on issue #46: URL: https://github.com/apache/iceberg-python/issues/46#issuecomment-1758086469 @puchengy Sorry for not replying. I think we can include this in the next release, it shouldn't be too hard to carry this information from the manifest-list -- This is an automat

Re: [I] v1 table data file spec id is None [iceberg-python]

2023-10-11 Thread via GitHub
puchengy commented on issue #46: URL: https://github.com/apache/iceberg-python/issues/46#issuecomment-1758067827 @Fokko do you know? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] v1 table data file spec id is None [iceberg-python]

2023-10-07 Thread via GitHub
puchengy commented on issue #46: URL: https://github.com/apache/iceberg-python/issues/46#issuecomment-1751741939 @Fokko And based on the https://github.com/apache/iceberg/pull/8730 it seems that we would like to inherent the spec id from manifest file as well? https://github.com/apache/iceb

Re: [I] v1 table data file spec id is None [iceberg-python]

2023-10-07 Thread via GitHub
puchengy commented on issue #46: URL: https://github.com/apache/iceberg-python/issues/46#issuecomment-1751740812 @Fokko Hi, I thought we already have that https://github.com/apache/iceberg/blob/pyiceberg-0.4.0rc2/python/pyiceberg/manifest.py#L162 or is this not what you meant? -- This is

Re: [I] v1 table data file spec id is None [iceberg-python]

2023-10-07 Thread via GitHub
Fokko commented on issue #46: URL: https://github.com/apache/iceberg-python/issues/46#issuecomment-1751628211 Hey @puchengy thanks for raising this! I was unsure about this because `141: spec-id` is not mentioned in the spec, but it looks like we can add it: https://github.com/apache/

[I] v1 table data file spec id is None [iceberg-python]

2023-10-06 Thread via GitHub
puchengy opened a new issue, #46: URL: https://github.com/apache/iceberg-python/issues/46 ### Apache Iceberg version None ### Please describe the bug 🐞 v1 data file spec_id is optionally, but it seems spark is able to recognize the spec_id, but pyiceberg can't, any idea