Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]

2024-07-06 Thread via GitHub
liurenjie1024 closed issue #139: refactor: Remove `async_trait` in `Catalog` trait. URL: https://github.com/apache/iceberg-rust/issues/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]

2024-07-06 Thread via GitHub
liurenjie1024 closed issue #139: refactor: Remove `async_trait` in `Catalog` trait. URL: https://github.com/apache/iceberg-rust/issues/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]

2024-07-06 Thread via GitHub
liurenjie1024 commented on issue #139: URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2211701858 +1, we can close this first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]

2024-06-10 Thread via GitHub
Xuanwo commented on issue #139: URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2158450268 I personally do not favor adopting `async in trait` for the `Catalog` API because it compromises object safety. Users will no longer be able to use `Box`. All APIs related to `Cata

Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]

2024-06-01 Thread via GitHub
liurenjie1024 commented on issue #139: URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2143674376 > Is there any movement on this one? I see there was a prior PR to close, but it was closed pending upstream releases. > > If there's nobody working on it anymore, I w

Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]

2024-06-01 Thread via GitHub
jdockerty commented on issue #139: URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-2143505467 Is there any movement on this one? I see there was a prior PR to close, but it was pending upstream changes. If there's nobody working on it anymore, I would like to take

Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]

2024-01-22 Thread via GitHub
liurenjie1024 commented on issue #139: URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-1905134581 > Could I work on this ? Please tell me what precisely is to be done here? The release of rust 1.75 enables a fancy feature so that we no longer need to use `async_tra

Re: [I] refactor: Remove `async_trait` in `Catalog` trait. [iceberg-rust]

2024-01-22 Thread via GitHub
hiirrxnn commented on issue #139: URL: https://github.com/apache/iceberg-rust/issues/139#issuecomment-1903756750 Could I work on this ? Please tell me what precisely is to be done here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to