Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-12-07 Thread via GitHub
Fokko closed issue #98: feat: Add support for `UnboundPartitionSpec`. URL: https://github.com/apache/iceberg-rust/issues/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-26 Thread via GitHub
liurenjie1024 commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1827058935 > I think I'm still misunderstanding the UnboundPartitionSpec binding process, especially determining the spec_id during committing transaction. I opened a draft pr,please tak

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-25 Thread via GitHub
my-vegetable-has-exploded commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1826494268 I think I'm still misunderstanding the UnboundPartitionSpec binding process, especially determining the spec_id during committing transaction. I opened a draft p

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-20 Thread via GitHub
my-vegetable-has-exploded commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1820337516 > Hi, @my-vegetable-has-exploded I mean I don't want to add `Option` in current `PartitionSpec`, but it's ok to add it in `UnboundPartitonSpec`. get it!, tha

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-20 Thread via GitHub
liurenjie1024 commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1820300963 Hi, @my-vegetable-has-exploded I mean I don't want to add `Option` in current `PartitionSpec`, but it's ok to add it in `UnboundPartitonSpec`. -- This is an automated messag

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-20 Thread via GitHub
my-vegetable-has-exploded commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1819116596 Sorry for my misunderstanding and thanks for your patience @liurenjie1024. Without ```option```, UnboundPartitionSpec and UnboundPartitionField may like this?

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-19 Thread via GitHub
liurenjie1024 commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1818147736 Hi, @my-vegetable-has-exploded Sorry for the confusion. `UnboundPartitionSpec` has two important use cases: 1. In [rest api's definition](https://github.com/apache/iceberg/

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-18 Thread via GitHub
my-vegetable-has-exploded commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1817747650 Sorry, I am confusing about this issue. According to [iceberg#4360](https://github.com/apache/iceberg/pull/4360), I think UnboundPartitionSpec provides a build me

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-16 Thread via GitHub
liurenjie1024 commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1815764353 > I'd like to have a try Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-16 Thread via GitHub
my-vegetable-has-exploded commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1815745708 I'd like to have a try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go