Re: [I] Write `null` for `current-snapshot-id` [iceberg-rust]

2024-12-04 Thread via GitHub
Xuanwo closed issue #752: Write `null` for `current-snapshot-id` URL: https://github.com/apache/iceberg-rust/issues/752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] Write `null` for `current-snapshot-id` [iceberg-rust]

2024-12-04 Thread via GitHub
Fokko commented on issue #752: URL: https://github.com/apache/iceberg-rust/issues/752#issuecomment-2516671564 The [`writer-requirements` sections of the spec](https://iceberg.apache.org/spec/#writer-requirements) clarifies this: ![image](https://github.com/user-attachments/assets/1e6

Re: [I] Write `null` for `current-snapshot-id` [iceberg-rust]

2024-12-04 Thread via GitHub
c-thiel commented on issue #752: URL: https://github.com/apache/iceberg-rust/issues/752#issuecomment-2516657781 @Fokko for this field but also others (properties, snapshots themselves, snapshot_log) should we skip serializing them if they are none or add `null`? -- This is an automated me

[I] Write `null` for `current-snapshot-id` [iceberg-rust]

2024-12-03 Thread via GitHub
Fokko opened a new issue, #752: URL: https://github.com/apache/iceberg-rust/issues/752 Based on the checks in https://github.com/apache/iceberg-rust/pull/742#issuecomment-2515564242, it looks like we write `-1` when there is no snapshot, which is not correct. -- This is an automated mess