Re: [I] Upgrade to gradle 8.3 [iceberg]

2023-10-04 Thread via GitHub
jbonofre commented on issue #8485: URL: https://github.com/apache/iceberg/issues/8485#issuecomment-1746517112 I think the problem is more on gradle or a mix with gradle and revapi gradle plugin. I'm doing a bisect on gradle to identify the change causing the issue. -- This is an

Re: [I] Upgrade to gradle 8.3 [iceberg]

2023-10-04 Thread via GitHub
ajantha-bhat commented on issue #8485: URL: https://github.com/apache/iceberg/issues/8485#issuecomment-1746502923 > With Gradle 8.3, revapi doesn't fail, it doesn't detect the API change. Yes. Thats what we have observed with Gradle 8.2 also. Maybe we need to raise an issue to revA

Re: [I] Upgrade to gradle 8.3 [iceberg]

2023-10-04 Thread via GitHub
jbonofre commented on issue #8485: URL: https://github.com/apache/iceberg/issues/8485#issuecomment-1746467781 FYI, I tested `revapi` with Gradle 8.3 (on my PR). Here's the test I did: * I added `void test();` method in `SessionCatalog` * I added the corresponding `public void test() {}`