Xuanwo closed issue #356: Tracking issues of OpenDAL API changes
URL: https://github.com/apache/iceberg-rust/issues/356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Xuanwo commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2119260654
Closing now. I thought we would have huge breaking API changes, but it
turned out to be a simple, small PR. I'll track the optimization in other
issues instead.
--
This is an au
liurenjie1024 commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2081512923
I think a `FileIO` trait would still be necessary for two reasons:
1. It's more familiar to iceberg community, which makes this easier to
maintain and align with other imp
tustvold commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2081496562
> if FileIO becomes a trait and we can use an existing implementation
I guess I was suggesting to just not have a FileIO trait, and just use
`ObjectStore` which is already
marvinlanhenke commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2081495685
> I'm not seeing a concrete proposal on which to comment, but the broad
theme of moving closer to the actual object store APIs is IMO a good idea.
>
> That being said
tustvold commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2081488506
I'm not seeing a concrete proposal on which to comment, but the broad theme
of moving closer to the actual object store APIs is IMO a good idea.
That being said, I feel I s
liurenjie1024 commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2081483673
> > I agree that we should refactor the Input/Output API for best
performance, but we should be careful not to expose opendal's api to end user.
>
> Yep, I have a plan
Xuanwo commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2081390290
> I agree that we should refactor the Input/Output API for best performance,
but we should be careful not to expose opendal's api to end user.
Yep, I have a plan to refactor
liurenjie1024 commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2081378252
Also cc @tustvold Since we had a related discussion here:
https://github.com/apache/iceberg-rust/issues/172
--
This is an automated message from the Apache Git Service.
T
Xuanwo commented on issue #356:
URL: https://github.com/apache/iceberg-rust/issues/356#issuecomment-2080446957
cc @Fokko @liurenjie1024 @ZENOTME to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Xuanwo opened a new issue, #356:
URL: https://github.com/apache/iceberg-rust/issues/356
Hi, iceberger! OpenDAL's coming v0.46 release will have API changes that
could affect our project.
## Changes
I list the major changes that we need to take care:
### OpenDAL Reader d
11 matches
Mail list logo
