Re: [I] Support commit retrie [iceberg-rust]

2025-04-04 Thread via GitHub
ZENOTME commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2766640791 Sorry for replying late. > I'm a bit confused about this part. First of all should we do a operation match and not have to append requirements if there are only append opera

Re: [I] Support commit retrie [iceberg-rust]

2025-03-29 Thread via GitHub
jonathanc-n commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2764259328 > 2. create UpdateAction and apply them to the metadata > >* When applying, there is the conflict detection process based on the current local metadata load a

Re: [I] Support commit retrie [iceberg-rust]

2025-03-18 Thread via GitHub
ZENOTME commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2735359173 > > 1. We can introduce a new `ErrorKind::RetryableCommitError` to abstract kinds of catalog errors. > > Hi, I believe it should not be an extra kind. Instead, we can add a

Re: [I] Support commit retrie [iceberg-rust]

2025-03-18 Thread via GitHub
ZENOTME commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2735358658 > [@ZENOTME](https://github.com/ZENOTME) Are you currently working on this? I'm looing to make some progress on this Hi @jonathanc-n, for the transaction part, we better wai

Re: [I] Support commit retrie [iceberg-rust]

2025-03-18 Thread via GitHub
Xuanwo commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2735265884 > 1. We can introduce a new `ErrorKind::RetryableCommitError` to abstract kinds of catalog errors. Hi, I believe it should not be an extra kind. Instead, we can add a `retry

Re: [I] Support commit retrie [iceberg-rust]

2025-03-18 Thread via GitHub
jonathanc-n commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2734902487 @ZENOTME Are you currently working on this? I'm looing to make some progress on this -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Support commit retrie [iceberg-rust]

2025-02-13 Thread via GitHub
ZENOTME commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2655980835 > > For now, we only support FastAppend. So we can complete the whole process based on the FastAppend first and complete conflict detection when we introduce other update actions.

Re: [I] Support commit retrie [iceberg-rust]

2025-02-13 Thread via GitHub
liurenjie1024 commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2655890945 > For now, we only support FastAppend. So we can complete the whole process based on the FastAppend first and complete conflict detection when we introduce other update acti

Re: [I] Support commit retrie [iceberg-rust]

2025-02-12 Thread via GitHub
ZENOTME commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2654352762 Hi, I take some time to figure out the whole commit process. The whole commit phase can be described as follows: 1. load current metadata from the catalog 2. create UpdateAc

Re: [I] Support commit retrie [iceberg-rust]

2025-02-12 Thread via GitHub
ZENOTME commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2653585033 > Thanks [@ZENOTME](https://github.com/ZENOTME) for raising this. The core part of commit of conflict detection for different isolation levels, which is quite hard to implement co

Re: [I] Support commit retrie [iceberg-rust]

2025-02-12 Thread via GitHub
liurenjie1024 commented on issue #964: URL: https://github.com/apache/iceberg-rust/issues/964#issuecomment-2653267313 Thanks @ZENOTME for raising this. The core part of commit of conflict detection for different isolation levels, which is quite hard to implement correctly. Retry itself is n

[I] Support commit retrie [iceberg-rust]

2025-02-11 Thread via GitHub
ZENOTME opened a new issue, #964: URL: https://github.com/apache/iceberg-rust/issues/964 I would like to separate this task into multiple steps: 1. [ ] Identify the RetryableCommitError type. We can introduce a new `ErrorKind::RetryableCommitError` to abstract kinds of catalog