Re: [I] Spec disagrees with implementation on field names [iceberg]

2023-10-05 Thread via GitHub
Fokko closed issue #8684: Spec disagrees with implementation on field names URL: https://github.com/apache/iceberg/issues/8684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] Spec disagrees with implementation on field names [iceberg]

2023-10-02 Thread via GitHub
Fokko commented on issue #8684: URL: https://github.com/apache/iceberg/issues/8684#issuecomment-1742738207 @JFinis You're in the right direction. `data_` should be left out. > Do I get the gist of the discussion correctly? If so, do I understand correctly that we all agree that this s

Re: [I] Spec disagrees with implementation on field names [iceberg]

2023-10-02 Thread via GitHub
JFinis commented on issue #8684: URL: https://github.com/apache/iceberg/issues/8684#issuecomment-1742722121 @Fokko What is the intended future of your PR? If I read the discussion in there correctly, then the spec is correct, as the same field is also used to track delete files, so `data_`