Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-08-04 Thread via GitHub
ZENOTME commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2267510308 > Some additional context. Renjie mentioned: > > > Cons: > > It's mixing logging with tracing. If we use tracing for logging, our logging compability will not be compatib

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-08-01 Thread via GitHub
liurenjie1024 commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2264300495 > It sounds like tracing is the preferred option for tracing and logging. I'm happy to raise a PR to add this if we are all in agreement. +1. > I will support

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-07-31 Thread via GitHub
Xuanwo commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2262103009 > It sounds like `tracing` is the preferred option for tracing and logging. I'm happy to raise a PR to add this if we are all in agreement. I'm fine with this. Also cc @liure

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-07-31 Thread via GitHub
sdd commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2261509816 It sounds like `tracing` is the preferred option for tracing and logging. I'm happy to raise a PR to add this if we are all in agreement. Regarding telemetry, does anyone have o

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-07-30 Thread via GitHub
sdd commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2259129551 Some additional context. Renjie mentioned: > Cons: > It's mixing logging with tracing. If we use tracing for logging, our logging compability will not be compatible with logg

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-07-30 Thread via GitHub
Xuanwo commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2257907429 Thank you all for joining the discussion. It seems most people prefer using `tracing` for `trace` and `log`. I'm willing to accept this since it's more important for us to move for

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-07-30 Thread via GitHub
c-thiel commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2257887394 Hey guys, some thoughts from my side: - I don't think performance matters much - we are talking nanoseconds while roundtrips to S3 and catalogs are Milliseconds. Thus, the wider

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-07-29 Thread via GitHub
twuebi commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2255302470 Hi all, I agree with @sdd and suggest to stick with tracing. It is the default choice for logging in async applications and has the most wide-spread adoption. Regardi

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-07-26 Thread via GitHub
Xuanwo commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2253782960 > Adoption of tracing has supplanted that of logging over the past few years. Users who rely on `tracing` can still integrate with our `log`, as tracing has native integratio

Re: [I] Investigation about tracing, logging, and metrics support. [iceberg-rust]

2024-07-26 Thread via GitHub
Xuanwo commented on issue #482: URL: https://github.com/apache/iceberg-rust/issues/482#issuecomment-2252378594 I will suggestion the following set: - logging: [`log`](https://docs.rs/log) - metrics: [`prometheus_client`](https://docs.rs/prometheus-client) - tracing: [`fastrace`](