Re: [I] Do we need to clean the file if close return fail in FileWriter [iceberg-rust]

2024-03-14 Thread via GitHub
ZENOTME closed issue #260: Do we need to clean the file if close return fail in FileWriter URL: https://github.com/apache/iceberg-rust/issues/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Do we need to clean the file if close return fail in FileWriter [iceberg-rust]

2024-03-13 Thread via GitHub
Xuanwo commented on issue #260: URL: https://github.com/apache/iceberg-rust/issues/260#issuecomment-1994292504 > For FileWriter close fail, it may result in a garbage file. I assume that `FileWriter` just about writing a single file. For most object storage services (like s3, gc

[I] Do we need to clean the file if close return fail in FileWriter [iceberg-rust]

2024-03-13 Thread via GitHub
ZENOTME opened a new issue, #260: URL: https://github.com/apache/iceberg-rust/issues/260 For FileWriter close fail, it may result in a garbage file. I look through how java process it, and seems it provided a interface like `abort` so user can call abort if it close fail. But our writer wil