Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2024-06-15 Thread via GitHub
findepi commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-2170594846 follow-up to complete removal of AssertHelpers -- https://github.com/apache/iceberg/pull/10500 > I don't think we want to spend time migrating those agreed! fortunately

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-11-13 Thread via GitHub
nastra commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1807706741 The only modules left are Spark 3.2 + Spark 3.3 ![image](https://github.com/apache/iceberg/assets/271029/869d8ec2-7d9d-4a14-8dd9-3326c64db850) I don't think we want to sp

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-11-13 Thread via GitHub
nastra closed issue #7094: Deprecate usages of AssertHelpers in codebase URL: https://github.com/apache/iceberg/issues/7094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-10-06 Thread via GitHub
gzagarwal commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1750169496 > @gzagarwal you can just search through the codebase and pick up any of them, such as the ones in `iceberg-aws` module I am running existing testcase in iceberg-aws module .

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-10-04 Thread via GitHub
gzagarwal commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1746492707 > @gzagarwal yes the tests should all be working. What issue are you seeing? https://github.com/apache/iceberg/blob/a3aff95f9e60962240b94242e24a778760bdd1d9/CONTRIBUTING.md and htt

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-10-04 Thread via GitHub
nastra commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1746356259 @gzagarwal yes the tests should all be working. What issue are you seeing? https://github.com/apache/iceberg/blob/a3aff95f9e60962240b94242e24a778760bdd1d9/CONTRIBUTING.md and https://

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-10-04 Thread via GitHub
gzagarwal commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1746338892 > okay let me pick, I am working on iceberg-aws Shall i assume current test cases are working? on my local system they are not working so asking this question. Is there a

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-10-03 Thread via GitHub
amshali commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1745987742 Working on flink module... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-10-03 Thread via GitHub
gzagarwal commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1745320059 okay let me pick -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-10-02 Thread via GitHub
nastra commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1742598942 @gzagarwal you can just search through the codebase and pick up any of them, such as the ones in `iceberg-aws` module -- This is an automated message from the Apache Git Service. To