Re: [I] Create table properties does not support boolean value [iceberg-python]

2024-07-13 Thread via GitHub
kevinjqliu commented on issue #895: URL: https://github.com/apache/iceberg-python/issues/895#issuecomment-2227049076 Resolved in #924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Create table properties does not support boolean value [iceberg-python]

2024-07-13 Thread via GitHub
kevinjqliu closed issue #895: Create table properties does not support boolean value URL: https://github.com/apache/iceberg-python/issues/895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Create table properties does not support boolean value [iceberg-python]

2024-07-11 Thread via GitHub
kevinjqliu commented on issue #895: URL: https://github.com/apache/iceberg-python/issues/895#issuecomment-2224326839 Created #919 to track the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Create table properties does not support boolean value [iceberg-python]

2024-07-11 Thread via GitHub
kevinjqliu commented on issue #895: URL: https://github.com/apache/iceberg-python/issues/895#issuecomment-2224093275 Ah, if you pass in `True` (boolean value), this function will turn it into `"True"` https://github.com/kevinjqliu/iceberg-python/blob/428b894aacb107547ba41433b4b6f37e1ad19

Re: [I] Create table properties does not support boolean value [iceberg-python]

2024-07-11 Thread via GitHub
kevinjqliu commented on issue #895: URL: https://github.com/apache/iceberg-python/issues/895#issuecomment-2224091530 > This code also ignores the bloom filter (although passing directly "True" as string). Would it be a case sensitive issue? Likely, can you set it to lowercase and see?

Re: [I] Create table properties does not support boolean value [iceberg-python]

2024-07-10 Thread via GitHub
tlegrave commented on issue #895: URL: https://github.com/apache/iceberg-python/issues/895#issuecomment-175740 Thank you for your reply @syun64. > On a tangent, I see that this property is still [unsupported in PyIceberg for writes](https://github.com/apache/iceberg-python/blob/7

Re: [I] Create table properties does not support boolean value [iceberg-python]

2024-07-10 Thread via GitHub
syun64 commented on issue #895: URL: https://github.com/apache/iceberg-python/issues/895#issuecomment-2221634325 @tlegrave thank you for raising this. From what I can see, this PR introduced the ability to handle cast non-string inputs in the TableProperties dict when setting the Table Prop

Re: [I] Create table properties does not support boolean value [iceberg-python]

2024-07-10 Thread via GitHub
syun64 commented on issue #895: URL: https://github.com/apache/iceberg-python/issues/895#issuecomment-2221542855 I believe the TableProperties are expected to be a dictionary of string key-value pairs. But the silent swallowing of the table property is definitely troublesome. -- This is

[I] Create table properties does not support boolean value [iceberg-python]

2024-07-05 Thread via GitHub
tlegrave opened a new issue, #895: URL: https://github.com/apache/iceberg-python/issues/895 ### Apache Iceberg version main (development) ### Please describe the bug 🐞 Hello there, When creating a table, I can pass properties like bloom filters like so: ```p