Re: [I] Convert row filter to arrow filter [iceberg-rust]

2024-05-14 Thread via GitHub
liurenjie1024 closed issue #265: Convert row filter to arrow filter URL: https://github.com/apache/iceberg-rust/issues/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] Convert row filter to arrow filter [iceberg-rust]

2024-03-21 Thread via GitHub
liurenjie1024 commented on issue #265: URL: https://github.com/apache/iceberg-rust/issues/265#issuecomment-2014127366 I think this depends on the selectivity, and also the implementation. To achieve best performance, the scan reader need to perform vectorized execution to convert filter to

Re: [I] Convert row filter to arrow filter [iceberg-rust]

2024-03-21 Thread via GitHub
a-agmon commented on issue #265: URL: https://github.com/apache/iceberg-rust/issues/265#issuecomment-2013869724 Perhaps I am missing something, but I was running [this simple test](https://gist.github.com/a-agmon/65fe8e6f065404f039937befbbfa401e) on a small parquet file (65MB) and a simple

Re: [I] Convert row filter to arrow filter [iceberg-rust]

2024-03-21 Thread via GitHub
viirya commented on issue #265: URL: https://github.com/apache/iceberg-rust/issues/265#issuecomment-2013554756 Hmm, I wonder if the filtering takes too much time cost on so called common values? Is the predicate filter very complicated? Normally I think filtering on scan can boost performan

Re: [I] Convert row filter to arrow filter [iceberg-rust]

2024-03-21 Thread via GitHub
a-agmon commented on issue #265: URL: https://github.com/apache/iceberg-rust/issues/265#issuecomment-2012751222 Hi @viirya Perhaps a bit off-topic but wondering what you think. I have been testing this a bit, and while I have always seen performance improvements in using `ParquetReco

Re: [I] Convert row filter to arrow filter [iceberg-rust]

2024-03-19 Thread via GitHub
viirya commented on issue #265: URL: https://github.com/apache/iceberg-rust/issues/265#issuecomment-2007930647 I'm looking into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Convert row filter to arrow filter [iceberg-rust]

2024-03-18 Thread via GitHub
Dysprosium0626 commented on issue #265: URL: https://github.com/apache/iceberg-rust/issues/265#issuecomment-2003096263 Hi @liurenjie1024 I could work on this but I have no idea where is the current row filter? I only find something here: https://github.com/apache/iceberg-rust/blob/d6703df40