Re: [I] Allow `file_format` to be lower-case [iceberg-python]

2025-01-27 Thread via GitHub
kevinjqliu commented on issue #1340: URL: https://github.com/apache/iceberg-python/issues/1340#issuecomment-2616585184 Following up on this, #1362 was merged and then reverted, #1518. Ultimately, #1411 resolves this issue, and there's a test to ensure the behavior https://github.com/ap

Re: [I] Allow `file_format` to be lower-case [iceberg-python]

2024-12-09 Thread via GitHub
Fokko commented on issue #1340: URL: https://github.com/apache/iceberg-python/issues/1340#issuecomment-2528127989 Fixed in https://github.com/apache/iceberg-python/pull/1411 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Allow `file_format` to be lower-case [iceberg-python]

2024-12-09 Thread via GitHub
Fokko closed issue #1340: Allow `file_format` to be lower-case URL: https://github.com/apache/iceberg-python/issues/1340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [I] Allow `file_format` to be lower-case [iceberg-python]

2024-12-06 Thread via GitHub
jiakai-li commented on issue #1340: URL: https://github.com/apache/iceberg-python/issues/1340#issuecomment-2524188435 Not sure if I'm still able to work on this or not. But I submitted another PR, rather than modifying `__new__`, I think `_missing_` is a better candidate given its semantic

Re: [I] Allow `file_format` to be lower-case [iceberg-python]

2024-11-22 Thread via GitHub
hgollakota commented on issue #1340: URL: https://github.com/apache/iceberg-python/issues/1340#issuecomment-2493851999 Hey, gonna submit a pull-request - here's the solution I'm proposing: ``` class FileFormat(str, Enum): AVRO = "AVRO", "avro" PARQUET = "PARQUET", "pa

Re: [I] Allow `file_format` to be lower-case [iceberg-python]

2024-11-19 Thread via GitHub
kevinjqliu commented on issue #1340: URL: https://github.com/apache/iceberg-python/issues/1340#issuecomment-2487473814 https://github.com/apache/iceberg-python/blob/93ebd39e3c457dcb86cd053c60d2d13f0713a637/pyiceberg/manifest.py#L95-L102 -- This is an automated message from the Apache Git