liurenjie1024 closed issue #113: Add hive metastore catalog support
URL: https://github.com/apache/iceberg-rust/issues/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
liurenjie1024 commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-2005613132
@marvinlanhenke The pr looks great, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-2002574619
@liurenjie1024
I'm done with the implementation and ready to push the PR.
However, I think it would be great to review #272 first, since it blocked my
implementation
liurenjie1024 commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1993846294
@marvinlanhenke Sure, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1991881914
@liurenjie1024
just a quick update: I've implemented most of the stuff I can do without the
`TableMetadataBuilder`. Also you can assign this issue to me, if you'd like.
liurenjie1024 commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1990044567
@marvinlanhenke Thanks for the work. I'll also try to work on setting up
`TableMetadataBuilder` this week.
--
This is an automated message from the Apache Git Service.
To
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1988201903
> The left parts are blocked by #250
thank you so much for setting up the projects and preparing release 0.3.0 -
I like the structure.
For this issue - I'll tr
liurenjie1024 commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1988048778
The left parts are blocked by #250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
liurenjie1024 commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1987093854
Hi, @marvinlanhenke Thanks for the suggestion, I think creating tracking
issue and clarifying their dependency would be quite helpful, let me create one
for 0.3 release. I'm
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1987088164
> [...] since it has some dependencies, such as transaction api and table
metadata builder, otherwise it's currently not practical.
Makes sense to me.
So I'd leave
liurenjie1024 commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1987025678
Hi, @marvinlanhenke I think currently we can leave `create_table`
unimplemented since it has some dependencies, such as transaction api and table
metadata builder, otherwis
Xuanwo opened a new issue, #113:
URL: https://github.com/apache/iceberg-rust/issues/113
## Tasks
- [x] https://github.com/apache/iceberg-rust/pull/112
- [ ] Implement catalog trait for hms
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
liurenjie1024 closed issue #113: Add hive metastore catalog support
URL: https://github.com/apache/iceberg-rust/issues/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1986952590
@Xuanwo @liurenjie1024
I'm currently looking at the table operations in particular `create_table`
and I'm having some trouble understanding the handling of the metadata.
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1985986494
> In short, submit a PR and then we can polish it together.
Sounds good to me - looking forward to it.
Best regards.
--
This is an automated message from the
Xuanwo commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1985888081
> I 'finished' the work on all the namespace operations.
Awesome!
> I just want to make sure it aligns with the rest of the codebase, before I
put in the effort to imp
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1985760454
@Xuanwo @liurenjie1024
...just a quick update and a request for feedback.
I 'finished' the work on all the namespace operations.
Since this would be my first co
Xuanwo commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1980137973
> I setup the basis test-infra for the hms-catalog. In the next couple of
days I will try to work on / finish the implementation of the catalog.
That's great!
--
This is a
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1980128393
@Xuanwo
Yes, I thought the same - mocking the HMS would not be beneficial.
I setup the basis test-infra for the hms-catalog. In the next couple of days
I will try to
Xuanwo commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1977830450
> I've done a simple prototype with my hive-metastore running locally via
docker-compose, which works just fine. So testing via integration tests seems
to be no problem.
It'
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1977202916
@Xuanwo I've started looking into this (just started yesterday taking a look
at the codebase in general) - how would you go about unit testing the catalog
trait for hms? Th
21 matches
Mail list logo
