Re: [I] Add `@typing.override` to functions [iceberg-python]

2024-11-11 Thread via GitHub
kevinjqliu commented on issue #1310: URL: https://github.com/apache/iceberg-python/issues/1310#issuecomment-2468725040 @cosmastech I dont think we need to do the override. For Python versions less than 3.12, I think this will just be a no-op https://docs.python.org/3/library/typing.html#

Re: [I] Add `@typing.override` to functions [iceberg-python]

2024-11-10 Thread via GitHub
cosmastech commented on issue #1310: URL: https://github.com/apache/iceberg-python/issues/1310#issuecomment-2466949191 Would you recommend something like this: ```py from typing import TYPE_CHECKING if TYPE_CHECKING and sys.version_info >= (3, 12): from typing import