Re: [I] [discuss] `Transaction` API's `autocommit` [iceberg-python]

2025-01-10 Thread via GitHub
kevinjqliu commented on issue #1253: URL: https://github.com/apache/iceberg-python/issues/1253#issuecomment-2584974311 > The reason behind my head is, to my understanding, autocommit is still somewhat a related concept with transaction. I think its fair to ask if we consider `UpdateS

Re: [I] [discuss] `Transaction` API's `autocommit` [iceberg-python]

2025-01-10 Thread via GitHub
jiakai-li commented on issue #1253: URL: https://github.com/apache/iceberg-python/issues/1253#issuecomment-2583876079 Adding an example for the issue: ```python from pyiceberg.catalog.sql import SqlCatalog from pyiceberg.schema import Schema from pyiceberg.types import IntegerTyp

Re: [I] [discuss] `Transaction` API's `autocommit` [iceberg-python]

2025-01-10 Thread via GitHub
jiakai-li commented on issue #1253: URL: https://github.com/apache/iceberg-python/issues/1253#issuecomment-2583844373 Just raise another possibility for discussion. We could also modify the `_transaction._autocommit` when calling `UpdateSchema.__enter__` method, which indicates multiple up

Re: [I] [discuss] `Transaction` API's `autocommit` [iceberg-python]

2024-10-27 Thread via GitHub
kevinjqliu commented on issue #1253: URL: https://github.com/apache/iceberg-python/issues/1253#issuecomment-2440186317 > The idea is to make the code simpler if we only want to evolve schema/spec/... i.e. ``` with table.update_schema() as update: update.add_column("some_fiel

[I] [discuss] `Transaction` API's `autocommit` [iceberg-python]

2024-10-27 Thread via GitHub
kevinjqliu opened a new issue, #1253: URL: https://github.com/apache/iceberg-python/issues/1253 ### Feature Request / Improvement Porting over from #1246 Can be a potential footgun (https://github.com/apache/iceberg-python/pull/1246#issuecomment-2439024843) Autocommit usage