d0mitoridesu opened a new issue, #13550:
URL: https://github.com/apache/iceberg/issues/13550
### Feature Request / Improvement
Hello,
In my current setup, I'm using Strimzi Kafka Connect and Lakekeeper, with
Apache Iceberg for catalog management.
I am currently authentic
dongxiao1198 commented on code in PR #143:
URL: https://github.com/apache/iceberg-cpp/pull/143#discussion_r2203979933
##
src/iceberg/manifest_reader_internal.cc:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor licen
nastra commented on PR #13152:
URL: https://github.com/apache/iceberg/pull/13152#issuecomment-3068039990
> @nastra I have sent multiple times even now ,is their a way. We can review
it here ?
@Bhargavkonidena it's less about the review and more about the actual
discussion, which happ
dongxiao1198 commented on code in PR #143:
URL: https://github.com/apache/iceberg-cpp/pull/143#discussion_r2203968566
##
test/manifest_list_reader_test.cc:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agr
wgtmac commented on code in PR #143:
URL: https://github.com/apache/iceberg-cpp/pull/143#discussion_r2203940400
##
src/iceberg/manifest_reader_internal.cc:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agr
Xuanwo merged PR #140:
URL: https://github.com/apache/iceberg-cpp/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Xuanwo merged PR #139:
URL: https://github.com/apache/iceberg-cpp/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Xuanwo merged PR #112:
URL: https://github.com/apache/iceberg-cpp/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
dongxiao1198 commented on code in PR #143:
URL: https://github.com/apache/iceberg-cpp/pull/143#discussion_r2203935650
##
src/iceberg/manifest_reader_internal.cc:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor licen
dongxiao1198 commented on code in PR #143:
URL: https://github.com/apache/iceberg-cpp/pull/143#discussion_r2203922683
##
src/iceberg/manifest_reader_internal.cc:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor licen
CTTY commented on code in PR #1484:
URL: https://github.com/apache/iceberg-rust/pull/1484#discussion_r2203855133
##
crates/iceberg/src/transaction/mod.rs:
##
@@ -152,13 +159,59 @@ impl Transaction {
}
/// Commit transaction.
-pub async fn commit(mut self, catalog
liurenjie1024 closed issue #1503: Remove `ignore` attribute in `iceberg`
crate's doc.
URL: https://github.com/apache/iceberg-rust/issues/1503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
liurenjie1024 merged PR #1504:
URL: https://github.com/apache/iceberg-rust/pull/1504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
CTTY opened a new issue, #1505:
URL: https://github.com/apache/iceberg-rust/issues/1505
### Is your feature request related to a problem or challenge?
As discussed
[here](https://github.com/apache/iceberg-rust/pull/1484#discussion_r2189596184),
we can add a new module `table_properti
manuzhang commented on code in PR #13491:
URL: https://github.com/apache/iceberg/pull/13491#discussion_r2203848631
##
docs/mkdocs.yml:
##
@@ -22,69 +22,79 @@ plugins:
nav:
- index.md
- - Tables:
-- branching.md
-- configuration.md
-- evolution.md
-- mainte
wgtmac commented on code in PR #127:
URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2203784355
##
test/avro_schema_test.cc:
##
@@ -22,10 +22,15 @@
#include
#include
#include
+#include
Review Comment:
Please revert (unrelated) changes in this file.
manuzhang commented on code in PR #13491:
URL: https://github.com/apache/iceberg/pull/13491#discussion_r2203839408
##
docs/mkdocs.yml:
##
@@ -22,69 +22,79 @@ plugins:
nav:
- index.md
- - Tables:
-- branching.md
-- configuration.md
-- evolution.md
-- mainte
manuzhang commented on code in PR #13491:
URL: https://github.com/apache/iceberg/pull/13491#discussion_r2203837006
##
site/nav.yml:
##
@@ -23,23 +23,24 @@ nav:
- Docs:
- nightly: '!include docs/docs/nightly/mkdocs.yml'
- latest: '!include docs/docs/latest/mkdocs.ym
manuzhang closed pull request #13542: Build: Bump
com.google.errorprone:error_prone_annotations from 2.39.0 to 2.40.0
URL: https://github.com/apache/iceberg/pull/13542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dependabot[bot] commented on PR #13542:
URL: https://github.com/apache/iceberg/pull/13542#issuecomment-3067808011
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, l
wgtmac commented on code in PR #143:
URL: https://github.com/apache/iceberg-cpp/pull/143#discussion_r2203726170
##
src/iceberg/manifest_reader_internal.h:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agree
wgtmac commented on PR #143:
URL: https://github.com/apache/iceberg-cpp/pull/143#issuecomment-3067706152
Could you help review this? @lidavidm @zhjwpku
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
wgtmac commented on code in PR #143:
URL: https://github.com/apache/iceberg-cpp/pull/143#discussion_r2192012781
##
src/iceberg/manifest_reader_internal.cc:
##
@@ -0,0 +1,244 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agr
manuzhang commented on code in PR #13033:
URL: https://github.com/apache/iceberg/pull/13033#discussion_r2203759425
##
.github/workflows/spark-ci.yml:
##
@@ -28,38 +28,26 @@ on:
tags:
- 'apache-iceberg-**'
pull_request:
-paths-ignore:
-- '.github/ISSUE_TEMPLA
liurenjie1024 commented on PR #1504:
URL: https://github.com/apache/iceberg-rust/pull/1504#issuecomment-3067515717
> LGTM!
>
> The previous PR made 3 changes to `rust, ignore`. 2 are captured by this
PR already. The third is
[here](https://github.com/apache/iceberg-rust/pull/1379/fil
davidyuan1223 commented on PR #13539:
URL: https://github.com/apache/iceberg/pull/13539#issuecomment-3067461102
> > Issue: #13538
>
> @davidyuan1223 You can use `Fixes #13538` in the PR description so that we
can close this issue automatically.
https://docs.github.com/en/get-started/
ebyhr commented on PR #13487:
URL: https://github.com/apache/iceberg/pull/13487#issuecomment-3067431619
@stevenzwu @nastra Could you review this PR when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
github-actions[bot] commented on PR #13306:
URL: https://github.com/apache/iceberg/pull/13306#issuecomment-3067425522
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on PR #12228:
URL: https://github.com/apache/iceberg/pull/12228#issuecomment-3067425401
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
tomtongue opened a new pull request, #13549:
URL: https://github.com/apache/iceberg/pull/13549
The part `rewrite_manifests` procedure in Spark currently shows the default
value of `use_caching` is `true`. But this default value was changed in
https://github.com/apache/iceberg/pull/8935. So
ebyhr commented on PR #13539:
URL: https://github.com/apache/iceberg/pull/13539#issuecomment-3067311704
> Issue: #13538
@davidyuan1223 You can use `Fixes #13538` in the PR description so that we
can close this issue automatically.
https://docs.github.com/en/get-started/writing-on
ebyhr commented on PR #13539:
URL: https://github.com/apache/iceberg/pull/13539#issuecomment-3067310630
cc: @hsiang-c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
ebyhr commented on PR #13548:
URL: https://github.com/apache/iceberg/pull/13548#issuecomment-3067309872
#13539 is fixing the same place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
DerGut commented on PR #1496:
URL: https://github.com/apache/iceberg-rust/pull/1496#issuecomment-3067306793
I've created https://github.com/apache/iceberg-go/issues/485 and
https://github.com/apache/iceberg-python/issues/474#issuecomment-3067304005 for
Go and Python respectively.
> R
DerGut commented on issue #474:
URL: https://github.com/apache/iceberg-python/issues/474#issuecomment-3067304005
I'd like to pick this back up because we started a discussion about in
https://github.com/apache/iceberg-rust/issues/1466 too.
On the draft implementation, @sdd raised a go
DerGut opened a new issue, #485:
URL: https://github.com/apache/iceberg-go/issues/485
### Feature Request / Improvement
### Iceberg's Metrics Reporting API
We've started a discussion about the [Metrics
Reporting](https://iceberg.apache.org/docs/latest/metrics-reporting/) API in
ht
hsiang-c opened a new pull request, #13548:
URL: https://github.com/apache/iceberg/pull/13548
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
aihuaxu closed issue #11958: Iceberg Metadata for Variant Shredding
URL: https://github.com/apache/iceberg/issues/11958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
aihuaxu commented on issue #11958:
URL: https://github.com/apache/iceberg/issues/11958#issuecomment-3067265986
This proposal has been implemented. I will close this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
aihuaxu commented on code in PR #13195:
URL: https://github.com/apache/iceberg/pull/13195#discussion_r2203503312
##
api/src/main/java/org/apache/iceberg/expressions/VariantExpressionUtil.java:
##
@@ -111,8 +113,19 @@ static T castTo(VariantValue value, Type type) {
}
jayceslesar commented on issue #2203:
URL:
https://github.com/apache/iceberg-python/issues/2203#issuecomment-3067264705
related/can be rolled into
https://github.com/apache/iceberg-python/issues/269
--
This is an automated message from the Apache Git Service.
To respond to the message, p
jayceslesar commented on PR #2205:
URL: https://github.com/apache/iceberg-python/pull/2205#issuecomment-3067263626
I havent explored this part of iceberg upstream yet (java implementation)
but it seems like we should implement and take advantage of the `commit.retry`
and `commit.status` pro
nandorKollar commented on code in PR #13537:
URL: https://github.com/apache/iceberg/pull/13537#discussion_r2203499329
##
core/src/test/java/org/apache/iceberg/TestScansAndSchemaEvolution.java:
##
@@ -113,4 +116,80 @@ public void testPartitionSourceRename() throws IOException
{
MrDerecho commented on PR #2205:
URL: https://github.com/apache/iceberg-python/pull/2205#issuecomment-3067245177
@ForeverAngry - I looked at this
```python
@retry(
stop=retry_kwargs.get("stop", stop_after_attempt(3)),
wait=retry_kwargs.get("wait", wai
zeroshade merged PR #484:
URL: https://github.com/apache/iceberg-go/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
ForeverAngry commented on issue #2201:
URL:
https://github.com/apache/iceberg-python/issues/2201#issuecomment-3067185093
@jim-ngoo an alternative could be to product the parquet files seprate from
the commit, and then use the `add_files` function to commit them as a single
snapshot.
--
jayceslesar commented on issue #2152:
URL:
https://github.com/apache/iceberg-python/issues/2152#issuecomment-3067178339
I think this is really hard to do without fully materializing the table and
would take a very long time to complete if you are writing a large stream of
record batches.
wgtmac commented on code in PR #112:
URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2203423647
##
src/iceberg/table_scan.cc:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See
ForeverAngry commented on issue #2203:
URL:
https://github.com/apache/iceberg-python/issues/2203#issuecomment-3067047149
@Fokko could you assign me to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
ForeverAngry commented on issue #2142:
URL:
https://github.com/apache/iceberg-python/issues/2142#issuecomment-3067046921
@kevinjqliu or @sungwy could either of you assign me to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
ForeverAngry commented on issue #2150:
URL:
https://github.com/apache/iceberg-python/issues/2150#issuecomment-3067046797
@kevinjqliu or @sungwy could either of you assign me to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
ForeverAngry commented on issue #2142:
URL:
https://github.com/apache/iceberg-python/issues/2142#issuecomment-3067046429
@kevinjqliu or @sungwy could either of you assign me to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
mohsenify closed issue #13547: Incorrect Precedence in Upsert Mode for Records
with Same ID in the Same Commit Interval
URL: https://github.com/apache/iceberg/issues/13547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
mohsenify opened a new issue, #13547:
URL: https://github.com/apache/iceberg/issues/13547
### Apache Iceberg version
1.9.1 (latest release)
### Query engine
Kafka Connect
### Please describe the bug 🐞
When the Apache Iceberg Sink Connector is configured with
sdd commented on PR #1496:
URL: https://github.com/apache/iceberg-rust/pull/1496#issuecomment-3066977032
Sounds good on the metrics naming convention - some cross implementation
standardisation would be great, especially with pyiceberg looking to use
iceberg-rust in the core.
Re the
DerGut commented on PR #1496:
URL: https://github.com/apache/iceberg-rust/pull/1496#issuecomment-3066936928
Thanks a lot for chiming in @sdd! I think using `metrics` and `tracing`
directly instead makes a lot of sense. They are generally about as pluggable as
the reporting interface is and
manuzhang opened a new pull request, #13033:
URL: https://github.com/apache/iceberg/pull/13033
Currently, Spark CI is triggered on exclude path patterns which have several
issues
1. Not all unrelated paths are excluded (e.g. `aws`, `gcp`)
2. When adding a new module to the project, we
dependabot[bot] opened a new pull request, #484:
URL: https://github.com/apache/iceberg-go/pull/484
Bumps the gomod_updates group with 2 updates:
[golang.org/x/sync](https://github.com/golang/sync) and
[google.golang.org/api](https://github.com/googleapis/google-api-go-client).
Updat
xxubai closed pull request #13296: Core: Add manifest writer pool to avoid
commit delays
URL: https://github.com/apache/iceberg/pull/13296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ssandona commented on issue #13526:
URL: https://github.com/apache/iceberg/issues/13526#issuecomment-3066720216
Thanks this is helpful! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
liurenjie1024 opened a new pull request, #1504:
URL: https://github.com/apache/iceberg-rust/pull/1504
## Which issue does this PR close?
- Closes #1503 .
## What changes are included in this PR?
Fix doc and remove unnecessary `ignore` attribute in doc.
## Are thes
liurenjie1024 closed issue #1472: Move `MemoryCatalog` into `iceberg` crate.
URL: https://github.com/apache/iceberg-rust/issues/1472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
liurenjie1024 merged PR #1480:
URL: https://github.com/apache/iceberg-rust/pull/1480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
liurenjie1024 opened a new issue, #1503:
URL: https://github.com/apache/iceberg-rust/issues/1503
### Is your feature request related to a problem or challenge?
See https://github.com/apache/iceberg-rust/pull/1480/files#r2177027195
After #1480 got merged, we should not skip compi
64 matches
Mail list logo
