Re: [I] docs: clarify `check_duplicate_files` option in the `add_files` api docs [iceberg-python]

2025-06-29 Thread via GitHub
Xiezhibin commented on issue #2132: URL: https://github.com/apache/iceberg-python/issues/2132#issuecomment-3018020432 1. I'll check on this, could you assign this task to me? 2. Do we need to annotate the `snapshot_properties` parameter as `Optional` in `iceberg-python/pyiceberg/table/__

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
raulcd commented on PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#issuecomment-3018011425 > We have seen quite a lot timeout from downloading thrift-0.20.0. Should we fix this in the Arrow repo to use more stable URL? @lidavidm @raulcd There is an issue and a WIP PR (so

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
zhjwpku commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2174339367 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType()

Re: [PR] Flink: Backport optimised RowData evolution to Flink 1.19 / 1.20 [iceberg]

2025-06-29 Thread via GitHub
aiborodin commented on PR #13401: URL: https://github.com/apache/iceberg/pull/13401#issuecomment-3017995181 Thank you, @pvary, for merging and @mxm for reviewing the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
zhjwpku commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2174339367 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType()

Re: [PR] Flink 2.0: Replace Caffeine maxSize cache with LRUCache [iceberg]

2025-06-29 Thread via GitHub
aiborodin commented on PR #13382: URL: https://github.com/apache/iceberg/pull/13382#issuecomment-3017985779 I replaced all Caffeine `maximumSize` caches with `LRUCache` in this PR. The only one left is `DynamicWriteResultAggregator`, which uses `expireAfterWrite` semantics: ```java th

Re: [PR] Flink 2.0: Replace Caffeine maxSize cache with LRUCache [iceberg]

2025-06-29 Thread via GitHub
aiborodin commented on code in PR #13382: URL: https://github.com/apache/iceberg/pull/13382#discussion_r2174333027 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java: ## @@ -53,18 +51,18 @@ class TableMetadataCache { private final

Re: [PR] core: Support DV for partition stats [iceberg]

2025-06-29 Thread via GitHub
ajantha-bhat commented on PR #13425: URL: https://github.com/apache/iceberg/pull/13425#issuecomment-3017950385 cc: @aokolnychyi, @stevenzwu, @pvary, @lirui-apache, @deniskuzZ, @RussellSpitzer: Please take a look. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] core: Support DV for partition stats [iceberg]

2025-06-29 Thread via GitHub
ajantha-bhat commented on code in PR #13425: URL: https://github.com/apache/iceberg/pull/13425#discussion_r2174314424 ## core/src/main/java/org/apache/iceberg/PartitionStats.java: ## @@ -22,7 +22,7 @@ public class PartitionStats implements StructLike { - private static fin

Re: [PR] chore: make Transaction cloneable [iceberg-rust]

2025-06-29 Thread via GitHub
liurenjie1024 merged PR #1474: URL: https://github.com/apache/iceberg-rust/pull/1474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Build: Bump datamodel-code-generator from 0.31.1 to 0.31.2 [iceberg]

2025-06-29 Thread via GitHub
Fokko merged PR #13413: URL: https://github.com/apache/iceberg/pull/13413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Bump testcontainers from 1.21.2 to 1.21.3 [iceberg]

2025-06-29 Thread via GitHub
Fokko merged PR #13416: URL: https://github.com/apache/iceberg/pull/13416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Bump com.google.errorprone:error_prone_annotations from 2.38.0 to 2.39.0 [iceberg]

2025-06-29 Thread via GitHub
Fokko merged PR #13423: URL: https://github.com/apache/iceberg/pull/13423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Bump com.palantir.gradle.gitversion:gradle-git-version from 3.3.0 to 3.4.0 [iceberg]

2025-06-29 Thread via GitHub
Fokko merged PR #13422: URL: https://github.com/apache/iceberg/pull/13422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

[I] [Bug] Iceberg tables break when they're named any of the metadata table names (e.g. `files`, `history`, `manifests`) [iceberg]

2025-06-29 Thread via GitHub
joeytman opened a new issue, #10550: URL: https://github.com/apache/iceberg/issues/10550 ### Apache Iceberg version 1.5.2 (latest release) ### Query engine Spark ### Please describe the bug šŸž We have a table in our relational database named `files`. When we

Re: [PR] core: Support DV for partition stats [iceberg]

2025-06-29 Thread via GitHub
ajantha-bhat commented on code in PR #13425: URL: https://github.com/apache/iceberg/pull/13425#discussion_r2174233305 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -367,7 +440,11 @@ private static PartitionMap computeStats( } private static P

Re: [PR] core: Support DV for partition stats [iceberg]

2025-06-29 Thread via GitHub
ajantha-bhat commented on code in PR #13425: URL: https://github.com/apache/iceberg/pull/13425#discussion_r2174230531 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -226,7 +278,12 @@ public static CloseableIterable readPartitionStatsFile( Clos

Re: [PR] core: Support DV for partition stats [iceberg]

2025-06-29 Thread via GitHub
ajantha-bhat commented on code in PR #13425: URL: https://github.com/apache/iceberg/pull/13425#discussion_r2174227056 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -89,11 +89,16 @@ private PartitionStatsHandler() {} NestedField.optional(11, "l

Re: [PR] core: Support DV for partition stats [iceberg]

2025-06-29 Thread via GitHub
ajantha-bhat commented on code in PR #13425: URL: https://github.com/apache/iceberg/pull/13425#discussion_r2174227056 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -89,11 +89,16 @@ private PartitionStatsHandler() {} NestedField.optional(11, "l

Re: [PR] core: Support DV for partition stats [iceberg]

2025-06-29 Thread via GitHub
ajantha-bhat commented on code in PR #13425: URL: https://github.com/apache/iceberg/pull/13425#discussion_r2174226759 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -115,6 +120,53 @@ public static Schema schema(StructType unifiedPartitionType) {

Re: [PR] Core: Use time-travel schema when resolving partition spec in scan [iceberg]

2025-06-29 Thread via GitHub
chenjian2664 commented on code in PR #13301: URL: https://github.com/apache/iceberg/pull/13301#discussion_r2174188811 ## core/src/main/java/org/apache/iceberg/SnapshotScan.java: ## @@ -79,6 +79,22 @@ protected ScanMetrics scanMetrics() { return scanMetrics; } + protec

Re: [I] Support build full-text and vector index for iceberg [iceberg]

2025-06-29 Thread via GitHub
pengzhiwei2018 commented on issue #12636: URL: https://github.com/apache/iceberg/issues/12636#issuecomment-3017606188 @stevenzwu Thanks for you attention on this. here is the share link:https://docs.google.com/document/d/1bMACRCJBB8ycSXCFbP_BdCbFCAegRoxr2O2NXZirOmY/edit?usp=sharing -- Thi

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
gty404 commented on code in PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2174108999 ## src/iceberg/transform_function.cc: ## @@ -48,7 +48,27 @@ Result BucketTransform::Transform(const ArrowArray& input) { } Result> BucketTransform::ResultType() c

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-06-29 Thread via GitHub
gty404 commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2174080643 ## src/iceberg/manifest_reader.h: ## @@ -43,10 +44,27 @@ class ICEBERG_EXPORT ManifestReader { /// \brief Read manifest files from a manifest list file. class ICEBER

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-06-29 Thread via GitHub
gty404 commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2174083403 ## src/iceberg/manifest_reader.h: ## @@ -34,6 +34,7 @@ namespace iceberg { /// \brief Read manifest entries from a manifest file. class ICEBERG_EXPORT ManifestReader

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-06-29 Thread via GitHub
gty404 commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2174097517 ## src/iceberg/table_scan.cc: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] chore: make Transaction cloneable [iceberg-rust]

2025-06-29 Thread via GitHub
dentiny commented on PR #1474: URL: https://github.com/apache/iceberg-rust/pull/1474#issuecomment-3017513079 > Thanks @dentiny for this pr. I'm fine with the changes, but I want to claeify that tx commit is under development, and should happend in `commit` method internally. Yeah I t

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-06-29 Thread via GitHub
lishuxu commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2174084819 ## src/iceberg/table_scan.cc: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

2025-06-29 Thread via GitHub
wgtmac commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2174062567 ## src/iceberg/file_reader.h: ## @@ -29,6 +29,7 @@ #include "iceberg/arrow_c_data.h" #include "iceberg/file_format.h" +#include "iceberg/name_mapping.h" Review Co

Re: [PR] chore: make Transaction cloneable [iceberg-rust]

2025-06-29 Thread via GitHub
liurenjie1024 commented on PR #1474: URL: https://github.com/apache/iceberg-rust/pull/1474#issuecomment-3017504234 > For now, looks like we can't guarantee that the transaction can be retry again directly in semantics.šŸ¤” Why? Do you mean the `commit` method consumed transaction? --

[PR] core: Support DV for partition stats [iceberg]

2025-06-29 Thread via GitHub
ajantha-bhat opened a new pull request, #13425: URL: https://github.com/apache/iceberg/pull/13425 fixes #13180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [I] Support writing Arrow RecordBatchReader or Scanner to Iceberg tables [iceberg-python]

2025-06-29 Thread via GitHub
djouallah commented on issue #2152: URL: https://github.com/apache/iceberg-python/issues/2152#issuecomment-3017482283 honestly it make pyiceberg not usable in any relatively big dataset https://github.com/apache/iceberg-python/issues/1004 -- This is an automated message from the Apache

Re: [PR] feat: avro support applying field-ids based on name mapping [iceberg-cpp]

2025-06-29 Thread via GitHub
MisterRaindrop commented on code in PR #127: URL: https://github.com/apache/iceberg-cpp/pull/127#discussion_r2174050358 ## src/iceberg/avro/avro_reader.cc: ## @@ -195,6 +209,147 @@ class AvroBatchReader::Impl { return arrow_array; } + // Apply field IDs to Avro schema

Re: [I] [DISCUSSION] json_internal Should we implement a minimal unit of code for JSON functionality to avoid mutual dependencies? [iceberg-cpp]

2025-06-29 Thread via GitHub
MisterRaindrop closed issue #128: [DISCUSSION] json_internal Should we implement a minimal unit of code for JSON functionality to avoid mutual dependencies? URL: https://github.com/apache/iceberg-cpp/issues/128 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] AWS: Refactor S3FileIOProperties to use common builder interface [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on PR #13183: URL: https://github.com/apache/iceberg/pull/13183#issuecomment-3017323863 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] Sink-managed consumer group expires after 7 days of no activity in the topic [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on issue #11805: URL: https://github.com/apache/iceberg/issues/11805#issuecomment-3017323680 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Core/REST: generify AuthSessionCache [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on PR #12562: URL: https://github.com/apache/iceberg/pull/12562#issuecomment-3017323742 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] AWS: Support StaticCredentialsProvider in DefaultAwsClientFactory [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on PR #12695: URL: https://github.com/apache/iceberg/pull/12695#issuecomment-3017323790 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: introduce shared authentication refresh executor [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on PR #12563: URL: https://github.com/apache/iceberg/pull/12563#issuecomment-3017323760 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] Sink-managed consumer group expires after 7 days of no activity in the topic [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] closed issue #11805: Sink-managed consumer group expires after 7 days of no activity in the topic URL: https://github.com/apache/iceberg/issues/11805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] correct sequence for running maintenance steps on an iceberg table [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on issue #11804: URL: https://github.com/apache/iceberg/issues/11804#issuecomment-3017323657 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] correct sequence for running maintenance steps on an iceberg table [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] closed issue #11804: correct sequence for running maintenance steps on an iceberg table URL: https://github.com/apache/iceberg/issues/11804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] how to pass where clause predicate to rewrite_data_files which uses year of a timestamp column [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on issue #11789: URL: https://github.com/apache/iceberg/issues/11789#issuecomment-3017323630 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] how to pass where clause predicate to rewrite_data_files which uses year of a timestamp column [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] closed issue #11789: how to pass where clause predicate to rewrite_data_files which uses year of a timestamp column URL: https://github.com/apache/iceberg/issues/11789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] expire-snapshots isn't removing data files after DELETE + expire [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on issue #11695: URL: https://github.com/apache/iceberg/issues/11695#issuecomment-3017323593 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] expire-snapshots isn't removing data files after DELETE + expire [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] closed issue #11695: expire-snapshots isn't removing data files after DELETE + expire URL: https://github.com/apache/iceberg/issues/11695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [Bug] Iceberg tables break when they're named any of the metadata table names (e.g. `files`, `history`, `manifests`) [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on issue #10550: URL: https://github.com/apache/iceberg/issues/10550#issuecomment-3017323540 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] Core: HadoopFileIO to support bulk delete through the Hadoop Filesystem APIs [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] commented on PR #10233: URL: https://github.com/apache/iceberg/pull/10233#issuecomment-3017323480 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [I] [Bug] Iceberg tables break when they're named any of the metadata table names (e.g. `files`, `history`, `manifests`) [iceberg]

2025-06-29 Thread via GitHub
github-actions[bot] closed issue #10550: [Bug] Iceberg tables break when they're named any of the metadata table names (e.g. `files`, `history`, `manifests`) URL: https://github.com/apache/iceberg/issues/10550 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on code in PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#discussion_r2173968530 ## pyiceberg/table/inspect.py: ## @@ -704,3 +731,30 @@ def all_data_files(self) -> "pa.Table": def all_delete_files(self) -> "pa.Table": retu

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on code in PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#discussion_r2173968530 ## pyiceberg/table/inspect.py: ## @@ -704,3 +731,30 @@ def all_data_files(self) -> "pa.Table": def all_delete_files(self) -> "pa.Table": retu

Re: [I] `iceberg-catalog-sql` is not published. [iceberg-rust]

2025-06-29 Thread via GitHub
Xuanwo closed issue #1460: `iceberg-catalog-sql` is not published. URL: https://github.com/apache/iceberg-rust/issues/1460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Allowing publishing iceberg-catalog-sql in workflow. [iceberg-rust]

2025-06-29 Thread via GitHub
Xuanwo merged PR #1473: URL: https://github.com/apache/iceberg-rust/pull/1473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] chore(deps): Bump the arrow-parquet group with 5 updates [iceberg-rust]

2025-06-29 Thread via GitHub
Xuanwo merged PR #1475: URL: https://github.com/apache/iceberg-rust/pull/1475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] chore(deps): Bump volo from 0.10.6 to 0.10.7 [iceberg-rust]

2025-06-29 Thread via GitHub
Xuanwo merged PR #1477: URL: https://github.com/apache/iceberg-rust/pull/1477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] chore(deps): Bump volo-thrift from 0.10.7 to 0.10.8 [iceberg-rust]

2025-06-29 Thread via GitHub
Xuanwo merged PR #1476: URL: https://github.com/apache/iceberg-rust/pull/1476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [I] `iceberg-catalog-sql` is not published. [iceberg-rust]

2025-06-29 Thread via GitHub
Xuanwo commented on issue #1460: URL: https://github.com/apache/iceberg-rust/issues/1460#issuecomment-3016915853 Thank you @JanKaul for this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on code in PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#discussion_r2173826903 ## pyiceberg/table/inspect.py: ## @@ -704,3 +731,30 @@ def all_data_files(self) -> "pa.Table": def all_delete_files(self) -> "pa.Table": retu

Re: [I] Ensure absolute path when referencing any file paths [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on issue #1730: URL: https://github.com/apache/iceberg-python/issues/1730#issuecomment-3016900114 Are there other places we want to check this? The two that come to mind are `add_files` and the example you have above -- This is an automated message from the Apache G

Re: [I] [bug] dependabot is using `Poetry 1.8.5` [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on issue #1702: URL: https://github.com/apache/iceberg-python/issues/1702#issuecomment-3016898005 Looks like this was merged upstream? https://github.com/dependabot/dependabot-core/pull/11642 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] chore: make Transaction cloneable [iceberg-rust]

2025-06-29 Thread via GitHub
ZENOTME commented on PR #1474: URL: https://github.com/apache/iceberg-rust/pull/1474#issuecomment-3016853008 I think the retry commit is implement in the commit internally. For now, looks like we can't guarantee that the transaction can be retry again directly in semantics.šŸ¤” -- This is a

Re: [PR] support all_entries in pyiceberg [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on code in PR #1608: URL: https://github.com/apache/iceberg-python/pull/1608#discussion_r2173826547 ## pyiceberg/table/inspect.py: ## @@ -157,74 +160,98 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> pa.StructType: pa.field(

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-06-29 Thread via GitHub
kevinjqliu commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2173819438 ## pyiceberg/expressions/visitors.py: ## @@ -900,6 +906,24 @@ def visit_bound_predicate(self, predicate: BoundPredicate[L]) -> BooleanExpressi #

Re: [I] [feat] add missing metadata tables [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on issue #1053: URL: https://github.com/apache/iceberg-python/issues/1053#issuecomment-3016825470 [`ALL_DATA_FILES`](https://github.com/apache/iceberg-python/blob/5e975d569e243f1e67e8021a6f941cd77b08d926/pyiceberg/table/inspect.py#L705C9-L705C23), [`ALL_DELETE_FILES`

Re: [PR] Partition statistics metadata reading [iceberg-python]

2025-06-29 Thread via GitHub
kevinjqliu commented on code in PR #2146: URL: https://github.com/apache/iceberg-python/pull/2146#discussion_r2173816667 ## tests/table/test_metadata.py: ## @@ -173,13 +173,13 @@ def test_updating_metadata(example_table_metadata_v2: Dict[str, Any]) -> None: def test_serialize_

Re: [PR] Update schema projection to support `initial-defaults` [iceberg-python]

2025-06-29 Thread via GitHub
kevinjqliu commented on code in PR #1644: URL: https://github.com/apache/iceberg-python/pull/1644#discussion_r2173391227 ## tests/integration/test_reads.py: ## @@ -1024,3 +1025,31 @@ def test_scan_with_datetime(catalog: Catalog) -> None: df = table.scan(row_filter=LessTha

Re: [I] Literals should raise a more friendly error message [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on issue #2160: URL: https://github.com/apache/iceberg-python/issues/2160#issuecomment-3016761060 Nice, yeah looks like we can do something like ```py from typing import Any, Literal from pydantic import BaseModel, Field, field_validator class M

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-06-29 Thread via GitHub
lishuxu commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2173784519 ## src/iceberg/table_scan.h: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-06-29 Thread via GitHub
lishuxu commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2173350649 ## src/iceberg/table_scan.h: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
wgtmac commented on PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#issuecomment-3016740262 cc @gty404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
wgtmac commented on PR #132: URL: https://github.com/apache/iceberg-cpp/pull/132#issuecomment-3016738053 ``` Connection #0 to host www.apache.org left intact Issue another request to this URL: 'https://archive.apache.org/dist/thrift/0.20.0/thrift-0.20.0.tar.gz' tim

Re: [I] [bug] `table.inspect.partitions()` does not respect partition evolution [iceberg-python]

2025-06-29 Thread via GitHub
jayceslesar commented on issue #1120: URL: https://github.com/apache/iceberg-python/issues/1120#issuecomment-3016726263 Maybe I am interpreting this wrong but I did attempt a fix... it comes down to replacing `pa.field("partition", pa_record_struct, nullable=False),` with `pa.field("pa

[PR] chore(deps): Bump volo-thrift from 0.10.7 to 0.10.8 [iceberg-rust]

2025-06-29 Thread via GitHub
dependabot[bot] opened a new pull request, #1476: URL: https://github.com/apache/iceberg-rust/pull/1476 Bumps [volo-thrift](https://github.com/cloudwego/volo) from 0.10.7 to 0.10.8. Commits See full diff in https://github.com/cloudwego/volo/commits";>compare view

[PR] chore(deps): Bump volo from 0.10.6 to 0.10.7 [iceberg-rust]

2025-06-29 Thread via GitHub
dependabot[bot] opened a new pull request, #1477: URL: https://github.com/apache/iceberg-rust/pull/1477 Bumps [volo](https://github.com/cloudwego/volo) from 0.10.6 to 0.10.7. Release notes Sourced from https://github.com/cloudwego/volo/releases";>volo's releases. Volo-Thrift

[PR] chore(deps): Bump the arrow-parquet group with 5 updates [iceberg-rust]

2025-06-29 Thread via GitHub
dependabot[bot] opened a new pull request, #1475: URL: https://github.com/apache/iceberg-rust/pull/1475 Bumps the arrow-parquet group with 5 updates: | Package | From | To | | --- | --- | --- | | [arrow-array](https://github.com/apache/arrow-rs) | `55.1.0` | `55.2.0` | | [arro

Re: [I] Iceberg BatchScan & SparkDistributedDataScan to support `limit` pushdown [iceberg]

2025-06-29 Thread via GitHub
devanshuraj commented on issue #13383: URL: https://github.com/apache/iceberg/issues/13383#issuecomment-3016590881 Hi! I’d like to work on this issue. Has anyone already started on it? If not, I can pick it up and submit a PR. -- This is an automated message from the Apache Git Service. T

Re: [I] (doc): Change error message to reference column that has mismatch [iceberg-python]

2025-06-29 Thread via GitHub
harishkesavarao commented on issue #2017: URL: https://github.com/apache/iceberg-python/issues/2017#issuecomment-3016432801 I am sorry, I was just able to get to this, I will submit a PR shortly. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] build(deps): bump the gomod_updates group with 5 updates [iceberg-go]

2025-06-29 Thread via GitHub
dependabot[bot] opened a new pull request, #473: URL: https://github.com/apache/iceberg-go/pull/473 Bumps the gomod_updates group with 5 updates: | Package | From | To | | --- | --- | --- | | [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) | `1.51.0

Re: [PR] feat: basic table scan planning [iceberg-cpp]

2025-06-29 Thread via GitHub
wgtmac commented on code in PR #112: URL: https://github.com/apache/iceberg-cpp/pull/112#discussion_r2173636857 ## src/iceberg/table_scan.h: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

[PR] feat: implement transform ResultType [iceberg-cpp]

2025-06-29 Thread via GitHub
zhjwpku opened a new pull request, #132: URL: https://github.com/apache/iceberg-cpp/pull/132 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-