Re: [PR] Backport ThreadPools introduce newExitingWorkerPool and newFixedThreadPool to Flink 1.19 and Spark 3.4 [iceberg]

2025-06-09 Thread via GitHub
Guosmilesmile commented on PR #13265: URL: https://github.com/apache/iceberg/pull/13265#issuecomment-2957804198 @pvary This is a clean backport.Sorry for missing the part of the this information. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Backport ThreadPools introduce newExitingWorkerPool and newFixedThreadPool to Flink 1.19 and Spark 3.4 [iceberg]

2025-06-09 Thread via GitHub
pvary commented on PR #13265: URL: https://github.com/apache/iceberg/pull/13265#issuecomment-2957741425 @Guosmilesmile: Is this a clean backport? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
aihuaxu commented on code in PR #13284: URL: https://github.com/apache/iceberg/pull/13284#discussion_r2136977516 ## core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java: ## @@ -114,7 +116,9 @@ public int sizeInBytes() { if (null == buffer) { t

Re: [I] we should publish rc to pypi as part of the release process [iceberg-rust]

2025-06-09 Thread via GitHub
KrishnaSindhur commented on issue #1409: URL: https://github.com/apache/iceberg-rust/issues/1409#issuecomment-2957781205 @liurenjie1024 can I work in this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] fix: incorrect storage descriptor when creating tables in GlueCatalog [iceberg-rust]

2025-06-09 Thread via GitHub
geruh opened a new pull request, #1429: URL: https://github.com/apache/iceberg-rust/pull/1429 ## Which issue does this PR close? Fixes two bugs in the `GlueCatalogs` table creation that caused inconsistency with Iceberg core and PyIceberg implementations: * `StorageDescriptor.Location`

Re: [I] Fix links to API in Flink Configuration doc [iceberg]

2025-06-09 Thread via GitHub
KyleLin0927 commented on issue #13285: URL: https://github.com/apache/iceberg/issues/13285#issuecomment-2957552327 Hi, I can do it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [#13278] : Upgrade junit 5 to 5.13.x [iceberg]

2025-06-09 Thread via GitHub
raveendra11 commented on PR #13280: URL: https://github.com/apache/iceberg/pull/13280#issuecomment-2957621574 Could anyone just run CI again on this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Build: Bump requests from 2.32.3 to 2.32.4 [iceberg-python]

2025-06-09 Thread via GitHub
Fokko merged PR #2078: URL: https://github.com/apache/iceberg-python/pull/2078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Build: Bump huggingface-hub from 0.32.3 to 0.32.4 [iceberg-python]

2025-06-09 Thread via GitHub
Fokko merged PR #2077: URL: https://github.com/apache/iceberg-python/pull/2077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Build: Bump cython from 3.1.1 to 3.1.2 [iceberg-python]

2025-06-09 Thread via GitHub
Fokko merged PR #2081: URL: https://github.com/apache/iceberg-python/pull/2081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] fix: incorrect storage descriptor when creating tables in GlueCatalog [iceberg-rust]

2025-06-09 Thread via GitHub
Xuanwo merged PR #1429: URL: https://github.com/apache/iceberg-rust/pull/1429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Build and test hive-metastore with Hive 2, 3 and 4 with a single source set [iceberg]

2025-06-09 Thread via GitHub
wypoon commented on PR #12721: URL: https://github.com/apache/iceberg/pull/12721#issuecomment-2957634062 > Spark even makes a single binary compatible with Hive 0.12.0-3.1.3. As I understand it, Spark uses a `Shim` class that abstracts the interface between its `HiveClientImpl` and th

Re: [PR] feat(transaction): Add TransactionAction and related classes [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 commented on code in PR #1420: URL: https://github.com/apache/iceberg-rust/pull/1420#discussion_r2136758491 ## crates/iceberg/src/transaction/action.rs: ## @@ -0,0 +1,186 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [I] Fix links to API in Flink Configuration doc [iceberg]

2025-06-09 Thread via GitHub
manuzhang commented on issue #13285: URL: https://github.com/apache/iceberg/issues/13285#issuecomment-2957573719 @KyleLin0927 Thanks, looking forward to your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] feat(transaction): Add TransactionAction and related classes [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 commented on code in PR #1420: URL: https://github.com/apache/iceberg-rust/pull/1420#discussion_r2136759654 ## crates/iceberg/src/transaction/action.rs: ## @@ -0,0 +1,186 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] feat(transaction): Add TransactionAction and related classes [iceberg-rust]

2025-06-09 Thread via GitHub
ZENOTME commented on code in PR #1420: URL: https://github.com/apache/iceberg-rust/pull/1420#discussion_r2136753520 ## crates/iceberg/src/transaction/action.rs: ## @@ -0,0 +1,186 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [I] Use apache/spark image in the quickstart [iceberg]

2025-06-09 Thread via GitHub
github-actions[bot] commented on issue #11746: URL: https://github.com/apache/iceberg/issues/11746#issuecomment-2957349136 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] [PoC] Test Flink and Spark 4.0 using Hive 4 metastore [iceberg]

2025-06-09 Thread via GitHub
pan3793 commented on PR #13262: URL: https://github.com/apache/iceberg/pull/13262#issuecomment-2957573894 @wypoon thanks for your reply and input, I might miss context around this thread. Let me go through the original PR discussion. -- This is an automated message from the Apache Git Ser

Re: [PR] Build and test hive-metastore with Hive 2, 3 and 4 with a single source set [iceberg]

2025-06-09 Thread via GitHub
pan3793 commented on PR #12721: URL: https://github.com/apache/iceberg/pull/12721#issuecomment-2957547716 > The approach we took when we supported Spark 3.0 and 3.1 with a single set of artifacts was also to support runtime compatibility. @wypoon I would say this is a totally differen

Re: [PR] Build and test hive-metastore with Hive 2, 3 and 4 with a single source set [iceberg]

2025-06-09 Thread via GitHub
pan3793 commented on PR #12721: URL: https://github.com/apache/iceberg/pull/12721#issuecomment-2957525887 > it appears that `org.apache.hadoop.hive.serde2.typeinfo.StructTypeInfo.getAllStructFieldNames()` has changed its return type from `java.util.ArrayList` to `java.util.List` in Hive 4.

Re: [I] Extend check-nullability parameter scope to allow writing optional list elements and map values to required elements and values [iceberg]

2025-06-09 Thread via GitHub
joshua-yeung-mox commented on issue #9091: URL: https://github.com/apache/iceberg/issues/9091#issuecomment-2957489061 @Aulust , do you have the solution about this issue? We are also facing the same problem. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Spark: Add 'skip_file_list' option to RewriteTablePathProcedure for optional file-list generation [iceberg]

2025-06-09 Thread via GitHub
slfan1989 commented on code in PR #12844: URL: https://github.com/apache/iceberg/pull/12844#discussion_r2136766160 ## api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java: ## @@ -86,6 +86,16 @@ public interface RewriteTablePath extends Action

Re: [I] Enhance `catalog.create_table` API to enable creation of table with matching `field_ids` to provided Schema [iceberg-python]

2025-06-09 Thread via GitHub
github-actions[bot] commented on issue #1284: URL: https://github.com/apache/iceberg-python/issues/1284#issuecomment-2957353324 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the A

Re: [I] Enhance `catalog.create_table` API to enable creation of table with matching `field_ids` to provided Schema [iceberg-python]

2025-06-09 Thread via GitHub
github-actions[bot] closed issue #1284: Enhance `catalog.create_table` API to enable creation of table with matching `field_ids` to provided Schema URL: https://github.com/apache/iceberg-python/issues/1284 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Rest Catalog: spark catalog api fails to work with rest based catalog [iceberg]

2025-06-09 Thread via GitHub
github-actions[bot] commented on issue #11741: URL: https://github.com/apache/iceberg/issues/11741#issuecomment-2957349105 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] java.io.IOException: can not read class org.apache.iceberg.shaded.org.apache.parquet.format.PageHeader: Required field 'num_values' was not found in serialized data [iceberg]

2025-06-09 Thread via GitHub
github-actions[bot] commented on issue #11614: URL: https://github.com/apache/iceberg/issues/11614#issuecomment-2957349029 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [I] java.io.IOException: can not read class org.apache.iceberg.shaded.org.apache.parquet.format.PageHeader: Required field 'num_values' was not found in serialized data [iceberg]

2025-06-09 Thread via GitHub
github-actions[bot] closed issue #11614: java.io.IOException: can not read class org.apache.iceberg.shaded.org.apache.parquet.format.PageHeader: Required field 'num_values' was not found in serialized data URL: https://github.com/apache/iceberg/issues/11614 -- This is an automated message fr

[PR] Build: Bump pandas from 2.2.3 to 2.3.0 [iceberg-python]

2025-06-09 Thread via GitHub
dependabot[bot] opened a new pull request, #2079: URL: https://github.com/apache/iceberg-python/pull/2079 Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.2.3 to 2.3.0. Release notes Sourced from https://github.com/pandas-dev/pandas/releases";>pandas's releases. P

Re: [PR] Add how to verify release doc [iceberg-rust]

2025-06-09 Thread via GitHub
geruh commented on code in PR #1426: URL: https://github.com/apache/iceberg-rust/pull/1426#discussion_r2136672840 ## website/src/release.md: ## @@ -202,6 +202,35 @@ please cancel the release for the current `release_version`, _increase th RC counting_ and re-initiate a release

[PR] Build: Bump cython from 3.1.1 to 3.1.2 [iceberg-python]

2025-06-09 Thread via GitHub
dependabot[bot] opened a new pull request, #2081: URL: https://github.com/apache/iceberg-python/pull/2081 Bumps [cython](https://github.com/cython/cython) from 3.1.1 to 3.1.2. Changelog Sourced from https://github.com/cython/cython/blob/master/CHANGES.rst";>cython's changelog.

[PR] Build: Bump duckdb from 1.2.2 to 1.3.0 [iceberg-python]

2025-06-09 Thread via GitHub
dependabot[bot] opened a new pull request, #2080: URL: https://github.com/apache/iceberg-python/pull/2080 Bumps [duckdb](https://github.com/duckdb/duckdb) from 1.2.2 to 1.3.0. Release notes Sourced from https://github.com/duckdb/duckdb/releases";>duckdb's releases. DuckDB 1.3

[PR] Build: Bump requests from 2.32.3 to 2.32.4 [iceberg-python]

2025-06-09 Thread via GitHub
dependabot[bot] opened a new pull request, #2078: URL: https://github.com/apache/iceberg-python/pull/2078 Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. Release notes Sourced from https://github.com/psf/requests/releases";>requests's releases. v2.32

[PR] Build: Bump huggingface-hub from 0.32.3 to 0.32.4 [iceberg-python]

2025-06-09 Thread via GitHub
dependabot[bot] opened a new pull request, #2077: URL: https://github.com/apache/iceberg-python/pull/2077 Bumps [huggingface-hub](https://github.com/huggingface/huggingface_hub) from 0.32.3 to 0.32.4. Commits https://github.com/huggingface/huggingface_hub/commit/1589ba210589271

[PR] Build: Bump mkdocstrings-python from 1.16.11 to 1.16.12 [iceberg-python]

2025-06-09 Thread via GitHub
dependabot[bot] opened a new pull request, #2076: URL: https://github.com/apache/iceberg-python/pull/2076 Bumps [mkdocstrings-python](https://github.com/mkdocstrings/python) from 1.16.11 to 1.16.12. Release notes Sourced from https://github.com/mkdocstrings/python/releases";>mkdocs

Re: [I] Implement saving `TableMetadata` to new location. [iceberg-rust]

2025-06-09 Thread via GitHub
DerGut commented on issue #1388: URL: https://github.com/apache/iceberg-rust/issues/1388#issuecomment-2957153016 Other implementations use a metastore catalog that encapsulates some of this shared logic. For example, there is pyiceberg's [`MetastoreCatalog._write_metadata`](https://github.c

Re: [PR] Add BigQuery Dependencies for Iceberg GCP Bundle [iceberg]

2025-06-09 Thread via GitHub
jbonofre commented on code in PR #13111: URL: https://github.com/apache/iceberg/pull/13111#discussion_r2136559179 ## gcp-bundle/LICENSE: ## @@ -214,6 +214,26 @@ License: The Apache Software License, Version 2.0 - https://www.apache.org/licen

Re: [PR] [PoC] Test Flink and Spark 4.0 using Hive 4 metastore [iceberg]

2025-06-09 Thread via GitHub
wypoon commented on PR #13262: URL: https://github.com/apache/iceberg/pull/13262#issuecomment-2956886592 > According to changes in `hive-metastore/src/main`, I suppose the iceberg-hive-metastore.jar compiled by Hive 2.3.10 is also binary compatible with Hive 3.x and 4.x runtime jars?

Re: [PR] Prevent driver from overwhelming during orphan file removal [iceberg]

2025-06-09 Thread via GitHub
karuppayya commented on PR #13084: URL: https://github.com/apache/iceberg/pull/13084#issuecomment-2956798998 > orphanFiles().mapPartitions(DeleteOprhanFilesSparkAction.distributedDeleteFunction).collect https://iceberg.apache.org/docs/latest/spark-procedures/#remove_orphan_files

Re: [PR] Prevent driver from overwhelming during orphan file removal [iceberg]

2025-06-09 Thread via GitHub
RussellSpitzer commented on PR #13084: URL: https://github.com/apache/iceberg/pull/13084#issuecomment-2956675423 I understand the proposed changes but I'm not a big fan of the API and behavior changes required to make it happen within our current framework. It seems like the kind of thing w

Re: [PR] Robustify boto3 session handling (DynamoDB, RestCatalog) [iceberg-python]

2025-06-09 Thread via GitHub
rudolfix commented on PR #2071: URL: https://github.com/apache/iceberg-python/pull/2071#issuecomment-2956651638 thx for working on this :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[I] expose statistics in iceberg-datafusion for fast COUNT() [iceberg-rust]

2025-06-09 Thread via GitHub
debugmiller opened a new issue, #1428: URL: https://github.com/apache/iceberg-rust/issues/1428 ### Is your feature request related to a problem or challenge? Running `SELECT COUNT(1)` when using iceberg-datafusion results in a table scan. This can be avoided by implementing [Executi

Re: [PR] Prevent driver from overwhelming during orphan file removal [iceberg]

2025-06-09 Thread via GitHub
karuppayya commented on PR #13084: URL: https://github.com/apache/iceberg/pull/13084#issuecomment-2956602599 Thanks @RussellSpitzer for the feedback! I agree that exposing the DataFrame of orphan files would be useful that would give users the granular control to perform custom logic on tho

Re: [PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
manirajv06 commented on PR #13284: URL: https://github.com/apache/iceberg/pull/13284#issuecomment-2956371335 @aihuaxu @RussellSpitzer Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] Allow to pass botocore session to REST Catalog (S3 Tables) like Glue Catalog does [iceberg-python]

2025-06-09 Thread via GitHub
rudolfix commented on issue #2008: URL: https://github.com/apache/iceberg-python/issues/2008#issuecomment-2956494970 looks like it is implemented here: https://github.com/apache/iceberg-python/pull/2071 and this exactly what I planned to do! -- This is an automated message from the Apac

Re: [PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
RussellSpitzer commented on code in PR #13284: URL: https://github.com/apache/iceberg/pull/13284#discussion_r2136147209 ## core/src/test/java/org/apache/iceberg/variants/TestPrimitiveWrapper.java: ## @@ -57,7 +59,13 @@ public class TestPrimitiveWrapper { Variants.of(new

Re: [PR] Prevent driver from overwhelming during orphan file removal [iceberg]

2025-06-09 Thread via GitHub
RussellSpitzer commented on PR #13084: URL: https://github.com/apache/iceberg/pull/13084#issuecomment-2956466099 I think I mentioned this before, but I think this would be better served by a new API endpoint rather than modifying the existing code and APIs. ExpireSnapshotsSparkAction

Re: [PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
RussellSpitzer commented on code in PR #13284: URL: https://github.com/apache/iceberg/pull/13284#discussion_r2136152239 ## core/src/test/java/org/apache/iceberg/variants/TestPrimitiveWrapper.java: ## @@ -57,7 +59,13 @@ public class TestPrimitiveWrapper { Variants.of(new

Re: [PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
RussellSpitzer commented on code in PR #13284: URL: https://github.com/apache/iceberg/pull/13284#discussion_r2136133341 ## core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java: ## @@ -114,7 +116,9 @@ public int sizeInBytes() { if (null == buffer) {

Re: [PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
RussellSpitzer commented on code in PR #13284: URL: https://github.com/apache/iceberg/pull/13284#discussion_r2136103646 ## core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java: ## @@ -114,7 +116,9 @@ public int sizeInBytes() { if (null == buffer) {

Re: [PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
manirajv06 closed pull request #13283: Use short string in Variant when possible URL: https://github.com/apache/iceberg/pull/13283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
manirajv06 opened a new pull request, #13284: URL: https://github.com/apache/iceberg/pull/13284 PR for https://github.com/apache/iceberg/issues/13282. Save 4 bytes for short strings stored in Variant by reserving first byte only for header. Regular strings continue to use 1 (header) +

[PR] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
manirajv06 opened a new pull request, #13283: URL: https://github.com/apache/iceberg/pull/13283 PR for https://github.com/apache/iceberg/issues/13282. Save 4 bytes for short strings stored in Variant by reserving first byte only for header. Regular strings continue to use 1 (header) +

[I] Use short string in Variant when possible [iceberg]

2025-06-09 Thread via GitHub
manirajv06 opened a new issue, #13282: URL: https://github.com/apache/iceberg/issues/13282 ### Feature Request / Improvement String stored in Variant always reserve 1 (header) + 4 bytes (offset sizes) for strings of any length. Short strings can be managed with just 1 byte only for h

Re: [PR] Scan Delete Support Part 5: Positional Delete Parsing [iceberg-rust]

2025-06-09 Thread via GitHub
sdd commented on PR #1011: URL: https://github.com/apache/iceberg-rust/pull/1011#issuecomment-2956238416 > Hi, @sdd Would you mind to rebase this pr? Will do, as well as https://github.com/apache/iceberg-rust/pull/1017, either tonight or tomorrow morning. Thanks! -- This is an auto

[PR] Core: Remove redundant check in SizeBasedFileRewritePlanner#enoughInputFiles [iceberg]

2025-06-09 Thread via GitHub
manuzhang opened a new pull request, #13281: URL: https://github.com/apache/iceberg/pull/13281 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Adding new rewrite manifest spark action to accept custom partition order [iceberg]

2025-06-09 Thread via GitHub
zachdisc commented on code in PR #12840: URL: https://github.com/apache/iceberg/pull/12840#discussion_r2135890850 ## api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java: ## @@ -44,6 +45,28 @@ public interface RewriteManifests */ RewriteManifests rewriteIf(P

Re: [PR] Adding new rewrite manifest spark action to accept custom partition order [iceberg]

2025-06-09 Thread via GitHub
RussellSpitzer commented on code in PR #12840: URL: https://github.com/apache/iceberg/pull/12840#discussion_r2135877901 ## api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java: ## @@ -44,6 +45,31 @@ public interface RewriteManifests */ RewriteManifests rewri

Re: [PR] Adding new rewrite manifest spark action to accept custom partition order [iceberg]

2025-06-09 Thread via GitHub
RussellSpitzer commented on code in PR #12840: URL: https://github.com/apache/iceberg/pull/12840#discussion_r2135876054 ## api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java: ## @@ -44,6 +45,28 @@ public interface RewriteManifests */ RewriteManifests rewri

Re: [PR] Adding new rewrite manifest spark action to accept custom partition order [iceberg]

2025-06-09 Thread via GitHub
zachdisc commented on PR #12840: URL: https://github.com/apache/iceberg/pull/12840#issuecomment-2955988581 @RussellSpitzer mind a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] chore(deps): Bump aws-sdk-s3tables from 1.23.0 to 1.25.0 [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 merged PR #1422: URL: https://github.com/apache/iceberg-rust/pull/1422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [#13239]Remove extra \ in Kafka Connect Configuration docs [iceberg]

2025-06-09 Thread via GitHub
raveendra11 commented on PR #13240: URL: https://github.com/apache/iceberg/pull/13240#issuecomment-2955821778 > @raveendra11 It looks you are adding unrelated commits to this PR. Yeah, I have reverted to those commits. -- This is an automated message from the Apache Git Service. To

Re: [I] Nessie: Drop table from Nessie catalog is not cleaning the table files. [iceberg]

2025-06-09 Thread via GitHub
shayantabrizi commented on issue #3528: URL: https://github.com/apache/iceberg/issues/3528#issuecomment-2955654023 Why is that? Shouldn't it actually do the purging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Rename iceberg-cli crate to iceberg-playground [iceberg-rust]

2025-06-09 Thread via GitHub
Xuanwo commented on PR #1427: URL: https://github.com/apache/iceberg-rust/pull/1427#issuecomment-2955534471 Wait @liurenjie1024 for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Feature request: make catalog "features" [iceberg-rust]

2025-06-09 Thread via GitHub
xxchan commented on issue #1289: URL: https://github.com/apache/iceberg-rust/issues/1289#issuecomment-2955471612 catalog are in different crates. Why do we need features? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Prevent driver from overwhelming during orphan file removal [iceberg]

2025-06-09 Thread via GitHub
steveloughran commented on code in PR #13084: URL: https://github.com/apache/iceberg/pull/13084#discussion_r2115891476 ## api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java: ## @@ -142,6 +142,8 @@ default DeleteOrphanFiles equalAuthorities(Map newEqualAuthoriti

[PR] Rename iceberg-cli crate to iceberg-playground [iceberg-rust]

2025-06-09 Thread via GitHub
xxchan opened a new pull request, #1427: URL: https://github.com/apache/iceberg-rust/pull/1427 Signed-off-by: xxchan ## Which issue does this PR close? #1243 - Closes #. ## What changes are included in this PR? ## Are these changes tested?

[PR] [#13278] : Upgrade junit 5 to 5.13.x [iceberg]

2025-06-09 Thread via GitHub
raveendra11 opened a new pull request, #13280: URL: https://github.com/apache/iceberg/pull/13280 [#13278] : Upgrade junit 5 to 5.13.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat(datafusion): support metadata tables for Datafusion [iceberg-rust]

2025-06-09 Thread via GitHub
xxchan commented on PR #879: URL: https://github.com/apache/iceberg-rust/pull/879#issuecomment-2955457685 kindly ping @liurenjie1024 @Xuanwo @Fokko @sdd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat: implement PrimitiveLiteral [iceberg-cpp]

2025-06-09 Thread via GitHub
mapleFU commented on code in PR #117: URL: https://github.com/apache/iceberg-cpp/pull/117#discussion_r2135476185 ## src/iceberg/literal.h: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] feat: implement PrimitiveLiteral [iceberg-cpp]

2025-06-09 Thread via GitHub
yingcai-cy commented on code in PR #117: URL: https://github.com/apache/iceberg-cpp/pull/117#discussion_r2135431953 ## src/iceberg/literal.h: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See

Re: [I] Issue template missing recently missed version. [iceberg-rust]

2025-06-09 Thread via GitHub
Xuanwo closed issue #1414: Issue template missing recently missed version. URL: https://github.com/apache/iceberg-rust/issues/1414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] feat(transaction): Add TransactionAction POC [iceberg-rust]

2025-06-09 Thread via GitHub
Xuanwo commented on code in PR #1400: URL: https://github.com/apache/iceberg-rust/pull/1400#discussion_r2135460063 ## crates/iceberg/src/transaction/mod.rs: ## @@ -167,37 +151,103 @@ impl<'a> Transaction<'a> { } /// Creates replace sort order action. -pub fn repl

Re: [PR] Scan Delete Support Part 5: Positional Delete Parsing [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 commented on PR #1011: URL: https://github.com/apache/iceberg-rust/pull/1011#issuecomment-2955377297 Hi, @sdd Would you mind to rebase this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Add how to verify release doc [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 opened a new pull request, #1426: URL: https://github.com/apache/iceberg-rust/pull/1426 ## Which issue does this PR close? - Closes #1413 . ## What changes are included in this PR? Add doc about how to verify release ## Are these changes tested?

Re: [PR] feat: implement PrimitiveLiteral [iceberg-cpp]

2025-06-09 Thread via GitHub
mapleFU commented on code in PR #117: URL: https://github.com/apache/iceberg-cpp/pull/117#discussion_r2135475768 ## src/iceberg/literal.h: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [PR] chore(deps): Bump aws-sdk-glue from 1.98.0 to 1.99.0 [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 merged PR #1423: URL: https://github.com/apache/iceberg-rust/pull/1423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Scan Delete Support Part 4: Delete File Loading; Skeleton for Processing [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 merged PR #982: URL: https://github.com/apache/iceberg-rust/pull/982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Fix bug reporting project versions [iceberg-rust]

2025-06-09 Thread via GitHub
Xuanwo merged PR #1425: URL: https://github.com/apache/iceberg-rust/pull/1425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

[PR] Fix bug reporting project versions [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 opened a new pull request, #1425: URL: https://github.com/apache/iceberg-rust/pull/1425 ## Which issue does this PR close? - Closes #1414 . ## What changes are included in this PR? Add 0.5.1 ## Are these changes tested? No, trivial -- This i

Re: [PR] chore(deps): Bump crate-ci/typos from 1.32.0 to 1.33.1 [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 merged PR #1424: URL: https://github.com/apache/iceberg-rust/pull/1424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[PR] Core: Enhance logging messages for snapshot expiration [iceberg]

2025-06-09 Thread via GitHub
xxubai opened a new pull request, #13279: URL: https://github.com/apache/iceberg/pull/13279 ![image](https://github.com/user-attachments/assets/ae0146b7-e35d-4e7b-89b6-4f8bf3ee9c13) When Iceberg cleans up snapshots, the output logs do not contain table names, so the information is no

Re: [PR] bug(storage-azdls): Fix inferred WASB endpoint [iceberg-rust]

2025-06-09 Thread via GitHub
Xuanwo merged PR #1417: URL: https://github.com/apache/iceberg-rust/pull/1417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] bug(storage-azdls): Fix inferred WASB endpoint [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 commented on PR #1417: URL: https://github.com/apache/iceberg-rust/pull/1417#issuecomment-2955173347 LGTM. cc @Xuanwo Would you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] fix: fix float compare order [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 merged PR #1416: URL: https://github.com/apache/iceberg-rust/pull/1416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [I] bug: incorrect order for OrderedFloat with iceberg? [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 closed issue #1415: bug: incorrect order for OrderedFloat with iceberg? URL: https://github.com/apache/iceberg-rust/issues/1415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] feat(transaction): Make Transaction own base_table [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 commented on code in PR #1421: URL: https://github.com/apache/iceberg-rust/pull/1421#discussion_r2135346489 ## crates/iceberg/src/transaction/mod.rs: ## @@ -37,18 +37,18 @@ use crate::transaction::sort_order::ReplaceSortOrderAction; use crate::{Catalog, Error, Err

Re: [PR] feat(transaction): Add TransactionAction and related classes [iceberg-rust]

2025-06-09 Thread via GitHub
liurenjie1024 commented on code in PR #1420: URL: https://github.com/apache/iceberg-rust/pull/1420#discussion_r2135340930 ## crates/iceberg/src/transaction/action.rs: ## @@ -0,0 +1,190 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] Hive: update hive storage descriptor after commit schema change [iceberg-python]

2025-06-09 Thread via GitHub
frankliee closed pull request #2036: Hive: update hive storage descriptor after commit schema change URL: https://github.com/apache/iceberg-python/pull/2036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Hive: update hive storage descriptor after commit schema change [iceberg-python]

2025-06-09 Thread via GitHub
frankliee closed pull request #2036: Hive: update hive storage descriptor after commit schema change URL: https://github.com/apache/iceberg-python/pull/2036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Part 1: Support Scan Planning in Rest Client [iceberg]

2025-06-09 Thread via GitHub
singhpk234 commented on code in PR #13004: URL: https://github.com/apache/iceberg/pull/13004#discussion_r2135226197 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -329,7 +341,8 @@ protected T execute( } try { -return mapper.readValu

Re: [PR] Part 1: Support Scan Planning in Rest Client [iceberg]

2025-06-09 Thread via GitHub
singhpk234 commented on code in PR #13004: URL: https://github.com/apache/iceberg/pull/13004#discussion_r2135226197 ## core/src/main/java/org/apache/iceberg/rest/HTTPClient.java: ## @@ -329,7 +341,8 @@ protected T execute( } try { -return mapper.readValu