Re: [PR] feat: SQL Catalog - Tables [iceberg-rust]

2024-09-28 Thread via GitHub
liurenjie1024 commented on code in PR #610: URL: https://github.com/apache/iceberg-rust/pull/610#discussion_r1779838127 ## crates/catalog/sql/src/catalog.rs: ## @@ -472,36 +479,287 @@ impl Catalog for SqlCatalog { } } -async fn drop_namespace(&self, _namespac

Re: [I] discuss: re-export arrow types [iceberg-rust]

2024-09-28 Thread via GitHub
liurenjie1024 commented on issue #636: URL: https://github.com/apache/iceberg-rust/issues/636#issuecomment-2381046786 One case I think this helps is that when another project uses both arrow and iceberg, but with different versions, just as the case in the issue. When you pass them as argum

Re: [I] hive integration iceberg related problems [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on issue #8993: URL: https://github.com/apache/iceberg/issues/8993#issuecomment-2381033381 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: Support batch modifications via copy-on-write [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on PR #8732: URL: https://github.com/apache/iceberg/pull/8732#issuecomment-2381033288 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [I] manifest exception [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on issue #8994: URL: https://github.com/apache/iceberg/issues/8994#issuecomment-2381033384 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] I can't find any detailed explanation about column metric options on the official docs for Iceberg configuration [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on issue #8995: URL: https://github.com/apache/iceberg/issues/8995#issuecomment-2381033390 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Data duplicate after the partition is modified [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on issue #8979: URL: https://github.com/apache/iceberg/issues/8979#issuecomment-2381033361 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] closed pull request #8730: Spec: Clarify spec_id field in Data File URL: https://github.com/apache/iceberg/pull/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Flink: Support batch modifications via copy-on-write [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] closed pull request #8732: Flink: Support batch modifications via copy-on-write URL: https://github.com/apache/iceberg/pull/8732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Doc Bug: Iceberg Flink Example uses unsupported UNIQUE constraint [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on issue #8997: URL: https://github.com/apache/iceberg/issues/8997#issuecomment-2381033394 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Docs: Update site-docs/spark-quickstart.md [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on PR #8991: URL: https://github.com/apache/iceberg/pull/8991#issuecomment-2381033371 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: Allows UnionByName To Insert New Elements in Order [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] closed pull request #8731: Core: Allows UnionByName To Insert New Elements in Order URL: https://github.com/apache/iceberg/pull/8731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Core: Allows UnionByName To Insert New Elements in Order [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on PR #8731: URL: https://github.com/apache/iceberg/pull/8731#issuecomment-2381033278 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Spec: Clarify spec_id field in Data File [iceberg]

2024-09-28 Thread via GitHub
github-actions[bot] commented on PR #8730: URL: https://github.com/apache/iceberg/pull/8730#issuecomment-2381033267 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] feat: Support pushdown more datafusion exprs to Iceberg [iceberg-rust]

2024-09-28 Thread via GitHub
FANNG1 commented on PR #649: URL: https://github.com/apache/iceberg-rust/pull/649#issuecomment-2381031832 @liurenjie1024 @Xuanwo @sdd @a-agmon please help to review when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Materialized View Spec [iceberg]

2024-09-28 Thread via GitHub
bennychow commented on code in PR #11041: URL: https://github.com/apache/iceberg/pull/11041#discussion_r1779799446 ## format/view-spec.md: ## @@ -81,9 +93,12 @@ Each version in `versions` is a struct with the following fields: | _required_ | `representations` | A list of [

Re: [PR] Materialized View Spec [iceberg]

2024-09-28 Thread via GitHub
bennychow commented on code in PR #11041: URL: https://github.com/apache/iceberg/pull/11041#discussion_r1779797796 ## format/view-spec.md: ## @@ -158,6 +173,59 @@ Each entry in `version-log` is a struct with the following fields: | _required_ | `timestamp-ms` | Timestamp when

Re: [I] Spark vectorized read of Parquet produces incorrect result for a decimal column [iceberg]

2024-09-28 Thread via GitHub
wypoon commented on issue #11221: URL: https://github.com/apache/iceberg/issues/11221#issuecomment-238088 cc @bryanck @rdblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1779742090 ## core/src/jmh/java/org/apache/iceberg/ReplaceDeleteFilesBenchmark.java: ## @@ -104,27 +110,44 @@ private void dropTable() { TABLES.dropTable(TABLE_IDE

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1779742090 ## core/src/jmh/java/org/apache/iceberg/ReplaceDeleteFilesBenchmark.java: ## @@ -104,27 +110,44 @@ private void dropTable() { TABLES.dropTable(TABLE_IDE

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1779742090 ## core/src/jmh/java/org/apache/iceberg/ReplaceDeleteFilesBenchmark.java: ## @@ -104,27 +110,44 @@ private void dropTable() { TABLES.dropTable(TABLE_IDE

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1779742090 ## core/src/jmh/java/org/apache/iceberg/ReplaceDeleteFilesBenchmark.java: ## @@ -104,27 +110,44 @@ private void dropTable() { TABLES.dropTable(TABLE_IDE

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1779738033 ## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ## @@ -81,6 +81,7 @@ public String partition() { // cache filtered manifests to avo

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1779738620 ## core/src/jmh/java/org/apache/iceberg/ReplaceDeleteFilesBenchmark.java: ## @@ -104,27 +108,39 @@ private void dropTable() { TABLES.dropTable(TABLE_IDE

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1779739088 ## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ## @@ -325,7 +341,15 @@ private ManifestFile filterManifest(Schema tableSchema, Manifes

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1779738033 ## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ## @@ -81,6 +81,7 @@ public String partition() { // cache filtered manifests to avo

Re: [PR] test (datafusion): add test for table provider creation [iceberg-rust]

2024-09-28 Thread via GitHub
Xuanwo commented on PR #651: URL: https://github.com/apache/iceberg-rust/pull/651#issuecomment-2380512330 Thank you @a-agmon to build this and @FANNG1 for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] test (datafusion): add test for table provider creation [iceberg-rust]

2024-09-28 Thread via GitHub
Xuanwo merged PR #651: URL: https://github.com/apache/iceberg-rust/pull/651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.a