Re: [PR] docs: Refactor the README to be more user-oriented [iceberg-rust]

2024-07-07 Thread via GitHub
Fokko commented on code in PR #444: URL: https://github.com/apache/iceberg-rust/pull/444#discussion_r1668090507 ## README.md: ## @@ -17,89 +17,62 @@ ~ under the License. --> -# Apache Iceberg Rust - -Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org

Re: [PR] docs: Refactor the README to be more user-oriented [iceberg-rust]

2024-07-07 Thread via GitHub
Xuanwo commented on PR #444: URL: https://github.com/apache/iceberg-rust/pull/444#issuecomment-2213162101 > Looks good. I'm not normally as picky about getting the english exactly correct as long as it is understandable, but for the main Readme.md I think we want it perfect :-) Thank

Re: [PR] docs: Refactor the README to be more user-oriented [iceberg-rust]

2024-07-07 Thread via GitHub
sdd commented on code in PR #444: URL: https://github.com/apache/iceberg-rust/pull/444#discussion_r1668065947 ## README.md: ## @@ -17,89 +17,62 @@ ~ under the License. --> -# Apache Iceberg Rust - -Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org/)

Re: [PR] docs: Refactor the README to be more user-oriented [iceberg-rust]

2024-07-07 Thread via GitHub
sdd commented on code in PR #444: URL: https://github.com/apache/iceberg-rust/pull/444#discussion_r1668065324 ## README.md: ## @@ -17,89 +17,62 @@ ~ under the License. --> -# Apache Iceberg Rust - -Native Rust implementation of [Apache Iceberg](https://iceberg.apache.org/)

Re: [PR] Spark Action to Analyze table [iceberg]

2024-07-07 Thread via GitHub
jeesou commented on code in PR #10288: URL: https://github.com/apache/iceberg/pull/10288#discussion_r1668026969 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/AnalyzeTableSparkAction.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundatio

[I] UncheckedSQLException while deleting table [iceberg-python]

2024-07-07 Thread via GitHub
ArijitSinghEDA opened a new issue, #901: URL: https://github.com/apache/iceberg-python/issues/901 ### Question I am running a delete command like this: ``` # catalog is already loaded catalog.drop_table("ns.tbl") ``` I am facing the following error: ``

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-07 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1667693132 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] reuse docker container to save compute resources [iceberg-rust]

2024-07-07 Thread via GitHub
thexiay commented on PR #428: URL: https://github.com/apache/iceberg-rust/pull/428#issuecomment-2212993278 @liurenjie1024 cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Spark: Add read/write support for UUIDs from bytes [iceberg]

2024-07-07 Thread via GitHub
anuragmantri commented on issue #10635: URL: https://github.com/apache/iceberg/issues/10635#issuecomment-2212946143 I can give this a shot @nastra. Although I need to read the UUID PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Encryption via RewriteFiles [iceberg]

2024-07-07 Thread via GitHub
anuragmantri commented on issue #3928: URL: https://github.com/apache/iceberg/issues/3928#issuecomment-2212922691 Hi @ggershinsky - I would like to work on adding encryption to rewrite files operations. If you have not already started on it and intend to delegate, please assign this to me.

Re: [PR] feat: Add macos runner for ci [iceberg-rust]

2024-07-07 Thread via GitHub
QuakeWang commented on PR #441: URL: https://github.com/apache/iceberg-rust/pull/441#issuecomment-2212873077 > > Also it would be better to run check for all oses. > > Hi, @QuakeWang Do you mind to add multi os run for `check` job? > > > > Also it would be better to run

Re: [PR] feat: Add macos runner for ci [iceberg-rust]

2024-07-07 Thread via GitHub
liurenjie1024 commented on PR #441: URL: https://github.com/apache/iceberg-rust/pull/441#issuecomment-2212869957 > > > Also it would be better to run check for all oses. > > > > > > Hi, @QuakeWang Do you mind to add multi os run for `check` job? > > OK, I will do it later. `

Re: [PR] reuse docker container to save compute resources [iceberg-rust]

2024-07-07 Thread via GitHub
liurenjie1024 commented on PR #428: URL: https://github.com/apache/iceberg-rust/pull/428#issuecomment-2212854554 > > cc @thexiay Sorry to ping you. This fix is blocking server other prs, and is relative important for 0.3 release. Do you have time working on it? I can help to pick up if you

Re: [PR] reuse docker container to save compute resources [iceberg-rust]

2024-07-07 Thread via GitHub
thexiay commented on PR #428: URL: https://github.com/apache/iceberg-rust/pull/428#issuecomment-2212843838 > cc @thexiay Sorry to ping you. This fix is blocking server other prs, and is relative important for 0.3 release. Do you have time working on it? I can help to pick up if you are busy

Re: [PR] feat: Add macos runner for ci [iceberg-rust]

2024-07-07 Thread via GitHub
QuakeWang commented on PR #441: URL: https://github.com/apache/iceberg-rust/pull/441#issuecomment-2212816356 > > Also it would be better to run check for all oses. > > Hi, @QuakeWang Do you mind to add multi os run for `check` job? OK, I will do it later. `All OSes`, do you mea

Re: [PR] reuse docker container to save compute resources [iceberg-rust]

2024-07-07 Thread via GitHub
liurenjie1024 commented on PR #428: URL: https://github.com/apache/iceberg-rust/pull/428#issuecomment-2212781921 cc @thexiay Sorry to ping you. This fix is blocking server other prs, and is relative important for 0.3 release. Do you have time working on it? I can help to pick up if you are

Re: [PR] feat: Add macos runner for ci [iceberg-rust]

2024-07-07 Thread via GitHub
liurenjie1024 commented on PR #441: URL: https://github.com/apache/iceberg-rust/pull/441#issuecomment-2212779504 > Also it would be better to run check for all oses. Hi, @QuakeWang Do you mind to add multi os run for `check` job? -- This is an automated message from the Apache Git S

Re: [PR] feat: Add macos runner for ci [iceberg-rust]

2024-07-07 Thread via GitHub
liurenjie1024 commented on PR #441: URL: https://github.com/apache/iceberg-rust/pull/441#issuecomment-2212778817 > @liurenjie1024 Hi, I have restore the `publish.yml` file, PTAL 👀 > > BTW, how to solve this [error](https://github.com/apache/iceberg-rust/actions/runs/9831959370/job/271

Re: [PR] chore(deps): Bump crate-ci/typos from 1.22.9 to 1.23.1 [iceberg-rust]

2024-07-07 Thread via GitHub
liurenjie1024 merged PR #447: URL: https://github.com/apache/iceberg-rust/pull/447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Use SupportsPrefixOperations for Remove OrphanFile Procedure [iceberg]

2024-07-07 Thread via GitHub
rahil-c commented on PR #7914: URL: https://github.com/apache/iceberg/pull/7914#issuecomment-2212775830 @RussellSpitzer @amogh-jahagirdar Wanted to understand what is the actual test needed for this change? I saw this comment ``` We also need a test which exercises this code path, (D

Re: [PR] feat: Add macos runner for ci [iceberg-rust]

2024-07-07 Thread via GitHub
QuakeWang commented on PR #441: URL: https://github.com/apache/iceberg-rust/pull/441#issuecomment-2212750817 @liurenjie1024 Hi, I have restore the `publish.yml` file, PTAL 👀 BTW, how to solve this [error](https://github.com/apache/iceberg-rust/actions/runs/9831959370/job/27140075495?

Re: [PR] Build: Bump kafka from 3.7.0 to 3.7.1 [iceberg]

2024-07-07 Thread via GitHub
Fokko merged PR #10653: URL: https://github.com/apache/iceberg/pull/10653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Build: Bump jetty from 9.4.54.v20240208 to 9.4.55.v20240627 [iceberg]

2024-07-07 Thread via GitHub
Fokko merged PR #10654: URL: https://github.com/apache/iceberg/pull/10654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-07 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1667693132 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-07 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1667693132 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-07 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1667693132 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

[PR] chore(deps): Bump crate-ci/typos from 1.22.9 to 1.23.1 [iceberg-rust]

2024-07-07 Thread via GitHub
dependabot[bot] opened a new pull request, #447: URL: https://github.com/apache/iceberg-rust/pull/447 Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1. Release notes Sourced from https://github.com/crate-ci/typos/releases";>crate-ci/typos's releases.

Re: [PR] Rename data_sequence_number to sequence_number in ManifestEntry [iceberg-python]

2024-07-07 Thread via GitHub
soumya-ghosh commented on code in PR #900: URL: https://github.com/apache/iceberg-python/pull/900#discussion_r1667687714 ## pyiceberg/manifest.py: ## @@ -762,10 +762,10 @@ def add_entry(self, entry: ManifestEntry) -> ManifestWriter: if ( (entry.status ==

Re: [PR] Core, Spark: Fix delete with filter on nested columns [iceberg]

2024-07-07 Thread via GitHub
eshishki commented on PR #7132: URL: https://github.com/apache/iceberg/pull/7132#issuecomment-2212438220 would love to see it merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.26.12 to 2.26.16 [iceberg]

2024-07-07 Thread via GitHub
Fokko merged PR #10650: URL: https://github.com/apache/iceberg/pull/10650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.57.1 [iceberg-go]

2024-07-07 Thread via GitHub
dependabot[bot] commented on PR #105: URL: https://github.com/apache/iceberg-go/pull/105#issuecomment-2212364587 Superseded by #110. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.57.1 [iceberg-go]

2024-07-07 Thread via GitHub
dependabot[bot] closed pull request #105: build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.57.1 URL: https://github.com/apache/iceberg-go/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.48.0 to 1.58.0 [iceberg-go]

2024-07-07 Thread via GitHub
dependabot[bot] opened a new pull request, #110: URL: https://github.com/apache/iceberg-go/pull/110 Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.48.0 to 1.58.0. Commits https://github.com/aws/aws-sdk-go-v2/commit/66f75b6c7fba726f

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to 1.27.23 [iceberg-go]

2024-07-07 Thread via GitHub
dependabot[bot] commented on PR #106: URL: https://github.com/apache/iceberg-go/pull/106#issuecomment-2212364037 Superseded by #109. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to 1.27.23 [iceberg-go]

2024-07-07 Thread via GitHub
dependabot[bot] closed pull request #106: build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to 1.27.23 URL: https://github.com/apache/iceberg-go/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to 1.27.24 [iceberg-go]

2024-07-07 Thread via GitHub
dependabot[bot] opened a new pull request, #109: URL: https://github.com/apache/iceberg-go/pull/109 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.16 to 1.27.24. Commits https://github.com/aws/aws-sdk-go-v2/commit/9005edfbb1194c8f34