Fokko merged PR #9377:
URL: https://github.com/apache/iceberg/pull/9377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
dependabot[bot] opened a new pull request, #9377:
URL: https://github.com/apache/iceberg/pull/9377
Bumps
[datamodel-code-generator](https://github.com/koxudaxi/datamodel-code-generator)
from 0.25.1 to 0.25.2.
Release notes
Sourced from https://github.com/koxudaxi/datamodel-code-ge
dependabot[bot] closed pull request #9318: Build: Bump mkdocs-material from
9.5.1 to 9.5.2
URL: https://github.com/apache/iceberg/pull/9318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dependabot[bot] commented on PR #9318:
URL: https://github.com/apache/iceberg/pull/9318#issuecomment-1868431152
Superseded by #9376.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dependabot[bot] opened a new pull request, #9376:
URL: https://github.com/apache/iceberg/pull/9376
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from
9.5.1 to 9.5.3.
Release notes
Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdocs-ma
dependabot[bot] commented on PR #9314:
URL: https://github.com/apache/iceberg/pull/9314#issuecomment-1868429550
Superseded by #9374.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dependabot[bot] opened a new pull request, #9375:
URL: https://github.com/apache/iceberg/pull/9375
Bumps
[com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson)
from 2.16.0 to 2.16.1.
Commits
See full diff in https://github.com/FasterXML/jackson/
irshadcc commented on PR #9147:
URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1868429638
kind ping @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
dependabot[bot] closed pull request #9314: Build: Bump
software.amazon.awssdk:bom from 2.21.42 to 2.22.0
URL: https://github.com/apache/iceberg/pull/9314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] opened a new pull request, #9374:
URL: https://github.com/apache/iceberg/pull/9374
Bumps software.amazon.awssdk:bom from 2.21.42 to 2.22.5.
[
from 2.23.0 to 2.24.0.
Release notes
Sourced from https://github.com/google/error-prone/r
github-actions[bot] commented on issue #7451:
URL: https://github.com/apache/iceberg/issues/7451#issuecomment-1868395390
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
vinitpatni commented on PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1868356849
- Addressed Review Comments for CatalogTestBase and TestFlinkCatalogDatabase
- Moved parameters method to subclass of CatalogTestBase as there can be
only single parameterProviders w
vinitpatni commented on code in PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435680494
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/CatalogTestBase.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
vinitpatni commented on code in PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435680187
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/CatalogTestBase.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##
@@ -117,47 +119,46 @@ public static Object[][] parameters() {
amogh-jahagirdar commented on PR #129:
URL: https://github.com/apache/iceberg-rust/pull/129#issuecomment-1868328360
Thanks @liurenjie1024 ! Had a few comments/questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
amogh-jahagirdar commented on code in PR #129:
URL: https://github.com/apache/iceberg-rust/pull/129#discussion_r1435638256
##
crates/iceberg/src/spec/schema.rs:
##
@@ -32,16 +32,18 @@ use std::sync::Arc;
use _serde::SchemaEnum;
+/// Type alias for schema id.
+pub type Schem
chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##
@@ -117,47 +119,46 @@ public static Object[][] parameters() {
chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##
@@ -117,47 +119,46 @@ public static Object[][] parameters() {
chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##
@@ -117,47 +119,46 @@ public static Object[][] parameters() {
chinmay-bhat commented on PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868322800
rebased on top of #9368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
mobley-trent commented on issue #95:
URL: https://github.com/apache/iceberg-rust/issues/95#issuecomment-1868299746
Actually I think this is already done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nastra commented on PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868256798
I'll hold off on reviewing this PR once
https://github.com/apache/iceberg/pull/9368 is in. @chinmay-bhat in the
meantime you might want to rebase this PR on top of the commit from
https:/
nastra commented on code in PR #9368:
URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551603
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkStagedScan.java:
##
@@ -39,11 +38,6 @@
public class TestSparkStagedScan extends CatalogTest
nastra commented on code in PR #9368:
URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551324
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWriterV2.java:
##
@@ -50,7 +50,7 @@ public void removeTables() {
sql("DROP TABLE IF E
nastra commented on code in PR #9368:
URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551103
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java:
##
@@ -35,11 +38,25 @@
import org.assertj.core.api.Assertions;
import org.junit.ju
nastra commented on code in PR #9368:
URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435550886
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java:
##
@@ -30,7 +29,7 @@ public abstract class CatalogTestBase extends
TestBaseWithCatalog
nastra commented on code in PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435550532
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/CatalogTestBase.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nastra commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435550396
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##
@@ -118,45 +117,45 @@ public TestRewritePositionDeleteFi
nastra opened a new pull request, #9368:
URL: https://github.com/apache/iceberg/pull/9368
Parameterized base classes should not have a constructor but rather have
their parameters set via `@Parameter`. All other setup code should go into a
`@BeforeEach` method to properly initialize the tes
chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535518
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##
@@ -139,36 +138,43 @@ public void testDryRun() throws IOExc
chinmay-bhat commented on PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868244365
adding `TestCreateActions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535457
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##
@@ -118,45 +117,45 @@ public TestRewritePositionDe
chinmay-bhat commented on code in PR #9367:
URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535260
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##
@@ -94,9 +96,7 @@ public class TestRewritePosition
nastra commented on code in PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524447
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java:
##
@@ -29,259 +32,227 @@
import org.apache.iceberg.catalog.TableIdentifier;
nastra commented on code in PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524541
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java:
##
@@ -29,259 +32,227 @@
import org.apache.iceberg.catalog.TableIdentifier;
nastra commented on code in PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524317
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java:
##
@@ -29,259 +32,227 @@
import org.apache.iceberg.catalog.TableIdentifier;
nastra commented on code in PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524104
##
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java:
##
@@ -29,259 +32,227 @@
import org.apache.iceberg.catalog.TableIdentifier;
aokolnychyi commented on PR #9365:
URL: https://github.com/apache/iceberg/pull/9365#issuecomment-1868235356
@rdblue @szehon-ho @nastra @Fokko @amogh-jahagirdar @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
46 matches
Mail list logo