Re: [PR] Build: Bump datamodel-code-generator from 0.25.1 to 0.25.2 [iceberg]

2023-12-23 Thread via GitHub
Fokko merged PR #9377: URL: https://github.com/apache/iceberg/pull/9377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[PR] Build: Bump datamodel-code-generator from 0.25.1 to 0.25.2 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9377: URL: https://github.com/apache/iceberg/pull/9377 Bumps [datamodel-code-generator](https://github.com/koxudaxi/datamodel-code-generator) from 0.25.1 to 0.25.2. Release notes Sourced from https://github.com/koxudaxi/datamodel-code-ge

Re: [PR] Build: Bump mkdocs-material from 9.5.1 to 9.5.2 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] closed pull request #9318: Build: Bump mkdocs-material from 9.5.1 to 9.5.2 URL: https://github.com/apache/iceberg/pull/9318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Build: Bump mkdocs-material from 9.5.1 to 9.5.2 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] commented on PR #9318: URL: https://github.com/apache/iceberg/pull/9318#issuecomment-1868431152 Superseded by #9376. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Build: Bump mkdocs-material from 9.5.1 to 9.5.3 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9376: URL: https://github.com/apache/iceberg/pull/9376 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.1 to 9.5.3. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdocs-ma

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.0 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] commented on PR #9314: URL: https://github.com/apache/iceberg/pull/9314#issuecomment-1868429550 Superseded by #9374. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Build: Bump com.fasterxml.jackson.core:jackson-annotations from 2.16.0 to 2.16.1 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9375: URL: https://github.com/apache/iceberg/pull/9375 Bumps [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson) from 2.16.0 to 2.16.1. Commits See full diff in https://github.com/FasterXML/jackson/

Re: [PR] Core: Optimize manifest evaluation for super wide tables [iceberg]

2023-12-23 Thread via GitHub
irshadcc commented on PR #9147: URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1868429638 kind ping @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.0 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] closed pull request #9314: Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.0 URL: https://github.com/apache/iceberg/pull/9314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Build: Bump software.amazon.awssdk:bom from 2.21.42 to 2.22.5 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9374: URL: https://github.com/apache/iceberg/pull/9374 Bumps software.amazon.awssdk:bom from 2.21.42 to 2.22.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwar

[PR] Build: Bump guava from 32.1.3-jre to 33.0.0-jre [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9373: URL: https://github.com/apache/iceberg/pull/9373 Bumps `guava` from 32.1.3-jre to 33.0.0-jre. Updates `com.google.guava:guava` from 32.1.3-jre to 33.0.0-jre Release notes Sourced from https://github.com/google/guava/releases";>com

[PR] Build: Bump arrow from 14.0.1 to 14.0.2 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9372: URL: https://github.com/apache/iceberg/pull/9372 Bumps `arrow` from 14.0.1 to 14.0.2. Updates `org.apache.arrow:arrow-memory-netty` from 14.0.1 to 14.0.2 Updates `org.apache.arrow:arrow-vector` from 14.0.1 to 14.0.2 Commits

Re: [PR] Build: Bump spring-boot from 2.5.4 to 3.2.0 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] commented on PR #9152: URL: https://github.com/apache/iceberg/pull/9152#issuecomment-1868429518 Superseded by #9371. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Build: Bump spring-boot from 2.5.4 to 3.2.0 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] closed pull request #9152: Build: Bump spring-boot from 2.5.4 to 3.2.0 URL: https://github.com/apache/iceberg/pull/9152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Build: Bump spring-boot from 2.5.4 to 3.2.1 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9371: URL: https://github.com/apache/iceberg/pull/9371 Bumps `spring-boot` from 2.5.4 to 3.2.1. Updates `org.springframework.boot:spring-boot-starter-jetty` from 2.5.4 to 3.2.1 Release notes Sourced from https://github.com/spring-proje

[PR] Build: Bump jetty from 9.4.53.v20231009 to 11.0.19 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9370: URL: https://github.com/apache/iceberg/pull/9370 Bumps `jetty` from 9.4.53.v20231009 to 11.0.19. Updates `org.eclipse.jetty:jetty-server` from 9.4.53.v20231009 to 11.0.19 Release notes Sourced from https://github.com/jetty/jetty.p

[PR] Build: Bump com.google.errorprone:error_prone_annotations from 2.23.0 to 2.24.0 [iceberg]

2023-12-23 Thread via GitHub
dependabot[bot] opened a new pull request, #9369: URL: https://github.com/apache/iceberg/pull/9369 Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.23.0 to 2.24.0. Release notes Sourced from https://github.com/google/error-prone/r

Re: [I] Python: Implement Name Mapping to construct iceberg schema when field ids are not present in Data files [iceberg]

2023-12-23 Thread via GitHub
github-actions[bot] commented on issue #7451: URL: https://github.com/apache/iceberg/issues/7451#issuecomment-1868395390 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-23 Thread via GitHub
vinitpatni commented on PR #9364: URL: https://github.com/apache/iceberg/pull/9364#issuecomment-1868356849 - Addressed Review Comments for CatalogTestBase and TestFlinkCatalogDatabase - Moved parameters method to subclass of CatalogTestBase as there can be only single parameterProviders w

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-23 Thread via GitHub
vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435680494 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/CatalogTestBase.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Flink: Create CatalogTestBase for migration to JUnit5 [iceberg]

2023-12-23 Thread via GitHub
vinitpatni commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435680187 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/CatalogTestBase.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] feat: Introduce basic file scan planning. [iceberg-rust]

2023-12-23 Thread via GitHub
amogh-jahagirdar commented on PR #129: URL: https://github.com/apache/iceberg-rust/pull/129#issuecomment-1868328360 Thanks @liurenjie1024 ! Had a few comments/questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] feat: Introduce basic file scan planning. [iceberg-rust]

2023-12-23 Thread via GitHub
amogh-jahagirdar commented on code in PR #129: URL: https://github.com/apache/iceberg-rust/pull/129#discussion_r1435638256 ## crates/iceberg/src/spec/schema.rs: ## @@ -32,16 +32,18 @@ use std::sync::Arc; use _serde::SchemaEnum; +/// Type alias for schema id. +pub type Schem

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435642435 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ## @@ -117,47 +119,46 @@ public static Object[][] parameters() {

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868322800 rebased on top of #9368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] refactor: Remove `datatype()` method in `Literal`. [iceberg-rust]

2023-12-23 Thread via GitHub
mobley-trent commented on issue #95: URL: https://github.com/apache/iceberg-rust/issues/95#issuecomment-1868299746 Actually I think this is already done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
nastra commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868256798 I'll hold off on reviewing this PR once https://github.com/apache/iceberg/pull/9368 is in. @chinmay-bhat in the meantime you might want to rebase this PR on top of the commit from https:/

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9368: URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551603 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkStagedScan.java: ## @@ -39,11 +38,6 @@ public class TestSparkStagedScan extends CatalogTest

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9368: URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551324 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWriterV2.java: ## @@ -50,7 +50,7 @@ public void removeTables() { sql("DROP TABLE IF E

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9368: URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435551103 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java: ## @@ -35,11 +38,25 @@ import org.assertj.core.api.Assertions; import org.junit.ju

Re: [PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9368: URL: https://github.com/apache/iceberg/pull/9368#discussion_r1435550886 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java: ## @@ -30,7 +29,7 @@ public abstract class CatalogTestBase extends TestBaseWithCatalog

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435550532 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/CatalogTestBase.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435550396 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -118,45 +117,45 @@ public TestRewritePositionDeleteFi

[PR] Spark 3.5: Remove constructor from parameterized base class [iceberg]

2023-12-23 Thread via GitHub
nastra opened a new pull request, #9368: URL: https://github.com/apache/iceberg/pull/9368 Parameterized base classes should not have a constructor but rather have their parameters set via `@Parameter`. All other setup code should go into a `@BeforeEach` method to properly initialize the tes

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535518 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java: ## @@ -139,36 +138,43 @@ public void testDryRun() throws IOExc

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on PR #9367: URL: https://github.com/apache/iceberg/pull/9367#issuecomment-1868244365 adding `TestCreateActions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535457 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -118,45 +117,45 @@ public TestRewritePositionDe

Re: [PR] Spark 3.5: Migrate tests to JUnit5 in actions directory [iceberg]

2023-12-23 Thread via GitHub
chinmay-bhat commented on code in PR #9367: URL: https://github.com/apache/iceberg/pull/9367#discussion_r1435535260 ## spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java: ## @@ -94,9 +96,7 @@ public class TestRewritePosition

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524447 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,227 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524541 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,227 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524317 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,227 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Create FlinkCatalogTestBaseJU5 for migration to JUnit5 [iceberg]

2023-12-23 Thread via GitHub
nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435524104 ## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogDatabase.java: ## @@ -29,259 +32,227 @@ import org.apache.iceberg.catalog.TableIdentifier;

Re: [PR] Core: Use CharSequenceMap for writing unordered deletes [iceberg]

2023-12-23 Thread via GitHub
aokolnychyi commented on PR #9365: URL: https://github.com/apache/iceberg/pull/9365#issuecomment-1868235356 @rdblue @szehon-ho @nastra @Fokko @amogh-jahagirdar @RussellSpitzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an