Re: [PR] Flink missing backports [iceberg]

2023-11-26 Thread via GitHub
pvary commented on PR #9144: URL: https://github.com/apache/iceberg/pull/9144#issuecomment-1827315584 Thanks @stevenzwu for the merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Expose PyIceberg table as PyArrow Dataset [iceberg-python]

2023-11-26 Thread via GitHub
RahulDubey391 commented on issue #30: URL: https://github.com/apache/iceberg-python/issues/30#issuecomment-1827142768 Hi @Fokko , I can have a look into the issue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] feat: support UnboundPartitionSpec [iceberg-rust]

2023-11-26 Thread via GitHub
liurenjie1024 commented on code in PR #106: URL: https://github.com/apache/iceberg-rust/pull/106#discussion_r1405573783 ## crates/iceberg/src/error.rs: ## @@ -33,6 +33,8 @@ pub enum ErrorKind { /// service error. Unexpected, +/// Iceberg finds some conflict when

Re: [I] feat: Add support for `UnboundPartitionSpec`. [iceberg-rust]

2023-11-26 Thread via GitHub
liurenjie1024 commented on issue #98: URL: https://github.com/apache/iceberg-rust/issues/98#issuecomment-1827058935 > I think I'm still misunderstanding the UnboundPartitionSpec binding process, especially determining the spec_id during committing transaction. I opened a draft pr,please tak

Re: [PR] chore(deps): Update uuid requirement from ~1.5.0 to ~1.6.1 [iceberg-rust]

2023-11-26 Thread via GitHub
liurenjie1024 closed pull request #107: chore(deps): Update uuid requirement from ~1.5.0 to ~1.6.1 URL: https://github.com/apache/iceberg-rust/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] chore(deps): Update uuid requirement from ~1.5.0 to ~1.6.1 [iceberg-rust]

2023-11-26 Thread via GitHub
liurenjie1024 commented on PR #107: URL: https://github.com/apache/iceberg-rust/pull/107#issuecomment-1827057209 This dependabot didn't remove `~` prefix, I'll close this pr and upgrade it by hand. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] chore(deps): Update uuid requirement from ~1.5.0 to ~1.6.1 [iceberg-rust]

2023-11-26 Thread via GitHub
dependabot[bot] commented on PR #107: URL: https://github.com/apache/iceberg-rust/pull/107#issuecomment-1827057231 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

Re: [PR] refactor: Removing type infromation in `Struct` literal. [iceberg-rust]

2023-11-26 Thread via GitHub
liurenjie1024 commented on code in PR #103: URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1405571325 ## crates/iceberg/src/spec/values.rs: ## @@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue { PrimitiveLiteral::Decimal(_) => todo!(),

Re: [I] Question about "Column ID" in Parquet Sepc [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on issue #9099: URL: https://github.com/apache/iceberg/issues/9099#issuecomment-1827021236 I can make a PR to clarify -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405548802 ## format/spec.md: ## @@ -305,6 +305,13 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transfor

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405548509 ## format/spec.md: ## @@ -305,6 +305,10 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transfor

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405547938 ## format/spec.md: ## @@ -305,6 +305,13 @@ The source column, selected by id, must be a primitive type and cannot be contai Partition specs capture the transfor

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405545902 ## format/spec.md: ## @@ -607,6 +614,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows

Re: [PR] Spec: Clarify partition equality [iceberg]

2023-11-26 Thread via GitHub
emkornfield commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1405545902 ## format/spec.md: ## @@ -607,6 +614,8 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows

Re: [PR] feat: Implement create table and update table api for rest catalog. [iceberg-rust]

2023-11-26 Thread via GitHub
liurenjie1024 commented on code in PR #97: URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1405543566 ## crates/catalog/rest/src/catalog.rs: ## @@ -1017,31 +1109,31 @@ mod tests { .with_summary(Summary { operation: Operation::Append,

Re: [PR] feat: Implement create table and update table api for rest catalog. [iceberg-rust]

2023-11-26 Thread via GitHub
liurenjie1024 commented on code in PR #97: URL: https://github.com/apache/iceberg-rust/pull/97#discussion_r1405543566 ## crates/catalog/rest/src/catalog.rs: ## @@ -1017,31 +1109,31 @@ mod tests { .with_summary(Summary { operation: Operation::Append,

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

2023-11-26 Thread via GitHub
ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1405536815 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -378,27 +403,71 @@ public void renameTable(TableIdentifier from, TableIdentifier

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

2023-11-26 Thread via GitHub
ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1405528927 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -165,4 +180,95 @@ public static TableMetadata updateTableMetadataWithNessieSpecificProper

Re: [I] Delete across all snapshots [iceberg]

2023-11-26 Thread via GitHub
github-actions[bot] closed issue #7622: Delete across all snapshots URL: https://github.com/apache/iceberg/issues/7622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] Quickstart should give an example of a REST catalog enablement in the spark iceberg docker compose setup [iceberg]

2023-11-26 Thread via GitHub
github-actions[bot] commented on issue #7615: URL: https://github.com/apache/iceberg/issues/7615#issuecomment-1826951552 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Delete across all snapshots [iceberg]

2023-11-26 Thread via GitHub
github-actions[bot] commented on issue #7622: URL: https://github.com/apache/iceberg/issues/7622#issuecomment-1826951542 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Arrow reader fails to filter results [iceberg]

2023-11-26 Thread via GitHub
github-actions[bot] closed issue #7556: Arrow reader fails to filter results URL: https://github.com/apache/iceberg/issues/7556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Arrow reader fails to filter results [iceberg]

2023-11-26 Thread via GitHub
github-actions[bot] commented on issue #7556: URL: https://github.com/apache/iceberg/issues/7556#issuecomment-1826951581 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Parquet : spark config "spark.sql.parquet.writeLegacyFormat = true " is useless [iceberg]

2023-11-26 Thread via GitHub
github-actions[bot] commented on issue #7706: URL: https://github.com/apache/iceberg/issues/7706#issuecomment-1826951508 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] A good Example to leverage glue(Aws integration with spark) is missing right now [iceberg]

2023-11-26 Thread via GitHub
github-actions[bot] commented on issue #7735: URL: https://github.com/apache/iceberg/issues/7735#issuecomment-1826951487 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Replace black by Ruff Formatter [iceberg-python]

2023-11-26 Thread via GitHub
hussein-awala commented on code in PR #127: URL: https://github.com/apache/iceberg-python/pull/127#discussion_r1405455829 ## .pre-commit-config.yaml: ## @@ -29,15 +29,11 @@ repos: - id: check-ast - repo: https://github.com/astral-sh/ruff-pre-commit # Ruff version

Re: [PR] Replace black by Ruff Formatter [iceberg-python]

2023-11-26 Thread via GitHub
hussein-awala commented on PR #127: URL: https://github.com/apache/iceberg-python/pull/127#issuecomment-1826859402 > Looks fine overall, but it seems like too many changes with string normalization. Why force string normalization? That's going to cause a ton of pull requests to fail formatt

Re: [I] inputFormat, outputFormat, and serialization.lib not being set with AWS Glue 4.0 and Iceberg while Create table [iceberg]

2023-11-26 Thread via GitHub
yakovsushenok commented on issue #6783: URL: https://github.com/apache/iceberg/issues/6783#issuecomment-1826790765 I used iceberg table format v2 and when I was querying with Athena engine 2, I was getting HIVE_METASTORE_ERROR: Table storage descriptor is missing SerDe info. When I changed

Re: [I] HIVE_METASTORE_ERROR: Table storage descriptor is missing SerDe info - when query a view using an Iceberg table on Athena [iceberg]

2023-11-26 Thread via GitHub
yakovsushenok commented on issue #4549: URL: https://github.com/apache/iceberg/issues/4549#issuecomment-1826790324 I used iceberg table format v2 and when I was querying with Athena engine 2, I was getting this error. When I changed to Athena engine 3 this error went away. -- This is an

[PR] chore(deps): Update uuid requirement from ~1.5.0 to ~1.6.1 [iceberg-rust]

2023-11-26 Thread via GitHub
dependabot[bot] opened a new pull request, #107: URL: https://github.com/apache/iceberg-rust/pull/107 Updates the requirements on [uuid](https://github.com/uuid-rs/uuid) to permit the latest version. Release notes Sourced from https://github.com/uuid-rs/uuid/releases";>uuid's relea

Re: [PR] Flink: Read parquet BINARY column as String for expected [iceberg]

2023-11-26 Thread via GitHub
fengjiajie commented on PR #8808: URL: https://github.com/apache/iceberg/pull/8808#issuecomment-1826731977 > You can only guarantee this is safe for your data, for any other user this could be unsafe. That’s the underlying issue with this PR, we are essentially allowing a cast binary as str

Re: [PR] build(deps): bump github.com/wolfeidau/s3iofs from 1.3.0 to 1.3.1 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] closed pull request #31: build(deps): bump github.com/wolfeidau/s3iofs from 1.3.0 to 1.3.1 URL: https://github.com/apache/iceberg-go/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] build(deps): bump github.com/wolfeidau/s3iofs from 1.3.0 to 1.4.0 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] opened a new pull request, #41: URL: https://github.com/apache/iceberg-go/pull/41 Bumps [github.com/wolfeidau/s3iofs](https://github.com/wolfeidau/s3iofs) from 1.3.0 to 1.4.0. Release notes Sourced from https://github.com/wolfeidau/s3iofs/releases";>github.com/wolfe

Re: [PR] build(deps): bump github.com/wolfeidau/s3iofs from 1.3.0 to 1.3.1 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] commented on PR #31: URL: https://github.com/apache/iceberg-go/pull/31#issuecomment-1826720860 Superseded by #41. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.25.3 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] closed pull request #38: build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.25.3 URL: https://github.com/apache/iceberg-go/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.25.3 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] commented on PR #38: URL: https://github.com/apache/iceberg-go/pull/38#issuecomment-1826720682 Superseded by #40. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.25.5 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] opened a new pull request, #40: URL: https://github.com/apache/iceberg-go/pull/40 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.19.1 to 1.25.5. Commits https://github.com/aws/aws-sdk-go-v2/commit/fa3ee1a83b9edac9669159

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2 from 1.21.2 to 1.23.0 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] commented on PR #36: URL: https://github.com/apache/iceberg-go/pull/36#issuecomment-1826720525 Superseded by #39. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] build(deps): bump github.com/aws/aws-sdk-go-v2 from 1.21.2 to 1.23.0 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] closed pull request #36: build(deps): bump github.com/aws/aws-sdk-go-v2 from 1.21.2 to 1.23.0 URL: https://github.com/apache/iceberg-go/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] build(deps): bump github.com/aws/aws-sdk-go-v2 from 1.21.2 to 1.23.1 [iceberg-go]

2023-11-26 Thread via GitHub
dependabot[bot] opened a new pull request, #39: URL: https://github.com/apache/iceberg-go/pull/39 Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.21.2 to 1.23.1. Commits https://github.com/aws/aws-sdk-go-v2/commit/b3e07aa0a0dd26ec46095c28ce6530