Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039731786 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docke

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039747415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039760269 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

[PR] HBASE-28491 Bump netty to 4.1.108.Final for addressing CVE-2024-29025 [hbase-thirdparty]

2024-04-05 Thread via GitHub
nikita15p opened a new pull request, #114: URL: https://github.com/apache/hbase-thirdparty/pull/114 Bump netty to 4.1.108.Final for addressing CVE-2024-29025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2039775766 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docke

Re: [PR] HBASE-28491 Bump netty to 4.1.108.Final for addressing CVE-2024-29025 [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #114: URL: https://github.com/apache/hbase-thirdparty/pull/114#issuecomment-2039786578 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-04-05 Thread via GitHub
gvprathyusha6 commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2039800055 > Could you please provide a UT or add an example in hbase-examples to show how to make use of this feature? > > Thanks. @Apache9 I have added UT to parse and validate th

[PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
charlesconnell opened a new pull request, #5797: URL: https://github.com/apache/hbase/pull/5797 The zstd documentation recommends re-using context objects when possible, because their creation has some expense. They can be more cheaply reset than re-created. In this PR, create one `Zstd(De)

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040058881 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040080835 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s | Docker

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040087900 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040092852 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040097536 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040142461 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-05 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1553921169 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040148858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040158699 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040160407 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-05 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1553937551 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553979182 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1553980810 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -0,0 +1,388 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2040317353 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2040357049 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040427103 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040433873 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040434584 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docke

Re: [PR] HBASE-28485: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5797: URL: https://github.com/apache/hbase/pull/5797#issuecomment-2040435656 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5798: URL: https://github.com/apache/hbase/pull/5798#issuecomment-2040481039 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040481765 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040537932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2040561463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040590074 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

Re: [PR] HBASE-28184 Addendum PR [hbase]

2024-04-05 Thread via GitHub
shahrs87 commented on code in PR #5521: URL: https://github.com/apache/hbase/pull/5521#discussion_r1554314183 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java: ## @@ -259,10 +259,11 @@ private boolean readNextEntryAndRecordReader

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5798: URL: https://github.com/apache/hbase/pull/5798#issuecomment-2040733859 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040820860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2040824093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docke

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #5798: URL: https://github.com/apache/hbase/pull/5798#issuecomment-2040825283 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker

Re: [PR] HBASE-28491 Bump netty to 4.1.108.Final for addressing CVE-2024-29025 [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #114: URL: https://github.com/apache/hbase-thirdparty/pull/114#issuecomment-2040892694 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115#issuecomment-2040896396 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s

Re: [PR] HBASE-28491 Bump netty to 4.1.108.Final for addressing CVE-2024-29025 [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache9 commented on PR #114: URL: https://github.com/apache/hbase-thirdparty/pull/114#issuecomment-2040900449 Seems something wrong with jenkins... All mvn related commands failed without any output... Will dig later. -- This is an automated message from the Apache Git Servi

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115#issuecomment-2040901500 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s

Re: [PR] HBASE-28436 Use connection url to specify the connection registry inf… [hbase]

2024-04-05 Thread via GitHub
Apache9 commented on code in PR #5770: URL: https://github.com/apache/hbase/pull/5770#discussion_r1554530171 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] HBASE-28436 Use connection url to specify the connection registry inf… [hbase]

2024-04-05 Thread via GitHub
Apache9 commented on PR #5770: URL: https://github.com/apache/hbase/pull/5770#issuecomment-2040980945 Let me conclude a bit. Finally we focus on the scheme part of the URI. @ndimiduk thought the second part should be communication protocol when connecting to hbase cluster, so u

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115#issuecomment-2040982892 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115#issuecomment-2040983319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115#issuecomment-2040985527 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-05 Thread via GitHub
Apache-HBase commented on PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115#issuecomment-2040985410 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041033210 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041033484 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-06 Thread via GitHub
thomassngdata commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041033620 Issue with `mvn spotless:apply -pl hbase-backup` was a duplicate `hamcrest-library` dependency in hbase-replication/pom.xml, nothing to do with my PR but fixed it. -- This is an au

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041039664 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041039382 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041040126 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041042403 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041043112 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041044074 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041044689 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041044628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-06 Thread via GitHub
bbeaudreault commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041051470 What I was referring to about spotless was this error in the first build: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5795/1/artifact/yetus-general-check/output/pat

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache9 commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041061896 Seems OK after upgrading to maven 3.9 jdk8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041066638 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116#issuecomment-2041066493 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.

Re: [PR] HBASE-28495 [hbase-thirdparty] Fix pre commit build [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache9 merged PR #116: URL: https://github.com/apache/hbase-thirdparty/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbas

Re: [PR] HBASE-28492 [hbase-thirdparty] Bump dependency versions before releasing [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #115: URL: https://github.com/apache/hbase-thirdparty/pull/115#issuecomment-2041080177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s

Re: [PR] HBASE-28491 Bump netty to 4.1.108.Final for addressing CVE-2024-29025 [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #114: URL: https://github.com/apache/hbase-thirdparty/pull/114#issuecomment-2041114686 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-06 Thread via GitHub
bbeaudreault merged PR #5795: URL: https://github.com/apache/hbase/pull/5795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.ap

Re: [PR] HBASE-28483 backup merge fails on bulkloaded hfiles [hbase]

2024-04-06 Thread via GitHub
bbeaudreault commented on PR #5795: URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041143715 I investigated and it does seem like a true duplicate. I don't think this was related, but it's ok. More importantly, the spotless formatting issues have been fixed. Going to merge thi

Re: [PR] HBASE-28491 Bump netty to 4.1.108.Final for addressing CVE-2024-29025 [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache-HBase commented on PR #114: URL: https://github.com/apache/hbase-thirdparty/pull/114#issuecomment-2041248566 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s

Re: [PR] HBASE-28491 Bump netty to 4.1.108.Final for addressing CVE-2024-29025 [hbase-thirdparty]

2024-04-06 Thread via GitHub
Apache9 merged PR #114: URL: https://github.com/apache/hbase-thirdparty/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbas

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-07 Thread via GitHub
pankaj72981 closed pull request #5792: HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow URL: https://github.com/apache/hbase/pull/5792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-07 Thread via GitHub
chandrasekhar-188k commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2041362165 > 💔 **-1 overall** > > Vote Subsystem Runtime Comment > +0 🆗 reexec 0m 57s Docker mode activated. > -0 ⚠️ yetus 0m 3s Unprocessed flag(s):

Re: [PR] HBASE-28457 Introduce a version field in file based tracker record [hbase]

2024-04-07 Thread via GitHub
Apache9 merged PR #5784: URL: https://github.com/apache/hbase/pull/5784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2041373889 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m 47s | Docke

Re: [PR] HBASE-28481 Prompting table already exists after failing to create table with many region replications [hbase]

2024-04-07 Thread via GitHub
Apache9 merged PR #5789: URL: https://github.com/apache/hbase/pull/5789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

Re: [PR] HBASE-28478 Remove the hbase1 compatible code in FixedFileTrailer [hbase]

2024-04-07 Thread via GitHub
Apache9 merged PR #5788: URL: https://github.com/apache/hbase/pull/5788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.

[PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
mnpoonia opened a new pull request, #5799: URL: https://github.com/apache/hbase/pull/5799 …d and is still in state merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
mnpoonia commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041427749 @virajjasani FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041439330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 15s | Docke

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache9 commented on code in PR #5799: URL: https://github.com/apache/hbase/pull/5799#discussion_r1554949639 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java: ## @@ -639,8 +639,27 @@ private void cleanupMergedRegion(final Ma

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2041453907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 26s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2041458102 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2041460827 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 25s | Docke

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-07 Thread via GitHub
bbeaudreault merged PR #5691: URL: https://github.com/apache/hbase/pull/5691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.ap

Re: [PR] HBASE-28497 Missing fields in Get.toJSON [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5800: URL: https://github.com/apache/hbase/pull/5800#issuecomment-2041505361 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28497 Missing fields in Get.toJSON [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5800: URL: https://github.com/apache/hbase/pull/5800#issuecomment-2041505778 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docke

Re: [PR] HBASE-28497 Missing fields in Get.toJSON [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5800: URL: https://github.com/apache/hbase/pull/5800#issuecomment-2041505713 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 35s | Docke

Re: [PR] HBASE-28497 Missing fields in Get.toJSON [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5800: URL: https://github.com/apache/hbase/pull/5800#issuecomment-2041506081 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 43s | Docke

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041509329 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docker

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041511557 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041512797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
mnpoonia commented on code in PR #5799: URL: https://github.com/apache/hbase/pull/5799#discussion_r1555018299 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java: ## @@ -639,8 +639,27 @@ private void cleanupMergedRegion(final M

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
mnpoonia commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041544428 If it matters i test with very rudimentary way Changed MergeTableRegionProcedure method ``` private TransitRegionStateProcedure[] createUnassignProcedures(MasterProcedureEnv env)

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
virajjasani commented on code in PR #5799: URL: https://github.com/apache/hbase/pull/5799#discussion_r1555019484 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java: ## @@ -639,8 +639,22 @@ private void cleanupMergedRegion(fina

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
virajjasani commented on code in PR #5799: URL: https://github.com/apache/hbase/pull/5799#discussion_r1555020386 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java: ## @@ -639,8 +639,22 @@ private void cleanupMergedRegion(fina

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
mnpoonia commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041547399 I think i made a mistake. A small but important one which breaks the design of rollback in procedure framework. We didnot change regionNode state in `MERGE_TABLE_REGIONS_CLOSE_REGIONS`

[PR] Hbase 28498 fix spotless:check errors [hbase]

2024-04-07 Thread via GitHub
nikita15p opened a new pull request, #5801: URL: https://github.com/apache/hbase/pull/5801 The changes as per spotless:apply are added as part of this PR to fix the error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] HBASE-28405 - Fix failed procedure rollback when region was not close… [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5799: URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041553082 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28498 fix spotless:check errors [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5801: URL: https://github.com/apache/hbase/pull/5801#issuecomment-2041553625 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28498 fix spotless:check errors [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5801: URL: https://github.com/apache/hbase/pull/5801#issuecomment-2041553917 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker

Re: [PR] HBASE-28498 fix spotless:check errors [hbase]

2024-04-07 Thread via GitHub
Apache-HBase commented on PR #5801: URL: https://github.com/apache/hbase/pull/5801#issuecomment-2041554345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 34s | Docke

<    1   2   3   4   5   6   7   8   9   10   >