Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2039020299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docke

Re: [PR] HBASE-28486 fix CVE-2024-29025 in netty package [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5794: URL: https://github.com/apache/hbase/pull/5794#issuecomment-2039013665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2039009119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

[jira] [Updated] (HBASE-28486) fix CVE-2024-29025 in netty package

2024-04-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28486: --- Labels: pull-request-available (was: ) > fix CVE-2024-29025 in netty package > ---

[jira] [Resolved] (HBASE-28366) Mis-order of SCP and regionServerReport results into region inconsistencies

2024-04-04 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-28366. -- Fix Version/s: 2.6.0 2.4.18 3.0.0-beta-2

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-04 Thread via GitHub
virajjasani merged PR #5774: URL: https://github.com/apache/hbase/pull/5774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apa

[jira] [Assigned] (HBASE-28486) fix CVE-2024-29025 in netty package

2024-04-04 Thread Nikita Pande (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Pande reassigned HBASE-28486: Assignee: Nikita Pande > fix CVE-2024-29025 in netty package > -

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2038691759 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s | Docke

[jira] [Updated] (HBASE-28486) fix CVE-2024-29025 in netty package

2024-04-04 Thread Nikita Pande (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikita Pande updated HBASE-28486: - Summary: fix CVE-2024-29025 in netty package (was: CVE-2024-29025 found in netty package ) >

[jira] [Created] (HBASE-28486) CVE-2024-29025 found in netty package

2024-04-04 Thread Nikita Pande (Jira)
Nikita Pande created HBASE-28486: Summary: CVE-2024-29025 found in netty package Key: HBASE-28486 URL: https://issues.apache.org/jira/browse/HBASE-28486 Project: HBase Issue Type: Improvemen

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
chandrasekhar-188k commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-2038622733 > @chandrasekhar-188k Any update? review comments fixed , please check again -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
chandrasekhar-188k commented on code in PR #5691: URL: https://github.com/apache/hbase/pull/5691#discussion_r1552671215 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java: ## @@ -2726,16 +2726,20 @@ protected void run() throws IOException { Mast

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-04-04 Thread via GitHub
chandrasekhar-188k commented on code in PR #5691: URL: https://github.com/apache/hbase/pull/5691#discussion_r1552671014 ## hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaAdmin.java: ## @@ -994,4 +994,16 @@ public int getQuotaSettingCount(Admin admin) throws

[jira] [Comment Edited] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834068#comment-17834068 ] Charles Connell edited comment on HBASE-28485 at 4/5/24 12:24 AM:

[jira] [Comment Edited] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834068#comment-17834068 ] Charles Connell edited comment on HBASE-28485 at 4/5/24 12:24 AM:

[jira] [Updated] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Connell updated HBASE-28485: Description: The zstd documentation recommends re-using context objects when possible, bec

[jira] [Commented] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834068#comment-17834068 ] Charles Connell commented on HBASE-28485: - I've attached a flamegraph showing Zs

[jira] [Comment Edited] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834068#comment-17834068 ] Charles Connell edited comment on HBASE-28485 at 4/4/24 8:03 PM: -

[jira] [Comment Edited] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834068#comment-17834068 ] Charles Connell edited comment on HBASE-28485 at 4/4/24 8:03 PM: -

[jira] [Updated] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Connell updated HBASE-28485: Attachment: async-prof-flamegraph-cpu_event-1712150670836-cpu.html > Re-use ZstdDecompress

[jira] [Created] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
Charles Connell created HBASE-28485: --- Summary: Re-use ZstdDecompressCtx/ZstdCompressCtx for performance Key: HBASE-28485 URL: https://issues.apache.org/jira/browse/HBASE-28485 Project: HBase

[jira] [Updated] (HBASE-28485) Re-use ZstdDecompressCtx/ZstdCompressCtx for performance

2024-04-04 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Connell updated HBASE-28485: Attachment: async-prof-pid-1324144-cpu-1.html > Re-use ZstdDecompressCtx/ZstdCompressCtx f

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037800563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037736939 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docke

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552061992 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552053165 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552050096 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1552047719 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (HBASE-28484) Allow replication to different table

2024-04-04 Thread Hernan Gelaf-Romer (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hernan Gelaf-Romer updated HBASE-28484: --- Summary: Allow replication to different table (was: Allow replicating to different

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037647435 > Overall, looks good, I just think we need to add javadoc on public methods and explain properly when we will consider a file/block as cold/hot, specially when dealing with default t

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
wchevreuil commented on code in PR #5793: URL: https://github.com/apache/hbase/pull/5793#discussion_r1551838394 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DataTieringManager.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Created] (HBASE-28484) Allow replicating to different table

2024-04-04 Thread Hernan Gelaf-Romer (Jira)
Hernan Gelaf-Romer created HBASE-28484: -- Summary: Allow replicating to different table Key: HBASE-28484 URL: https://issues.apache.org/jira/browse/HBASE-28484 Project: HBase Issue Type:

[jira] [Commented] (HBASE-28483) Merge of incremental backups fails on bulkloaded Hfiles

2024-04-04 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833939#comment-17833939 ] Bryan Beaudreault commented on HBASE-28483: --- Thanks [~thomas.sarens]. I assign

[jira] [Assigned] (HBASE-28483) Merge of incremental backups fails on bulkloaded Hfiles

2024-04-04 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault reassigned HBASE-28483: - Assignee: thomassarens > Merge of incremental backups fails on bulkloaded Hfile

[jira] [Created] (HBASE-28483) Merge of incremental backups fails on bulkloaded Hfiles

2024-04-04 Thread thomassarens (Jira)
thomassarens created HBASE-28483: Summary: Merge of incremental backups fails on bulkloaded Hfiles Key: HBASE-28483 URL: https://issues.apache.org/jira/browse/HBASE-28483 Project: HBase Issue

Re: [PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5793: URL: https://github.com/apache/hbase/pull/5793#issuecomment-2037183945 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

[jira] [Updated] (HBASE-28465) Implementation of framework for time-based priority bucket-cache.

2024-04-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28465: --- Labels: pull-request-available (was: ) > Implementation of framework for time-based priorit

[PR] HBASE-28465 Implementation of framework for time-based priority bucket-cache [hbase]

2024-04-04 Thread via GitHub
vinayakphegde opened a new pull request, #5793: URL: https://github.com/apache/hbase/pull/5793 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Assigned] (HBASE-28467) Integration of time-based priority caching into write and read code paths.

2024-04-04 Thread Janardhan Hungund (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janardhan Hungund reassigned HBASE-28467: - Assignee: Janardhan Hungund > Integration of time-based priority caching into w

[jira] [Assigned] (HBASE-28466) Integration of time-based priority logic of bucket cache in prefetch functionality of HBase.

2024-04-04 Thread Janardhan Hungund (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janardhan Hungund reassigned HBASE-28466: - Assignee: Vinayak Hegde > Integration of time-based priority logic of bucket ca

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-04 Thread via GitHub
vineet4008 commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036922036 TestPrefetchPersistence#testPrefetchPersistence test has no relevance with the current PR change. It is failing without this PR change also. -- This is an automated message from

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-04 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1551380210 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-04 Thread via GitHub
kabhishek4 commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1551378020 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-04 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1551344684 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28292 Make Delay prefetch property to be dynamically configured [hbase]

2024-04-04 Thread via GitHub
wchevreuil commented on code in PR #5605: URL: https://github.com/apache/hbase/pull/5605#discussion_r1551312368 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java: ## @@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036507833 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036499577 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

Re: [PR] HBASE-28482 Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE in setCurrentBlock flow [hbase]

2024-04-04 Thread via GitHub
Apache-HBase commented on PR #5792: URL: https://github.com/apache/hbase/pull/5792#issuecomment-2036449523 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke