Re: [Interest] Set manipulation in Qt 6

2020-06-30 Thread Thiago Macieira
On Tuesday, 30 June 2020 18:04:24 PDT d3fault wrote: > or should we also remove QString::toLower, since one can use std > facilities to accomplish the same thing like this: > QString data = "Abc"; > std::transform(data.begin(), data.end(), data.begin(), > [](unsigned int c){ return QChar::toLow

Re: [Interest] Set manipulation in Qt 6

2020-06-30 Thread d3fault
On 6/21/20, André Pönitz wrote: > Having to thoroughly check each and > every such replacement only to get in the best case the same functionality > as before is an awful value proposition. this. or should we also remove QString::toLower, since one can use std facilities to accomplish the same th

Re: [Interest] Set manipulation in Qt 6

2020-06-21 Thread Giuseppe D'Angelo via Interest
Il 21/06/20 20:07, Elvis Stansvik ha scritto: I'm all for Qt offering faster way to do things. I expect that. But I also wonder: Why remove the slower alternative for those who value readability over optimality in the cases where the extra performance is not needed? In the docs, the slow alternat

Re: [Interest] Set manipulation in Qt 6

2020-06-21 Thread Elvis Stansvik
Den sön 21 juni 2020 kl 19:23 skrev André Pönitz : > > On Sat, Jun 20, 2020 at 12:34:11PM +0200, Giuseppe D'Angelo via Interest > wrote: > > With my hat of the guy going around and deprecating toSet() and friends: the > > rationale for these deprecations is the terrible code that those methods > >

Re: [Interest] Set manipulation in Qt 6

2020-06-21 Thread André Pönitz
On Sat, Jun 20, 2020 at 12:34:11PM +0200, Giuseppe D'Angelo via Interest wrote: > With my hat of the guy going around and deprecating toSet() and friends: the > rationale for these deprecations is the terrible code that those methods > encourage, and the While I sympathize to some degree with the

Re: [Interest] Set manipulation in Qt 6

2020-06-20 Thread André Pönitz
On Sat, Jun 20, 2020 at 08:44:19AM +0200, Vadim Peretokin wrote: >Being good users open-source of Qt, [1]we're looking into our >compatibility early on to help report any issues and we're finding this >compatibility code to be rather problematic from the developer >experience point

Re: [Interest] Set manipulation in Qt 6

2020-06-20 Thread Giuseppe D'Angelo via Interest
Hi, Il 20/06/20 08:44, Vadim Peretokin ha scritto: QMap> customLines; QMap customLinesColor; // ... #if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 0))     auto customLineKeys = customLines.keys();     QSet missingKeys{customLineKeys.begin(), customLineKeys.end()};     if (!customLinesColor.isE

[Interest] Set manipulation in Qt 6

2020-06-19 Thread Vadim Peretokin
Being good users open-source of Qt, we're looking into our compatibility early on to help report any issues and we're finding this compatibility code to be rather problematic from the developer experience point of view: QMap> customLines; QMap customLinesColor; /