Re: [Interest] Changes to Javascript runtime in 5.12

2019-01-03 Thread René Hansen
That's what I've resorted to for now, but yeah, as you say, it's definitely not as nice. Luckily, this time, there wasn't too many libs that needed rewriting. I haven't specifically seen any documentation regarding "this" and the global scope of JS libs, so I guess it might be my own fault for rel

Re: [Interest] Changes to Javascript runtime in 5.12

2019-01-03 Thread Ulf Hermann
Hi René, > In JS libs before 5.12, I've always used a closure approach to not > leak a bunch of private variables onto the global module object. This > results in a layout much like so: > > (function(lib) { > ... closed vars can be declared here ... > > lib.bar = function() { > return "b

[Interest] Changes to Javascript runtime in 5.12

2019-01-02 Thread René Hansen
Hi all, In the progress of upgrading an app to 5.12, I'm seeing some unexpected issues with external JS dependencies. In JS libs before 5.12, I've always used a closure approach to not leak a bunch of private variables onto the global module object. This results in a layout much like so: (funct