Re: [Interest] [PATCH qtbase] qlinuxfbscreen: fix crash in switchToGraphicsMode()

2013-01-10 Thread Sergio Ahumada
On 01/10/2013 07:22 PM, Konrad Rosenbaum wrote: > Hi, > > On Thursday 10 January 2013 09:38:49 Sergio Ahumada wrote: >> On 01/10/2013 08:28 AM, Konrad Rosenbaum wrote: > Since the function already receives as argument the address of > oldMode, there is no need to do &oldMode when doing the

Re: [Interest] [PATCH qtbase] qlinuxfbscreen: fix crash in switchToGraphicsMode()

2013-01-10 Thread Konrad Rosenbaum
Hi, On Thursday 10 January 2013 09:38:49 Sergio Ahumada wrote: > On 01/10/2013 08:28 AM, Konrad Rosenbaum wrote: > >>> Since the function already receives as argument the address of > >>> oldMode, there is no need to do &oldMode when doing the ioctl() call. > The master branch is gone. Please sub

Re: [Interest] [PATCH qtbase] qlinuxfbscreen: fix crash in switchToGraphicsMode()

2013-01-10 Thread Sergio Ahumada
On 01/10/2013 08:28 AM, Konrad Rosenbaum wrote: > Hi, > >>> >>> Since the function already receives as argument the address of >>> oldMode, there is no need to do &oldMode when doing the ioctl() call. >> >>> This patch fixes the following segfault: >> Thanks for the fix, but although it's trifial,

Re: [Interest] [PATCH qtbase] qlinuxfbscreen: fix crash in switchToGraphicsMode()

2013-01-09 Thread Konrad Rosenbaum
Hi, On Wednesday 09 January 2013 23:48:42 Giuseppe D'Angelo wrote: > On 9 January 2013 23:32, Thomas Petazzoni > wrote: > > The switchToGraphicsMode() function calls the KDGETMODE ioctl() call, > > but passes the address of oldMode, which is already a > > pointer. Therefore, the current code make

Re: [Interest] [PATCH qtbase] qlinuxfbscreen: fix crash in switchToGraphicsMode()

2013-01-09 Thread Giuseppe D'Angelo
Hi Thomas, On 9 January 2013 23:32, Thomas Petazzoni wrote: > The switchToGraphicsMode() function calls the KDGETMODE ioctl() call, > but passes the address of oldMode, which is already a > pointer. Therefore, the current code makes the kernel write the "mode" > value returned by the KDGETMODE io

[Interest] [PATCH qtbase] qlinuxfbscreen: fix crash in switchToGraphicsMode()

2013-01-09 Thread Thomas Petazzoni
The switchToGraphicsMode() function calls the KDGETMODE ioctl() call, but passes the address of oldMode, which is already a pointer. Therefore, the current code makes the kernel write the "mode" value returned by the KDGETMODE ioctl() at the address of the oldMode pointer. This pointer becomes NULL