Re: [RFC PATCH 01/39] drm/i915/display: Sanitize PHY_C20_VDR_CUSTOM_SERDES_RATE/DP_RATE field macros

2025-10-01 Thread Raag Jadav
On Wed, Oct 01, 2025 at 11:52:20AM +0300, Jani Nikula wrote: > On Wed, 01 Oct 2025, Mika Kahola wrote: > > From: Imre Deak > > > > Rename the PHY_C20_CUSTOM_SERDES / PHY_C20_CUSTOM_SERDES_MASK register > > field names to PHY_C20_DP_RATE / PHY_C20_DP_RATE_MASK, and move the > > definitions under t

Re: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE

2025-07-30 Thread Raag Jadav
On Wed, Jul 30, 2025 at 12:21:49PM +0200, Geert Uytterhoeven wrote: > Intel Discrete Graphics non-volatile memory is onlt present on intel only

Re: [PATCH v7 2/5] drm: Create a task info option for wedge events

2025-06-15 Thread Raag Jadav
ight be already > dead by the time userspace will try to check what was this PID's name, > so to make the life easier also notify what's the task's name in the user > event. > > Acked-by: Rodrigo Vivi (for i915 and xe) > Reviewed-by: Krzysztof Karas > Reviewed-by:

Re: [PATCH v11 04/10] mtd: intel-dg: register with mtd

2025-05-30 Thread Raag Jadav
to be 4bytes aligned. > > CC: Rodrigo Vivi > CC: Lucas De Marchi > Acked-by: Miquel Raynal > Co-developed-by: Tomas Winkler > Signed-off-by: Tomas Winkler > Co-developed-by: Vitaly Lubart > Signed-off-by: Vitaly Lubart > Signed-off-by: Alexander Usyskin Reviewed-by: Raag Jadav

Re: [PATCH v11 05/10] mtd: intel-dg: align 64bit read and write

2025-05-30 Thread Raag Jadav
On Wed, May 28, 2025 at 04:51:10PM +0300, Alexander Usyskin wrote: > GSC NVM controller HW errors on quad access overlapping 1K border. > Align 64bit read and write to avoid readq/writeq over 1K border. > > Acked-by: Miquel Raynal > Signed-off-by: Alexander Usyskin Reviewed-by: Raag Jadav

Re: [PATCH v11 02/10] mtd: intel-dg: implement region enumeration

2025-05-30 Thread Raag Jadav
ped-by: Tomas Winkler > Signed-off-by: Tomas Winkler > Signed-off-by: Alexander Usyskin Reviewed-by: Raag Jadav

Re: [PATCH v10 05/10] mtd: intel-dg: align 64bit read and write

2025-05-27 Thread Raag Jadav
On Tue, May 27, 2025 at 11:33:10AM +0530, Usyskin, Alexander wrote: > > Subject: Re: [PATCH v10 05/10] mtd: intel-dg: align 64bit read and write > > > > On Thu, May 15, 2025 at 04:33:40PM +0300, Alexander Usyskin wrote: > > > GSC NVM controller HW errors on quad access overlapping 1K border. > > >

Re: [PATCH v10 08/10] drm/xe/nvm: add on-die non-volatile memory device

2025-05-27 Thread Raag Jadav
On Tue, May 27, 2025 at 11:55:13AM +0530, Usyskin, Alexander wrote: > > Subject: Re: [PATCH v10 08/10] drm/xe/nvm: add on-die non-volatile > > memory device > > > > On Thu, May 15, 2025 at 04:33:43PM +0300, Alexander Usyskin wrote: > > > Enable access to internal non-volatile memory on DGFX > > >

Re: [PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete graphics

2025-05-27 Thread Raag Jadav
On Tue, May 27, 2025 at 11:30:20AM +0530, Usyskin, Alexander wrote: > > Subject: Re: [PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete > > graphics > > > > On Thu, May 15, 2025 at 04:33:41PM +0300, Alexander Usyskin wrote: > > > Enable access to internal non-volatile memory on > > > DGFX

Re: [PATCH v10 08/10] drm/xe/nvm: add on-die non-volatile memory device

2025-05-24 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:43PM +0300, Alexander Usyskin wrote: > Enable access to internal non-volatile memory on DGFX > with GSC/CSC devices via a child device. > The nvm child device is exposed via auxiliary bus. ... > +void xe_nvm_init(struct xe_device *xe) > +{ Same as patch 6, please ha

Re: [PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete graphics

2025-05-24 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:41PM +0300, Alexander Usyskin wrote: > Enable access to internal non-volatile memory on > DGFX devices via a child device. > The nvm child device is exposed via auxiliary bus. ... > +void intel_nvm_init(struct drm_i915_private *i915) > +{ Lucas recently revamped xe

Re: [PATCH v10 05/10] mtd: intel-dg: align 64bit read and write

2025-05-24 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:40PM +0300, Alexander Usyskin wrote: > GSC NVM controller HW errors on quad access overlapping 1K border. > Align 64bit read and write to avoid readq/writeq over 1K border. > > Acked-by: Miquel Raynal > Signed-off-by: Alexander Usyskin > --- > drivers/mtd/devices/m

Re: [PATCH v6 1/3] drm: Create a task info option for wedge events

2025-05-22 Thread Raag Jadav
s */ > - char event_string[32]; > - char *envp[] = { event_string, NULL }; > + char event_string[WEDGE_STR_LEN], pid_string[PID_LEN] = "", > comm_string[TASK_COMM_LEN] = ""; Most likely there's no need to initialize these. With above changes, Reviewed-by: Raag Jadav

Re: [PATCH v10 04/10] mtd: intel-dg: register with mtd

2025-05-21 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:39PM +0300, Alexander Usyskin wrote: > Register the on-die nvm device with the mtd subsystem. > Refcount nvm object on _get and _put mtd callbacks. > For erase operation address and size should be 4K aligned. > For write operation address and size has to be 4bytes alig

Re: [PATCH v10 03/10] mtd: intel-dg: implement access functions

2025-05-21 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:38PM +0300, Alexander Usyskin wrote: > Implement read(), erase() and write() functions. ... > +__maybe_unused > +static ssize_t idg_write(struct intel_dg_nvm *nvm, u8 region, > + loff_t to, size_t len, const unsigned char *buf) > +{ > + size_

Re: [PATCH v5 1/3] drm: Create a task info option for wedge events

2025-05-21 Thread Raag Jadav
On Tue, May 20, 2025 at 01:32:41PM -0300, André Almeida wrote: > When a device get wedged, it might be caused by a guilty application. > For userspace, knowing which task was the cause can be useful for some > situations, like for implementing a policy, logs or for giving a chance > for the composi

Re: [PATCH v10 03/10] mtd: intel-dg: implement access functions

2025-05-20 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:38PM +0300, Alexander Usyskin wrote: > Implement read(), erase() and write() functions. ... > +__maybe_unused > +static unsigned int idg_nvm_get_region(const struct intel_dg_nvm *nvm, > loff_t from) > +{ > + unsigned int i; > + > + for (i = 0; i < nvm->nregi

Re: [PATCH v4 1/3] drm: Create an app info option for wedge events

2025-05-20 Thread Raag Jadav
On Mon, May 19, 2025 at 07:03:30PM -0300, André Almeida wrote: > When a device get wedged, it might be caused by a guilty application. > For userspace, knowing which app was the cause can be useful for some > situations, like for implementing a policy, logs or for giving a chance > for the composit

Re: [PATCH v3 1/3] drm: Create an app info option for wedge events

2025-05-18 Thread Raag Jadav
On Mon, May 12, 2025 at 05:34:35PM -0300, André Almeida wrote: > When a device get wedged, it might be caused by a guilty application. > For userspace, knowing which app was the cause can be useful for some > situations, like for implementing a policy, logs or for giving a chance > for the composit

Re: [PATCH v10 02/10] mtd: intel-dg: implement region enumeration

2025-05-16 Thread Raag Jadav
; + int ret; > + unsigned int i, n; > + u32 access_map = 0; Reverse xmas order (along with all other places) and Reviewed-by: Raag Jadav > + /* clean error register, previous errors are ignored */ > + idg_nvm_error(nvm); > + > + ret = idg_n

Re: [PATCH v10 01/10] mtd: add driver for intel graphics non-volatile memory device

2025-05-16 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:36PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > non-volatile memory device. A few nits below but we're good to go. Reviewed-by: Raag Jadav ... > +static int intel_dg_mtd_probe(struct auxiliary_d

Re: [PATCH v3 2/3] drm/doc: Add a section about "App information" for the wedge API

2025-05-16 Thread Raag Jadav
the uevent will display as ``PID=`` and > +``APP=``. Otherwise, ``PID`` and ``APP`` will not appear in the > event Personally I'd use Linux specific naming for consistency. s/APP/TASK But in any case, Reviewed-by: Raag Jadav > +string. > + > +The reliability of this infor

Re: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration

2025-05-15 Thread Raag Jadav
On Thu, May 15, 2025 at 04:53:38PM +0530, Usyskin, Alexander wrote: > > On Thu, Apr 24, 2025 at 04:25:27PM +0300, Alexander Usyskin wrote: > > > In intel-dg, there is no access to the spi controller, > > > the information is extracted from the descriptor region. > > > > ... > > > > > @@ -22,9 +24

Re: [PATCH v9 02/12] mtd: add driver for intel graphics non-volatile memory device

2025-05-15 Thread Raag Jadav
On Thu, May 15, 2025 at 03:41:08PM +0530, Usyskin, Alexander wrote: > > On Thu, Apr 24, 2025 at 04:25:26PM +0300, Alexander Usyskin wrote: > > > Add auxiliary driver for intel discrete graphics > > > non-volatile memory device. ... > > > + for (n = 0, i = 0; i < INTEL_DG_NVM_REGIONS; i++) { > > >

Re: [PATCH v2 2/3] drm/doc: Add a section about "App information" for the wedge API

2025-05-12 Thread Raag Jadav
On Sun, May 11, 2025 at 07:47:44PM -0300, André Almeida wrote: > Add a section about "App information" for the wedge API. > > Signed-off-by: André Almeida > --- > Documentation/gpu/drm-uapi.rst | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/gpu/drm-uapi.

Re: Rare divide error during display resume

2025-05-02 Thread Raag Jadav
On Tue, Apr 29, 2025 at 01:16:56AM +0530, Vivi, Rodrigo wrote: > On Mon, 2025-04-28 at 10:59 +0300, Raag Jadav wrote: > > On Mon, Apr 28, 2025 at 10:31:23AM +0300, Jani Nikula wrote: > > > > > > PCI ID of the platform? > > > > Apologies for missi

Re: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration

2025-04-29 Thread Raag Jadav
On Thu, Apr 24, 2025 at 04:25:27PM +0300, Alexander Usyskin wrote: > In intel-dg, there is no access to the spi controller, > the information is extracted from the descriptor region. ... > @@ -22,9 +24,199 @@ struct intel_dg_nvm { > u8 id; > u64 offset; >

Re: [PATCH v9 02/12] mtd: add driver for intel graphics non-volatile memory device

2025-04-29 Thread Raag Jadav
On Thu, Apr 24, 2025 at 04:25:26PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > non-volatile memory device. ... > +static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev, > + const struct auxiliary_device_id *aux_dev_id) >

Re: Rare divide error during display resume

2025-04-28 Thread Raag Jadav
n, 27 Apr 2025, Raag Jadav wrote: > > I came across this while testing an unrelated feature. It's not easily > > reproducible so thought I'd share here. > > > > [ 1802.992726] PM: suspend entry (s2idle) > > [ 1802.993986] Filesystems sync: 0.001 seconds > >

Rare divide error during display resume

2025-04-27 Thread Raag Jadav
I came across this while testing an unrelated feature. It's not easily reproducible so thought I'd share here. [ 1802.992726] PM: suspend entry (s2idle) [ 1802.993986] Filesystems sync: 0.001 seconds [ 1826.223060] xe :03:00.0: [drm] *ERROR* Writing dc state to 0xbff4 failed, now 0xff

Re: [PATCH v2 2/6] drm/i915/pm: Hoist pci_save_state()+pci_set_power_state() to the end of pm _late() hook

2025-03-17 Thread Raag Jadav
On Tue, Mar 11, 2025 at 09:56:20PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drivers/pci does the pci_save_state()+pci_set_power_state() from > the _noirq() pm hooks. Move our manual calls (needed for the > hibernate vs. D3 workaround with buggy BIOSes) towards that same > point. We c

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-13 Thread Raag Jadav
On Wed, Mar 12, 2025 at 06:59:33PM -0300, André Almeida wrote: > Em 12/03/2025 07:06, Raag Jadav escreveu: > > On Tue, Mar 11, 2025 at 07:09:45PM +0200, Raag Jadav wrote: > > > On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: > > > > Em 01/03/2

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-12 Thread Raag Jadav
On Tue, Mar 11, 2025 at 07:09:45PM +0200, Raag Jadav wrote: > On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: > > Em 01/03/2025 02:53, Raag Jadav escreveu: > > > On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: > > > > Hi Raag, > >

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-03-12 Thread Raag Jadav
On Wed, Mar 12, 2025 at 09:25:08AM +0100, Christian König wrote: >Am 11.03.25 um 18:13 schrieb Raag Jadav: >> On Mon, Mar 10, 2025 at 06:03:27PM -0400, Alex Deucher wrote: >>> On Mon, Mar 10, 2025 at 5:54 PM André Almeida >>> wrote: >>>> Em 01/03/2025 0

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-03-11 Thread Raag Jadav
On Mon, Mar 10, 2025 at 06:03:27PM -0400, Alex Deucher wrote: > On Mon, Mar 10, 2025 at 5:54 PM André Almeida wrote: > > > > Em 01/03/2025 03:04, Raag Jadav escreveu: > > > On Fri, Feb 28, 2025 at 06:49:43PM -0300, André Almeida wrote: > > >> Hi Raag, > &

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-11 Thread Raag Jadav
On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: > Em 01/03/2025 02:53, Raag Jadav escreveu: > > On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: > > > Hi Raag, > > > > > > On 2/28/25 11:20, Raag Jadav wrote: > > > > Cc

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-03-02 Thread Raag Jadav
On Fri, Feb 28, 2025 at 06:49:43PM -0300, André Almeida wrote: > Hi Raag, > > On 2/28/25 11:58, Raag Jadav wrote: > > On Fri, Feb 28, 2025 at 09:13:53AM -0300, André Almeida wrote: > > > To notify userspace about which app (if any) made the device get in a > &

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-02-28 Thread Raag Jadav
On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: > Hi Raag, > > On 2/28/25 11:20, Raag Jadav wrote: > > Cc: Lucas > > > > On Fri, Feb 28, 2025 at 09:13:52AM -0300, André Almeida wrote: > > > When a device get wedged, it might be caused by a gui

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-02-28 Thread Raag Jadav
On Fri, Feb 28, 2025 at 09:13:53AM -0300, André Almeida wrote: > To notify userspace about which app (if any) made the device get in a > wedge state, make use of drm_wedge_app_info parameter, filling it with > the app PID and name. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/amd

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-02-28 Thread Raag Jadav
Cc: Lucas On Fri, Feb 28, 2025 at 09:13:52AM -0300, André Almeida wrote: > When a device get wedged, it might be caused by a guilty application. > For userspace, knowing which app was the cause can be useful for some > situations, like for implementing a policy, logs or for giving a chance > for t

Re: [PATCH v12 0/5] Introduce DRM device wedged event

2025-02-11 Thread Raag Jadav
On Tue, Feb 04, 2025 at 12:35:23PM +0530, Raag Jadav wrote: > This series introduces device wedged event in DRM subsystem and uses it > in xe, i915 and amdgpu drivers. Detailed description in commit message. > > This was earlier attempted as xe specific uevent in v1 and v2 on [1]. &g

[PATCH v12 5/5] drm/amdgpu: Use device wedged event

2025-02-03 Thread Raag Jadav
From: André Almeida Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma Signed-off-by: André Alme

[PATCH v12 4/5] drm/i915: Use device wedged event

2025-02-03 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu

[PATCH v12 3/5] drm/xe: Use device wedged event

2025-02-03 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device.c | 7 ++- 1 fi

[PATCH v12 2/5] drm/doc: Document device wedged event

2025-02-03 Thread Raag Jadav
leanup and consumer prerequisites (Christian, Aravind) v11: Reference wedged event in device reset chapter (André) v12: Refine consumer expectations and terminologies (Xaver, Pekka) Signed-off-by: Raag Jadav Reviewed-by: Christian König Reviewed-by: André Almeida --- Documentation/gpu/drm-uapi

[PATCH v12 1/5] drm: Introduce device wedged event

2025-02-03 Thread Raag Jadav
djustments (Andy) Handle invalid recovery method v8: Allow sending multiple methods with uevent (Lucas, Michal) static_assert() globally (Andy) v9: Provide 'none' method for device reset (Christian) Provide recovery opts using switch c

[PATCH v12 0/5] Introduce DRM device wedged event

2025-02-03 Thread Raag Jadav
et chapter (André) Wedged event support for amdgpu (André) v12: Refine consumer expectations and terminologies (Xaver, Pekka) André Almeida (1): drm/amdgpu: Use device wedged event Raag Jadav (4): drm: Introduce device wedged event drm/doc: Document device wedged event drm/xe: Use dev

Re: [PATCH 6/6] drm/i915/mst: use min_array() and max_array() instead of hand-rolling

2025-01-31 Thread Raag Jadav
On Fri, Jan 31, 2025 at 11:20:22AM +0200, Jani Nikula wrote: > On Thu, 30 Jan 2025, Imre Deak wrote: > > On Thu, Jan 30, 2025 at 04:35:06PM +0200, Imre Deak wrote: > >> On Wed, Jan 29, 2025 at 04:46:38PM +0200, Jani Nikula wrote: > >> > Improve code clarity by using existing min_array() and max_ar

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2025-01-28 Thread Raag Jadav
On Tue, Jan 28, 2025 at 01:38:09PM +0200, Pekka Paalanen wrote: > On Tue, 28 Jan 2025 11:37:53 +0200 > Raag Jadav wrote: > > > On Mon, Jan 27, 2025 at 12:23:28PM +0200, Pekka Paalanen wrote: > > > On Wed, 22 Jan 2025 07:22:25 +0200 > > > Raag Jadav wrote: >

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2025-01-28 Thread Raag Jadav
On Mon, Jan 27, 2025 at 12:23:28PM +0200, Pekka Paalanen wrote: > On Wed, 22 Jan 2025 07:22:25 +0200 > Raag Jadav wrote: > > > On Tue, Jan 21, 2025 at 02:14:56AM +0100, Xaver Hugl wrote: > > > > +It is the responsibility of the consumer to make sure that the devi

[PATCH v11 5/5] drm/amdgpu: Use device wedged event

2025-01-23 Thread Raag Jadav
From: André Almeida Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma Signed-off-by: André Alme

[PATCH v11 4/5] drm/i915: Use device wedged event

2025-01-23 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu

[PATCH v11 3/5] drm/xe: Use device wedged event

2025-01-23 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device.c | 7 ++- 1 fi

[PATCH v11 2/5] drm/doc: Document device wedged event

2025-01-23 Thread Raag Jadav
leanup and consumer prerequisites (Christian, Aravind) v11: Reference wedged event in device reset section (André) Signed-off-by: Raag Jadav Reviewed-by: Christian König Reviewed-by: André Almeida --- Documentation/gpu/drm-uapi.rst | 112 - 1 file changed, 109 insert

[PATCH v11 1/5] drm: Introduce device wedged event

2025-01-23 Thread Raag Jadav
tatic_assert() globally (Andy) v9: Provide 'none' method for device reset (Christian) Provide recovery opts using switch cases v11: Log device reset (André) Signed-off-by: Raag Jadav Reviewed-by: André Almeida --- drivers/gpu/drm/drm_drv.c | 68

[PATCH v11 0/5] Introduce DRM device wedged event

2025-01-23 Thread Raag Jadav
et section (André) Wedged event support for amdgpu (André) André Almeida (1): drm/amdgpu: Use device wedged event Raag Jadav (4): drm: Introduce device wedged event drm/doc: Document device wedged event drm/xe: Use device wedged event drm/i915: Use device wedged event Documentati

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2025-01-21 Thread Raag Jadav
On Tue, Jan 21, 2025 at 02:14:56AM +0100, Xaver Hugl wrote: > > +It is the responsibility of the consumer to make sure that the device or > > +its resources are not in use by any process before attempting recovery. > I'm not convinced this is actually doable in practice, outside of > killing all ap

Re: [PATCH v10 0/4] Introduce DRM device wedged event

2025-01-21 Thread Raag Jadav
On Tue, Jan 21, 2025 at 01:59:47AM +0100, Xaver Hugl wrote: > Hi, > > I experimented with using this in KWin, and > https://invent.kde.org/plasma/kwin/-/merge_requests/7027/diffs?commit_id=6da40f1b9e2bc94615a436de4778880cee16f940 > makes it fall back to a software renderer when a rebind is require

Re: [PATCH v2] drm/i915: Add Wa_22010465259 in its respective WA list

2025-01-15 Thread Raag Jadav
On Thu, Jan 16, 2025 at 01:08:28PM +0530, Ranu Maurya wrote: > Add Wa_22010465259 which points to an existing WA, but > was missing from the comment list. While at it, update > the other WAs and their applicable platforms as well. > > Signed-off-by: Ranu Maurya > --- > drivers/gpu/drm/i915/gt/in

Re: [PATCH v1] drm/i915/selftest: Change throttle criteria for rps

2025-01-11 Thread Raag Jadav
On Sat, Jan 11, 2025 at 09:41:47PM +0100, Andi Shyti wrote: > Hi Raag, > > On Thu, Jan 02, 2025 at 04:36:18PM +0530, Raag Jadav wrote: > > Current live_rps_control() implementation errors out on throttling. > > This was done with the assumption that throttling to minim

Re: [PATCH] drm/xe: remove unused xe_pciids.h harder, add missing PCI ID

2025-01-09 Thread Raag Jadav
On Thu, Jan 09, 2025 at 12:50:32PM +0200, Jani Nikula wrote: > Commit 493454445c95 ("drm/xe: switch to common PCI ID macros") removed > xe_pciids.h via drm-intel-next. In the mean time, commit ae78ec0a52c4 > ("drm/xe/ptl: Add another PTL PCI ID") added to xe_pciids.h via > drm-xe-next. > > The two

Re: [PATCH v1] drm/i915/selftest: Change throttle criteria for rps

2025-01-08 Thread Raag Jadav
On Thu, Jan 02, 2025 at 04:36:18PM +0530, Raag Jadav wrote: > Current live_rps_control() implementation errors out on throttling. > This was done with the assumption that throttling to minimum frequency > is a catastrophic failure, which is incorrect. Throttling can happen > due t

[PATCH v1] drm/i915/selftest: Change throttle criteria for rps

2025-01-02 Thread Raag Jadav
frequency can be at any given point below the maximum allowed. Change throttle criteria to reflect this logic and drop the error, as it doesn't necessarily mean selftest failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/selftest_rps.c | 11 ++- 1 file changed, 6 insertions(

Re: [PATCH RESEND v2] drm/i915/gt: Log reason for setting TAINT_WARN at reset

2024-12-24 Thread Raag Jadav
On Tue, Dec 24, 2024 at 01:04:37PM +0200, Raag Jadav wrote: > On Mon, Dec 23, 2024 at 08:18:46PM +0100, Andi Shyti wrote: > > Hi Sebastian, > > > > On Fri, Dec 20, 2024 at 02:17:14PM +0100, Andi Shyti wrote: > > > From: Sebastian Brzezinka > > > > >

Re: [PATCH RESEND v2] drm/i915/gt: Log reason for setting TAINT_WARN at reset

2024-12-24 Thread Raag Jadav
On Mon, Dec 23, 2024 at 08:18:46PM +0100, Andi Shyti wrote: > Hi Sebastian, > > On Fri, Dec 20, 2024 at 02:17:14PM +0100, Andi Shyti wrote: > > From: Sebastian Brzezinka > > > > TAINT_WARN is used to notify CI about non-recoverable failures, which > > require device to be restarted. In some case

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2024-12-17 Thread Raag Jadav
On Thu, Dec 12, 2024 at 03:50:29PM -0300, André Almeida wrote: > Em 28/11/2024 12:37, Raag Jadav escreveu: > > Add documentation for device wedged event in a new 'Device wedging' > > chapter. The describes basic definitions, prerequisites and consumer > > exp

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Raag Jadav
2/16/2024 3:48 PM, Christian König wrote: > > > > > Am 13.12.24 um 16:56 schrieb André Almeida: > > > > > > Em 13/12/2024 11:36, Raag Jadav escreveu: > > > > > > > On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: > > > > &g

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-13 Thread Raag Jadav
On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: > Hi Christian, > > Em 13/12/2024 04:34, Christian König escreveu: > > Am 12.12.24 um 20:09 schrieb André Almeida: > > > Use DRM's device wedged event to notify userspace that a reset had > > > happened. For now, only use `none` method

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-13 Thread Raag Jadav
On Thu, Dec 12, 2024 at 03:31:01PM -0300, André Almeida wrote: > Hi Raag, > > Thank you for your patch. > > Em 28/11/2024 12:37, Raag Jadav escreveu: > > [...] > > > +int drm_dev_wedged_event(struct drm_device *dev, unsigned long method) > > +{

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-12 Thread Raag Jadav
On Wed, Dec 11, 2024 at 06:14:12PM +0100, Maxime Ripard wrote: > On Wed, Dec 04, 2024 at 01:17:17PM +0200, Raag Jadav wrote: > > + misc maintainers > > > > On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote: > > > Am 03.12.24 um 06:00 schrieb Raag Jadav

Re: [PATCH v4 0/4] Implement Wa_14022698537

2024-12-12 Thread Raag Jadav
On Thu, Dec 12, 2024 at 09:36:00AM +0100, Andi Shyti wrote: > Hi Raag, > > On Thu, Dec 12, 2024 at 05:22:32AM +0200, Raag Jadav wrote: > > On Thu, Dec 12, 2024 at 12:40:07AM +0100, Andi Shyti wrote: > > > > Raag Jadav (4): > > > > drm/intel/pciids: R

Re: [PATCH v4 0/4] Implement Wa_14022698537

2024-12-11 Thread Raag Jadav
On Thu, Dec 12, 2024 at 12:40:07AM +0100, Andi Shyti wrote: > Hi Raag, > > > Raag Jadav (4): > > drm/intel/pciids: Refactor DG2 PCI IDs into segment ranges > > drm/i915/dg2: Introduce DG2_D subplatform > > drm/i915: Introduce intel_cpu_info.c for CPU IDs

[PATCH v4 1/4] drm/intel/pciids: Refactor DG2 PCI IDs into segment ranges

2024-12-11 Thread Raag Jadav
Refactor DG2 PCI IDs into D, E and M ranges which will be useful for segment specific features. v3: Rework subplatform naming (Jani) Signed-off-by: Raag Jadav Acked-by: Jani Nikula Reviewed-by: Riana Tauro Reviewed-by: Andi Shyti --- include/drm/intel/pciids.h | 55

[PATCH v4 0/4] Implement Wa_14022698537

2024-12-11 Thread Raag Jadav
fix and nits (Riana) Update tags and rebase Raag Jadav (4): drm/intel/pciids: Refactor DG2 PCI IDs into segment ranges drm/i915/dg2: Introduce DG2_D subplatform drm/i915: Introduce intel_cpu_info.c for CPU IDs drm/i915/dg2: Implement Wa_14022698537 drivers/gpu/drm/i915/Makefile

[PATCH v4 3/4] drm/i915: Introduce intel_cpu_info.c for CPU IDs

2024-12-11 Thread Raag Jadav
Having similar naming convention in intel-family.h and intel_device_info.h results in redefinition of a few platforms. Define CPU IDs in its own file to avoid this. v3: Move file out of gt directory, add kernel doc (Riana) Rephrase file description (Jani) Signed-off-by: Raag Jadav Acked-by

[PATCH v4 2/4] drm/i915/dg2: Introduce DG2_D subplatform

2024-12-11 Thread Raag Jadav
Introduce DG2_D subplatform for the devices that span across multiple DG2 subplatforms but are within same segment and will be useful for segment specific features. v3: Rework subplatform naming (Jani) Split subplatform check into separate case (Jani) Signed-off-by: Raag Jadav Acked-by

[PATCH v4 4/4] drm/i915/dg2: Implement Wa_14022698537

2024-12-11 Thread Raag Jadav
dal, Anshuman) Re-order macro (Riana) v4: Spell fix (Riana) Signed-off-by: Raag Jadav Acked-by: Jani Nikula Reviewed-by: Riana Tauro Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/i915_driver.c | 15 +++ drivers/gpu/drm/i915/i915_reg.h| 1 + 2 files changed, 16 insertions(+) d

Re: [PATCH v3 4/4] drm/i915/dg2: Implement Wa_14022698537

2024-12-10 Thread Raag Jadav
On Tue, Dec 10, 2024 at 01:52:21PM +0100, Andi Shyti wrote: > Hi Raag, > > > +/* Wa_14022698537:dg2 */ > > +static void i915_enable_g8(struct drm_i915_private *i915) > > +{ > > + if (IS_DG2(i915)) { > > + if (IS_DG2_D(i915) && !intel_match_g8_cpu()) > > + return; > >

Re: [PATCH v3 4/4] drm/i915/dg2: Implement Wa_14022698537

2024-12-10 Thread Raag Jadav
On Tue, Dec 10, 2024 at 01:33:29PM +0530, Riana Tauro wrote: > On 10/30/2024 8:04 PM, Raag Jadav wrote: > > G8 power state entry is disabled due to a limitation on DG2, so we > > enable it from driver with Wa_14022698537. For now we enable it for > > all DG2 devices with t

Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure

2024-12-10 Thread Raag Jadav
On Mon, Dec 09, 2024 at 11:28:39AM -0500, Rodrigo Vivi wrote: > On Sat, Dec 07, 2024 at 08:14:42AM +0200, Raag Jadav wrote: > > Cc: Chris > > > > On Fri, Dec 06, 2024 at 10:45:18AM -0500, Rodrigo Vivi wrote: > > > On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jad

Re: [PATCHv10 00/10] Display Global Histogram

2024-12-09 Thread Raag Jadav
On Mon, Dec 09, 2024 at 10:18:42AM -0800, Matt Roper wrote: > On Mon, Dec 09, 2024 at 07:43:55PM +0200, Raag Jadav wrote: > > On Mon, Dec 09, 2024 at 08:57:56AM -0800, Matt Roper wrote: > > > On Mon, Dec 09, 2024 at 09:54:54PM +0530, Arun R Murthy wrote: > > > > D

Re: [PATCHv10 00/10] Display Global Histogram

2024-12-09 Thread Raag Jadav
On Mon, Dec 09, 2024 at 10:18:42AM -0800, Matt Roper wrote: > On Mon, Dec 09, 2024 at 07:43:55PM +0200, Raag Jadav wrote: > > On Mon, Dec 09, 2024 at 08:57:56AM -0800, Matt Roper wrote: > > > On Mon, Dec 09, 2024 at 09:54:54PM +0530, Arun R Murthy wrote: > > > > D

Re: [PATCHv10 00/10] Display Global Histogram

2024-12-09 Thread Raag Jadav
On Mon, Dec 09, 2024 at 08:57:56AM -0800, Matt Roper wrote: > On Mon, Dec 09, 2024 at 09:54:54PM +0530, Arun R Murthy wrote: > > Display histogram is a hardware functionality where a statistics for 'x' > > number of frames is generated to form a histogram data. This is notified > > to the user via

Re: [PATCH v2] drm/i915/selftests: Add delay to stabilize frequency in live_rps_power

2024-12-06 Thread Raag Jadav
On Thu, Dec 05, 2024 at 12:07:53PM +0530, Anirban, Sk wrote: > On 03-12-2024 16:16, Jani Nikula wrote: > > On Tue, 03 Dec 2024, Sk Anirban wrote: > > > Add delays to allow frequency stabilization before power measurement > > > to fix sporadic power conservation issues in live_rps_power test. > > L

Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure

2024-12-06 Thread Raag Jadav
Cc: Chris On Fri, Dec 06, 2024 at 10:45:18AM -0500, Rodrigo Vivi wrote: > On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jadav wrote: > > Log throttle reasons on selftest failure which will be useful for > > debugging. > > > > Signed-off-by: Raag Jadav > >

[PATCH v1] drm/i915/selftest: Log throttle reasons on failure

2024-12-05 Thread Raag Jadav
Log throttle reasons on selftest failure which will be useful for debugging. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/selftest_rps.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-04 Thread Raag Jadav
+ misc maintainers On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote: > Am 03.12.24 um 06:00 schrieb Raag Jadav: > > On Mon, Dec 02, 2024 at 10:07:59AM +0200, Raag Jadav wrote: > > > On Fri, Nov 29, 2024 at 10:40:14AM -0300, André Almeida wrote: > > > >

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-02 Thread Raag Jadav
On Mon, Dec 02, 2024 at 10:07:59AM +0200, Raag Jadav wrote: > On Fri, Nov 29, 2024 at 10:40:14AM -0300, André Almeida wrote: > > Hi Raag, > > > > Em 28/11/2024 12:37, Raag Jadav escreveu: > > > Introduce device wedged event, which notifies userspace of 'wedge

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-02 Thread Raag Jadav
On Fri, Nov 29, 2024 at 10:40:14AM -0300, André Almeida wrote: > Hi Raag, > > Em 28/11/2024 12:37, Raag Jadav escreveu: > > Introduce device wedged event, which notifies userspace of 'wedged' > > (hanged/unusable) state of the DRM device through a uevent. This is

[PATCH v10 4/4] drm/i915: Use device wedged event

2024-11-28 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu

[PATCH v10 0/4] Introduce DRM device wedged event

2024-11-28 Thread Raag Jadav
(Andy) v9: Document prerequisites section (Christian) Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases v10: Clarify mmap cleanup and consumer prerequisites (Christian, Aravind) Raag Jadav (4): drm: Introduce device wedged event

[PATCH v10 3/4] drm/xe: Use device wedged event

2024-11-28 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device.c | 9 +++

[PATCH v10 2/4] drm/doc: Document device wedged event

2024-11-28 Thread Raag Jadav
leanup and consumer prerequisites (Christian, Aravind) Signed-off-by: Raag Jadav Reviewed-by: Christian König --- Documentation/gpu/drm-uapi.rst | 112 - 1 file changed, 109 insertions(+), 3 deletions(-) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentati

[PATCH v10 1/4] drm: Introduce device wedged event

2024-11-28 Thread Raag Jadav
globally (Andy) v9: Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_drv.c | 66 +++ include/drm/drm_device.h | 8 + include/drm/drm_drv.h | 1 +

Re: [PATCH] drm/i915/dp: use seq buf for printing rates

2024-11-27 Thread Raag Jadav
On Wed, Nov 27, 2024 at 03:18:38PM +0200, Jani Nikula wrote: > Hand rolling the buffer overflow handling with snprintf() is a bit > tedious. The seq_buf interface is made for this. Switch to it. > > Use struct intel_display while at it. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i91

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-25 Thread Raag Jadav
On Mon, Nov 25, 2024 at 10:32:42AM +0100, Christian König wrote: > Am 22.11.24 um 17:02 schrieb Raag Jadav: > > On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: > > > Am 22.11.24 um 08:07 schrieb Raag Jadav: > > > > On Mon, Nov 18, 2024 at 08:26:37PM +

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-22 Thread Raag Jadav
On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: > Am 22.11.24 um 08:07 schrieb Raag Jadav: > > On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: > > > On 15/11/24 10:37, Raag Jadav wrote: > > > > Introduce device wedged event, which

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-21 Thread Raag Jadav
On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: > On 15/11/24 10:37, Raag Jadav wrote: > > Introduce device wedged event, which notifies userspace of 'wedged' > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful espec

Re: [PATCH v9 3/4] drm/xe: Use device wedged event

2024-11-19 Thread Raag Jadav
On Tue, Nov 19, 2024 at 10:25:10AM +0530, Ghimiray, Himal Prasad wrote: > On 15-11-2024 10:37, Raag Jadav wrote: > > This was previously attempted as xe specific reset uevent but dropped > > in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") &

[PATCH v9 2/4] drm/doc: Document device wedged event

2024-11-14 Thread Raag Jadav
Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) v9: Add prerequisites section (Christian) Signed-off-by: Raag Jadav --- Documen

  1   2   3   >