✓ i915.CI.BAT: success for drm/i915/scaler: Fix for WA_14011503117 (rev2)

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915/scaler: Fix for WA_14011503117 (rev2) URL : https://patchwork.freedesktop.org/series/152571/ State : success == Summary == CI Bug Log - changes from CI_DRM_16962 -> Patchwork_152571v2 Summary ---

Re: [PATCH 01/10] drm/drm-crtc: Introduce sharpness strength property

2025-08-06 Thread Nautiyal, Ankit K
On 8/7/2025 11:21 AM, Nautiyal, Ankit K wrote: Hi Nemesa, Patch looks good to me. Just a couple of minor suggestions in the inline comments for slight improvements in documentation. Also, IMO,  drm_crtc might be better than drm-crtc in the subject line. Reviewed-by: Ankit Nautiyal On 7/

Re: [PATCH 01/10] drm/drm-crtc: Introduce sharpness strength property

2025-08-06 Thread Nautiyal, Ankit K
Hi Nemesa, Patch looks good to me. Just a couple of minor suggestions in the inline comments for slight improvements in documentation. Also, IMO,  drm_crtc might be better than drm-crtc in the subject line. Reviewed-by: Ankit Nautiyal On 7/24/2025 7:15 PM, Nemesa Garg wrote: Introduces th

Re: [PATCH v2] drm/i915/guc: Include the GuC registers in the error state

2025-08-06 Thread John Harrison
On 8/4/2025 4:35 PM, Daniele Ceraolo Spurio wrote: If GuC hangs, the GuC logs might not contain enough information to understand exactly why the hang occurred. In this case, we need to look at the GuC HW state to try to understand where the GuC is stuck. It is therefore useful to include the GuC

Re: [PATCH] drm/i915/psr: Do not trigger Frame Change events from frontbuffer flush

2025-08-06 Thread Hogander, Jouni
On Thu, 2025-08-07 at 04:38 +, Kandpal, Suraj wrote: > > Subject: [PATCH] drm/i915/psr: Do not trigger Frame Change events > > from > > frontbuffer flush > > > > We want to get rid of triggering "Frame Change" events from > > frontbuffer flush > > calls. We are about to move using TRANS_PUSH r

✓ i915.CI.BAT: success for drm/i915/dsi: Fix overflow issue in pclk parsing (rev2)

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Fix overflow issue in pclk parsing (rev2) URL : https://patchwork.freedesktop.org/series/152574/ State : success == Summary == CI Bug Log - changes from CI_DRM_16964 -> Patchwork_152574v2 Summary -

RE: [PATCH] drm/i915/psr: Do not trigger Frame Change events from frontbuffer flush

2025-08-06 Thread Kandpal, Suraj
> Subject: [PATCH] drm/i915/psr: Do not trigger Frame Change events from > frontbuffer flush > > We want to get rid of triggering "Frame Change" events from frontbuffer flush > calls. We are about to move using TRANS_PUSH register for this on LunarLake > and onwards. Touching TRANS_PUSH register f

[PATCH v2] drm/i915/dsi: Fix overflow issue in pclk parsing

2025-08-06 Thread Jouni Högander
Parsed divider p will overflow and is considered being valid in case pll_ctl == 0. Fix this by checking divider p before decreasing it. Also small improvement is made by using fls() instead of custom loop. v2: use fls() and check parsed divider Signed-off-by: Jouni Högander --- drivers/gpu/drm

RE: [PATCH] drm/i915/hdmi: add debugfs to contorl HDMI bpc

2025-08-06 Thread Lee, Shawn C
On Wed, Aug 06, 2025 at 05:19:39PM +0300, Imre Deak wrote: >On Wed, Aug 06, 2025 at 05:05:39PM +0300, Imre Deak wrote: >> On Wed, Aug 06, 2025 at 04:20:53AM +, Lee Shawn C wrote: >> > While performing HDMI compliance testing, test equipment may request >> > different bpc output for signal meas

Re: ✗ LGCI.VerificationFailed: failure for drm/i915: Remove legacy struct_mutex usage

2025-08-06 Thread Rodrigo Vivi
On Wed, Aug 06, 2025 at 02:51:19PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Remove legacy struct_mutex usage > URL : https://patchwork.freedesktop.org/series/152533/ > State : failure > > == Summary == > > Address 'luiz.me...@estudante.ufscar.br' is not on the allow

Re: [PATCH 00/19] drm/i915/tc: Fix enabled/disconnected DP-alt sink handling

2025-08-06 Thread Luca Coelho
On Wed, 2025-08-06 at 14:54 +0300, Imre Deak wrote: > On Wed, Aug 06, 2025 at 02:44:41PM +0300, Luca Coelho wrote: > > On Tue, 2025-08-05 at 10:36 +0300, Imre Deak wrote: > > > This patchset fixes an issue on LNL+, where the TypeC PHY's mode/state > > > is detected incorrectly during HW readout for

✓ i915.CI.BAT: success for drm/i915: drop __to_intel_display() transitional macro

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915: drop __to_intel_display() transitional macro URL : https://patchwork.freedesktop.org/series/152596/ State : success == Summary == CI Bug Log - changes from CI_DRM_16963 -> Patchwork_152596v1 Summary --

✓ i915.CI.BAT: success for drm/ttm: WIP limit the TTM pool to 32bit CPUs

2025-08-06 Thread Patchwork
== Series Details == Series: drm/ttm: WIP limit the TTM pool to 32bit CPUs URL : https://patchwork.freedesktop.org/series/152589/ State : success == Summary == CI Bug Log - changes from CI_DRM_16963 -> Patchwork_152589v1 Summary ---

✓ i915.CI.BAT: success for drm/i915/dsi: Fix overflow issue in pclk parsing

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Fix overflow issue in pclk parsing URL : https://patchwork.freedesktop.org/series/152574/ State : success == Summary == CI Bug Log - changes from CI_DRM_16962 -> Patchwork_152574v1 Summary ---

Re: [PATCH] drm/ttm: WIP limit the TTM pool to 32bit CPUs

2025-08-06 Thread Thomas Hellström
Hi, Christian On Wed, 2025-08-06 at 15:28 +0200, Christian König wrote: > On some old x86 systems we had the problem that changing the caching > flags > of system memory requires changing the global MTRR/PAT tables. > > But on any modern x86 system (CPUs introduced rughly after 2004) we > actuall

✗ i915.CI.BAT: failure for drm/i915/scaler: Fix for WA_14011503117 (rev2)

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915/scaler: Fix for WA_14011503117 (rev2) URL : https://patchwork.freedesktop.org/series/152571/ State : failure == Summary == CI Bug Log - changes from CI_DRM_16962 -> Patchwork_152571v2 Summary ---

Re: [PATCH] drm/i915/dsi: Fix overflow issue in pclk parsing

2025-08-06 Thread Hogander, Jouni
On Wed, 2025-08-06 at 15:42 +0300, Jani Nikula wrote: > On Wed, 06 Aug 2025, Jani Nikula wrote: > > On Wed, 06 Aug 2025, Jouni Högander > > wrote: > > > Parsed divider p will overflow and is considered being valid > > > divider in > > > case pll_ctl == 0. > > > > > > Fix this by using do while.

✓ i915.CI.BAT: success for Wait PSR idle before on dsb commit (rev2)

2025-08-06 Thread Patchwork
== Series Details == Series: Wait PSR idle before on dsb commit (rev2) URL : https://patchwork.freedesktop.org/series/152471/ State : success == Summary == CI Bug Log - changes from CI_DRM_16962 -> Patchwork_152471v2 Summary --- **SU

[PATCH 12/15] drm/i915/uncore: pass display to HAS_FPGA_DBG_UNCLAIMED()

2025-08-06 Thread Jani Nikula
Underneath, HAS_FPGA_DBG_UNCLAIMED() really expects struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_uncore.c | 3 ++- drivers/gpu/drm/i915/selftests/intel_uncore.c | 8

[PATCH 13/15] drm/i915/gvt: convert mmio table to struct intel_display

2025-08-06 Thread Jani Nikula
Underneath, the register macros really expect a struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 266 ++-- 1 file changed, 134 insertions(+), 13

[PATCH 14/15] drm/i915/reg: separate VLV_DSPCLK_GATE_D from DSPCLK_GATE_D

2025-08-06 Thread Jani Nikula
All the places that use DSPCLK_GATE_D are specific to certain platforms, and the parametrization of it to support VLV/CHV MMIO display base isn't really buying us anything. Add a separate macro for VLV_DSPCLK_GATE_D and use it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_di

[PATCH 15/15] drm/i915/display: drop __to_intel_display() usage

2025-08-06 Thread Jani Nikula
All the places that use __to_intel_display() now get passed a struct intel_display pointer, and the transitional adaptation macro has served its purpose. Remove the macro. Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_display_conversion.c | 2 +- .../gpu/drm/i915/display/intel_

[PATCH 11/15] drm/i915/drv: pass display to HAS_DISPLAY()

2025-08-06 Thread Jani Nikula
Underneath, HAS_DISPLAY() really expects a struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --gi

[PATCH 06/15] drm/i915/irq: pass display to macros that expect display

2025-08-06 Thread Jani Nikula
Underneath, the HAS_PCH_NOP(), DISPLAY_VER(), HAS_FBC(), and HAS_HOTPLUG() macros really expect a struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 13 +++-- 1 file

[PATCH 10/15] drm/i915/switcheroo: pass display to HAS_DISPLAY()

2025-08-06 Thread Jani Nikula
Underneath, HAS_DISPLAY() really expects a struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_switcheroo.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 09/15] drm/i915/gem: pass display to HAS_DISPLAY()

2025-08-06 Thread Jani Nikula
Underneath, HAS_DISPLAY() really expects a struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 07/15] drm/i915/dram: pass display to macros that expect display

2025-08-06 Thread Jani Nikula
Underneath, the HAS_DISPLAY() and DISPLAY_VER() macros really expect struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_dram.c | 5 +++-- 1 file changed, 3 insertions(+), 2 dele

[PATCH 08/15] drm/i915/gmch: pass display to DISPLAY_VER()

2025-08-06 Thread Jani Nikula
Underneath, DISPLAY_VER() really expects struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/soc/intel_gmch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 03/15] drm/i915/clockgating: pass display to for_each_pipe()

2025-08-06 Thread Jani Nikula
Underneath, for_each_pipe() really expects struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_clock_gating.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) dif

[PATCH 05/15] drm/i915/clockgating: pass display to DSPCNTR and DSPSURF register macros

2025-08-06 Thread Jani Nikula
Underneath, the macros expect struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_clock_gating.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu

[PATCH 04/15] drm/i915/clockgating: pass display to HAS_PCH_*() macros

2025-08-06 Thread Jani Nikula
Underneath, the HAS_PCH_*() macros expect struct intel_display. Switch to it in preparation for removing the transitional __to_intel_display() macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_clock_gating.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[PATCH 02/15] drm/i915/fb: pass display to HAS_GMCH() and DISPLAY_VER()

2025-08-06 Thread Jani Nikula
Convert some leftover i915 usages to struct intel_display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fb_pin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c

[PATCH 01/15] drm/i915/display: pass display to HAS_PCH_*() macros

2025-08-06 Thread Jani Nikula
Convert some leftover i915 usages to struct intel_display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_irq.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display

[PATCH 00/15] drm/i915: drop __to_intel_display() transitional macro

2025-08-06 Thread Jani Nikula
Switch to passing struct intel_display to all the macros that use __to_intel_display(), and once that's done, remove __to_intel_display(). We'll still need to get rid of struct intel_display usage like this outside of display, but explicit is better than implicit, and this prevents new accidental

✓ i915.CI.BAT: success for drm/i915/hdmi: add debugfs to contorl HDMI bpc

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: add debugfs to contorl HDMI bpc URL : https://patchwork.freedesktop.org/series/152562/ State : success == Summary == CI Bug Log - changes from CI_DRM_16962 -> Patchwork_152562v1 Summary ---

✓ i915.CI.BAT: success for drm/i915/scaler: Fix WA_14011503117

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915/scaler: Fix WA_14011503117 URL : https://patchwork.freedesktop.org/series/152556/ State : success == Summary == CI Bug Log - changes from CI_DRM_16962 -> Patchwork_152556v1 Summary --- **SUCCESS*

✓ i915.CI.BAT: success for Optimize vrr.guardband and fix LRR (rev3)

2025-08-06 Thread Patchwork
== Series Details == Series: Optimize vrr.guardband and fix LRR (rev3) URL : https://patchwork.freedesktop.org/series/151245/ State : success == Summary == CI Bug Log - changes from CI_DRM_16962 -> Patchwork_151245v3 Summary --- **SU

✗ LGCI.VerificationFailed: failure for drm/i915: Remove legacy struct_mutex usage

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915: Remove legacy struct_mutex usage URL : https://patchwork.freedesktop.org/series/152533/ State : failure == Summary == Address 'luiz.me...@estudante.ufscar.br' is not on the allowlist, which prevents CI from being triggered for this patch. If you want Int

[PULL] drm-xe-next-fixes

2025-08-06 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our last xe-next-fixes pr towards 6.17-rc1. It marks Xe driver as BROKEN if kernel page is not 4K, while we don't fix this ARM support, but work is in progress there. Also, mostly SRIOV fixes, but one patch that is more of a convenience, removing the need of a kernel

Re: [PATCH 1/3] drm/i915/display: hide global state iterators, remove unused

2025-08-06 Thread Jani Nikula
On Wed, 06 Aug 2025, Luca Coelho wrote: > On Thu, 2025-07-31 at 12:19 +0300, Jani Nikula wrote: >> for_each_{new,old,oldnew}_global_obj_in_state() are only used within >> intel_global_state.c, hide them there. intel_for_each_global_obj() is >> unused, remove it. >> >> Signed-off-by: Jani Nikula

✓ i915.CI.BAT: success for drm/i915: silence rpm wakeref asserts on GEN11_GU_MISC_IIR access

2025-08-06 Thread Patchwork
== Series Details == Series: drm/i915: silence rpm wakeref asserts on GEN11_GU_MISC_IIR access URL : https://patchwork.freedesktop.org/series/152524/ State : success == Summary == CI Bug Log - changes from CI_DRM_16962 -> Patchwork_152524v1

RE: [PATCH] drm/probe-helper: fix output polling not resuming after HPD IRQ storm

2025-08-06 Thread nicusor.huhu...@siemens.com
>>-Original Message- >>From: Dmitry Baryshkov >>Sent: Wednesday, August 6, 2025 3:34 PM >>To: Huhulea, Nicusor Liviu (FT FDS CES LX PBU 1) >> >>Cc: imre.d...@intel.com; sta...@vger.kernel.org; dri- >>de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; >>cip-...@lists.cip- >>p

Re: [PATCH] drm/i915/hdmi: add debugfs to contorl HDMI bpc

2025-08-06 Thread Imre Deak
On Wed, Aug 06, 2025 at 04:20:53AM +, Lee Shawn C wrote: > While performing HDMI compliance testing, test equipment may request > different bpc output for signal measurement. However, display driver > typically determines the maximum available bpc based on HW bandwidth. > > This patch introduc

Re: [PATCH] drm/i915/hdmi: add debugfs to contorl HDMI bpc

2025-08-06 Thread Imre Deak
On Wed, Aug 06, 2025 at 05:05:39PM +0300, Imre Deak wrote: > On Wed, Aug 06, 2025 at 04:20:53AM +, Lee Shawn C wrote: > > While performing HDMI compliance testing, test equipment may request > > different bpc output for signal measurement. However, display driver > > typically determines the ma

Re: [PATCH 5/5] drm/i915/dram: move fsb_freq and mem_freq to dram info

2025-08-06 Thread Jani Nikula
On Tue, 05 Aug 2025, Rodrigo Vivi wrote: > On Thu, Jul 31, 2025 at 05:21:25PM +0300, Jani Nikula wrote: >> Store fsb_freq and mem_freq in dram info the same way we do for other >> memory info on later platforms for a slightly more unified approach. >> >> This allows us to remove fsb_freq, mem_fre

Re: [PATCH 4/5] drm/i915/dram: bypass fsb/mem freq detection on dg2 and no display

2025-08-06 Thread Jani Nikula
On Tue, 05 Aug 2025, Rodrigo Vivi wrote: > On Thu, Jul 31, 2025 at 05:21:24PM +0300, Jani Nikula wrote: >> Non-display now calls the intel_fsb_freq() and intel_mem_freq() >> functions, so we don't have to have the frequencies initialized for dg2 >> or non-display cases. Is this enough amendmend f

[PATCH] drm/ttm: WIP limit the TTM pool to 32bit CPUs

2025-08-06 Thread Christian König
On some old x86 systems we had the problem that changing the caching flags of system memory requires changing the global MTRR/PAT tables. But on any modern x86 system (CPUs introduced rughly after 2004) we actually don't need that any more and can update the caching flags directly in the PTEs of t

Re: [PATCH] drm/i915/hdmi: add debugfs to contorl HDMI bpc

2025-08-06 Thread Jani Nikula
On Wed, 06 Aug 2025, Lee Shawn C wrote: > While performing HDMI compliance testing, test equipment may request > different bpc output for signal measurement. However, display driver > typically determines the maximum available bpc based on HW bandwidth. > > This patch introduces a new debugfs that

RE: [PATCH 08/19] drm/i915/tc: Move asserting the power state after reading TCSS_DDI_STATUS

2025-08-06 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Tuesday, 5 August 2025 10.37 > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Subject: [PATCH 08/19] drm/i915/tc: Move asserting the power state after > reading TCSS_DDI_STATUS > > Move assert

Re: [PATCH 00/19] drm/i915/tc: Fix enabled/disconnected DP-alt sink handling

2025-08-06 Thread Luca Coelho
On Wed, 2025-08-06 at 16:12 +0300, Imre Deak wrote: > On Wed, Aug 06, 2025 at 03:54:00PM +0300, Luca Coelho wrote: > > On Wed, 2025-08-06 at 14:54 +0300, Imre Deak wrote: > > > On Wed, Aug 06, 2025 at 02:44:41PM +0300, Luca Coelho wrote: > > > > On Tue, 2025-08-05 at 10:36 +0300, Imre Deak wrote: >

Re: [PATCH 00/19] drm/i915/tc: Fix enabled/disconnected DP-alt sink handling

2025-08-06 Thread Imre Deak
On Wed, Aug 06, 2025 at 03:54:00PM +0300, Luca Coelho wrote: > On Wed, 2025-08-06 at 14:54 +0300, Imre Deak wrote: > > On Wed, Aug 06, 2025 at 02:44:41PM +0300, Luca Coelho wrote: > > > On Tue, 2025-08-05 at 10:36 +0300, Imre Deak wrote: > > > > This patchset fixes an issue on LNL+, where the TypeC

Re: [PATCH v5] drm/i915/display: Optimize panel power-on wait time

2025-08-06 Thread Jani Nikula
On Mon, 04 Aug 2025, Dibin Moolakadan Subrahmanian wrote: > The current wait_panel_status() uses intel_de_wait(), > which internally on Xe platforms calls xe_mmio_wait32(). > xe_mmio_wait32() increases poll interval exponentially. > > This exponential poll interval increase causes unnessory dela

RE: [PATCH 07/19] drm/i915/tc: Move getting the power domain before reading DFLEX registers

2025-08-06 Thread Kahola, Mika
> -Original Message- > From: Intel-xe On Behalf Of Imre Deak > Sent: Tuesday, 5 August 2025 10.37 > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Subject: [PATCH 07/19] drm/i915/tc: Move getting the power domain before > reading DFLEX registers > > Move getting th

Re: [PATCH] drm/i915/dsi: Fix overflow issue in pclk parsing

2025-08-06 Thread Jani Nikula
On Wed, 06 Aug 2025, Jani Nikula wrote: > On Wed, 06 Aug 2025, Jouni Högander wrote: >> Parsed divider p will overflow and is considered being valid divider in >> case pll_ctl == 0. >> >> Fix this by using do while. >> >> Signed-off-by: Jouni Högander >> --- >> drivers/gpu/drm/i915/display/vlv_

Re: [PATCH] drm/probe-helper: fix output polling not resuming after HPD IRQ storm

2025-08-06 Thread Dmitry Baryshkov
On Wed, Aug 06, 2025 at 12:02:02PM +, nicusor.huhu...@siemens.com wrote: > > > >>-Original Message- > >>From: Imre Deak > >>Sent: Tuesday, August 5, 2025 6:20 PM > >>To: Dmitry Baryshkov > >>Cc: Huhulea, Nicusor Liviu (FT FDS CES LX PBU 1) > >>; sta...@vger.kernel.org; dri- > >>de..

Re: [PATCH] drm/i915/dsi: Fix overflow issue in pclk parsing

2025-08-06 Thread Jani Nikula
On Wed, 06 Aug 2025, Jouni Högander wrote: > Parsed divider p will overflow and is considered being valid divider in > case pll_ctl == 0. > > Fix this by using do while. > > Signed-off-by: Jouni Högander > --- > drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 4 ++-- > 1 file changed, 2 insertions(

RE: [PATCH 06/19] drm/i915/tc: Use the cached max lane count value

2025-08-06 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Tuesday, 5 August 2025 10.37 > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Subject: [PATCH 06/19] drm/i915/tc: Use the cached max lane count value > > Use the PHY's cached max lane count val

RE: [PATCH] drm/probe-helper: fix output polling not resuming after HPD IRQ storm

2025-08-06 Thread nicusor.huhu...@siemens.com
>>-Original Message- >>From: Imre Deak >>Sent: Tuesday, August 5, 2025 6:20 PM >>To: Dmitry Baryshkov >>Cc: Huhulea, Nicusor Liviu (FT FDS CES LX PBU 1) >>; sta...@vger.kernel.org; dri- >>de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; >>cip-...@lists.cip- >>project.org;

Re: [PATCH 00/19] drm/i915/tc: Fix enabled/disconnected DP-alt sink handling

2025-08-06 Thread Imre Deak
On Wed, Aug 06, 2025 at 02:44:41PM +0300, Luca Coelho wrote: > On Tue, 2025-08-05 at 10:36 +0300, Imre Deak wrote: > > This patchset fixes an issue on LNL+, where the TypeC PHY's mode/state > > is detected incorrectly during HW readout for a DP-alt sink that got > > enabled by BIOS/GOP, but later t

Re: [PATCH 00/19] drm/i915/tc: Fix enabled/disconnected DP-alt sink handling

2025-08-06 Thread Luca Coelho
On Tue, 2025-08-05 at 10:36 +0300, Imre Deak wrote: > This patchset fixes an issue on LNL+, where the TypeC PHY's mode/state > is detected incorrectly during HW readout for a DP-alt sink that got > enabled by BIOS/GOP, but later the sink got disconnected by the user > before the driver got loaded.

[PATCH] drm/i915/dsi: Fix overflow issue in pclk parsing

2025-08-06 Thread Jouni Högander
Parsed divider p will overflow and is considered being valid divider in case pll_ctl == 0. Fix this by using do while. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/displa

[PATCH] drm/i915/scaler: Fix for WA_14011503117

2025-08-06 Thread Nemesa Garg
Remove the redundant check statement. v2: Add scaler_id check [Jani] Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117") Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/skl_scaler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display

Re: [REGRESSION] tty lockup and WWAN loss after hibernate/suspend in 6.8+ on ThinkPad X1 Carbon Gen 10

2025-08-06 Thread Paolo Bonzini
On Wed, Aug 6, 2025 at 10:40 AM Andy Mindful wrote: > > Hello, > > Can somebody advise how to properly bisect issues in linux-stable > repository between v6.7.11 to v6.8-rc1 tags? If you can test 6.7 and bisect between 6.7 and 6.8-rc1 that would be the easiest. Paolo

RE: [PATCH] drm/i915/scaler: Fix for WA_14011503117

2025-08-06 Thread Garg, Nemesa
> -Original Message- > From: Jani Nikula > Sent: Wednesday, August 6, 2025 2:40 PM > To: Garg, Nemesa ; intel-gfx@lists.freedesktop.org > Cc: Garg, Nemesa > Subject: Re: [PATCH] drm/i915/scaler: Fix for WA_14011503117 > > On Wed, 06 Aug 2025, Nemesa Garg wrote: > > Remove the redunda

[PATCH] drm/i915/scaler: Fix for WA_14011503117

2025-08-06 Thread Nemesa Garg
Remove the redundant check statement. Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117") Signed-off-by: Nemesa Garg --- drivers/gpu/drm/i915/display/skl_scaler.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/

Re: [PATCH] drm/i915/scaler: Fix for WA_14011503117

2025-08-06 Thread Jani Nikula
On Wed, 06 Aug 2025, Nemesa Garg wrote: > Remove the redundant check statement. What if scaler_state->scaler_id == -1? > > Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117") > Signed-off-by: Nemesa Garg > --- > drivers/gpu/drm/i915/display/skl_scaler.c | 3 --- > 1 file changed, 3 deleti

Re: [PATCH 3/9] drm/i915: Change mutex initialization in intel_guc_log

2025-08-06 Thread Jani Nikula
On Tue, 05 Aug 2025, Luiz Otavio Mello wrote: > The intel_guc_log->relay.lock is currently initialized in > intel_guc_log_init_early(), but it lacks a corresponding destructor, > which can lead to a memory leak. That's not quite accurate. The destructor is only relevant for CONFIG_DEBUG_MUTEXES=y

Re: [PATCH 3/3] drm/i915/display: keep forward declarations together

2025-08-06 Thread Luca Coelho
On Thu, 2025-07-31 at 12:19 +0300, Jani Nikula wrote: > Adhere to prevalent style. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_global_state.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_global_state.

RE: [PATCH] drm/i915/scaler: Fix WA_14011503117

2025-08-06 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Wednesday, August 6, 2025 1:54 PM > To: Kandpal, Suraj ; intel...@lists.freedesktop.org; > intel-gfx@lists.freedesktop.org > Cc: Garg, Nemesa ; Kandpal, Suraj > ; Manna, Animesh > Subject: Re: [PATCH] drm/i915/scaler: Fix WA_14011503117

Re: [PATCH] drm/i915/scaler: Fix WA_14011503117

2025-08-06 Thread Jani Nikula
On Wed, 06 Aug 2025, Jani Nikula wrote: > On Wed, 06 Aug 2025, Suraj Kandpal wrote: >> This introduces and uses a variable id which is just uninitialized. >> What really needs to be used is the scaler_id. >> >> Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117") >> Signed-off-by: Suraj Kandp

Re: [PATCH 2/3] drm/i915/display: make struct __intel_global_objs_state opaque

2025-08-06 Thread Luca Coelho
On Thu, 2025-07-31 at 12:19 +0300, Jani Nikula wrote: > With struct __intel_global_objs_state only being accessed in > intel_global_state.c, we can make it opaque. The double underscore to > indicate internal becomes redundant, drop it. > > Signed-off-by: Jani Nikula > --- Reviewed-by: Luca Coel

Re: [PATCH 1/3] drm/i915/display: hide global state iterators, remove unused

2025-08-06 Thread Luca Coelho
On Thu, 2025-07-31 at 12:19 +0300, Jani Nikula wrote: > for_each_{new,old,oldnew}_global_obj_in_state() are only used within > intel_global_state.c, hide them there. intel_for_each_global_obj() is > unused, remove it. > > Signed-off-by: Jani Nikula > --- Reviewed-by: Luca Coelho -- Cheers, Luc

Re: [RESEND 2/3] drm/i915/gvt: use drm->debugfs_root for creating debugfs files

2025-08-06 Thread Luca Coelho
On Tue, 2025-07-29 at 12:57 +0300, Jani Nikula wrote: > Since commit 0b30d57acafc ("drm/debugfs: rework debugfs directory > creation v5") we should be using drm->debugfs_root instead of > minor->debugfs_root for creating debugfs files. > > Signed-off-by: Jani Nikula > --- Reviewed-by: Luca Coelh

Re: [RESEND 1/3] drm/i915/display: use drm->debugfs_root for creating debugfs files

2025-08-06 Thread Luca Coelho
On Tue, 2025-07-29 at 12:57 +0300, Jani Nikula wrote: > Since commit 0b30d57acafc ("drm/debugfs: rework debugfs directory > creation v5") we should be using drm->debugfs_root instead of > minor->debugfs_root for creating debugfs files. > > As a rule of thumb, use a local variable when there are tw

Re: [PATCH] drm/i915/scaler: Fix WA_14011503117

2025-08-06 Thread Jani Nikula
On Wed, 06 Aug 2025, Suraj Kandpal wrote: > This introduces and uses a variable id which is just uninitialized. > What really needs to be used is the scaler_id. > > Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117") > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/skl_sc